From: "Edwin Török" <edvin.torok@citrix.com>
To: Wei Liu <wei.liu2@citrix.com>,
Xen-devel <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
Ian Jackson <Ian.Jackson@eu.citrix.com>,
Sergey Dyasli <sergey.dyasli@citrix.com>
Subject: Re: [PATCH v2 3/3] xen-init-dom0: set Dom0 UUID if requested
Date: Thu, 15 Nov 2018 15:14:11 +0000 [thread overview]
Message-ID: <2161bbe2-155e-953f-b205-10ccf0b6c1f0@citrix.com> (raw)
In-Reply-To: <20181115143051.7420-1-wei.liu2@citrix.com>
On 15/11/2018 14:30, Wei Liu wrote:
> Read from XEN_CONFIG_DIR/dom0-uuid. If it contains a valid UUID, set
> it for Dom0.
>
> Signed-off-by: Wei Liu <wei.liu2@citrix.com>
> ---
> v2:
> 1. add missing "goto out"
> 2. print file names more
> 3. also print errno in xc_interface_open error message
> 4. take care of short-read
> ---
> tools/examples/Makefile | 1 +
> tools/examples/README | 2 ++
> tools/examples/dom0-uuid | 0
> tools/helpers/Makefile | 3 +-
> tools/helpers/xen-init-dom0.c | 65 +++++++++++++++++++++++++++++++++++++++++--
> 5 files changed, 67 insertions(+), 4 deletions(-)
> create mode 100644 tools/examples/dom0-uuid
I can't spot anything wrong here.
Acked-by: Edwin Török <edvin.torok@citrix.com>
Best regards,
--Edwin
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2018-11-15 15:14 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-14 18:17 [PATCH 0/3] Provide mechanism to set UUID for Dom0 Wei Liu
2018-11-14 18:17 ` [PATCH 1/3] tools: update examples/README Wei Liu
2018-11-15 14:28 ` Andrew Cooper
2018-11-15 14:32 ` Wei Liu
2018-11-20 14:25 ` Ian Jackson
2018-11-14 18:17 ` [PATCH 2/3] tools/helpers: make gen_stub_json_config accept an UUID argument Wei Liu
2018-11-15 14:42 ` Andrew Cooper
2018-11-20 14:24 ` Ian Jackson
2018-11-14 18:17 ` [PATCH 3/3] xen-init-dom0: set Dom0 UUID if requested Wei Liu
2018-11-14 20:16 ` Jason Andryuk
2018-11-14 20:44 ` Wei Liu
2018-11-15 10:45 ` Edwin Török
2018-11-15 11:20 ` Wei Liu
2018-11-15 13:35 ` Wei Liu
2018-11-15 13:36 ` Andrew Cooper
2018-11-15 14:30 ` [PATCH v2 " Wei Liu
2018-11-15 15:14 ` Edwin Török [this message]
2018-11-20 14:28 ` [PATCH " Ian Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2161bbe2-155e-953f-b205-10ccf0b6c1f0@citrix.com \
--to=edvin.torok@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=sergey.dyasli@citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).