From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH v2 3/9] xen/mm: move modify_identity_mmio to global file and drop __init Date: Mon, 24 Apr 2017 15:42:08 +0100 Message-ID: <219593bd-e49e-ecee-0bfa-e10d67251e4c@arm.com> References: <20170420151743.90889-1-roger.pau@citrix.com> <20170420151743.90889-4-roger.pau@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mail6.bemta6.messagelabs.com ([193.109.254.103]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d2fBt-0000EU-JT for xen-devel@lists.xenproject.org; Mon, 24 Apr 2017 14:42:13 +0000 In-Reply-To: <20170420151743.90889-4-roger.pau@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Roger Pau Monne , xen-devel@lists.xenproject.org Cc: Andrew Cooper , boris.ostrovsky@oracle.com, Stefano Stabellini , Jan Beulich List-Id: xen-devel@lists.xenproject.org SGkgUm9nZXIsCgpPbiAyMC8wNC8xNyAxNjoxNywgUm9nZXIgUGF1IE1vbm5lIHdyb3RlOgo+IEFu ZCBhbHNvIGFsbG93IGl0IHRvIGRvIG5vbi1pZGVudGl0eSBtYXBwaW5ncyBieSBhZGRpbmcgYSBu ZXcgcGFyYW1ldGVyLiBUaGlzCj4gZnVuY3Rpb24gd2lsbCBiZSBuZWVkZWQgaW4gb3RoZXIgcGFy dHMgYXBhcnQgZnJvbSBQVkggRG9tMCBidWlsZC4KPgo+IFNpZ25lZC1vZmYtYnk6IFJvZ2VyIFBh dSBNb25uw6kgPHJvZ2VyLnBhdUBjaXRyaXguY29tPgo+IC0tLQo+IENjOiBKYW4gQmV1bGljaCA8 amJldWxpY2hAc3VzZS5jb20+Cj4gQ2M6IEFuZHJldyBDb29wZXIgPGFuZHJldy5jb29wZXIzQGNp dHJpeC5jb20+Cj4gLS0tCj4gIHhlbi9hcmNoL3g4Ni9odm0vZG9tMF9idWlsZC5jIHwgMjIgKy0t LS0tLS0tLS0tLS0tLS0tLS0tLQo+ICB4ZW4vY29tbW9uL21lbW9yeS5jICAgICAgICAgICB8IDM0 ICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysKPiAgeGVuL2luY2x1ZGUveGVuL3Ay bS1jb21tb24uaCAgfCAgNCArKysrCj4gIDMgZmlsZXMgY2hhbmdlZCwgMzkgaW5zZXJ0aW9ucygr KSwgMjEgZGVsZXRpb25zKC0pCj4KPiBkaWZmIC0tZ2l0IGEveGVuL2FyY2gveDg2L2h2bS9kb20w X2J1aWxkLmMgYi94ZW4vYXJjaC94ODYvaHZtL2RvbTBfYnVpbGQuYwo+IGluZGV4IGNhODhjNTgz NWUuLjY1ZjYwNmQzM2EgMTAwNjQ0Cj4gLS0tIGEveGVuL2FyY2gveDg2L2h2bS9kb20wX2J1aWxk LmMKPiArKysgYi94ZW4vYXJjaC94ODYvaHZtL2RvbTBfYnVpbGQuYwo+IEBAIC02NCwyNyArNjQs NyBAQCBzdGF0aWMgc3RydWN0IGFjcGlfbWFkdF9ubWlfc291cmNlIF9faW5pdGRhdGEgKm5taXNy YzsKPiAgc3RhdGljIGludCBfX2luaXQgbW9kaWZ5X2lkZW50aXR5X21taW8oc3RydWN0IGRvbWFp biAqZCwgdW5zaWduZWQgbG9uZyBwZm4sCj4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgIHVuc2lnbmVkIGxvbmcgbnJfcGFnZXMsIGNvbnN0IGJvb2wgbWFwKQo+ICB7Cj4g LSAgICBpbnQgcmM7Cj4gLQo+IC0gICAgZm9yICggOyA7ICkKPiAtICAgIHsKPiAtICAgICAgICBy YyA9IChtYXAgPyBtYXBfbW1pb19yZWdpb25zIDogdW5tYXBfbW1pb19yZWdpb25zKQo+IC0gICAg ICAgICAgICAgKGQsIF9nZm4ocGZuKSwgbnJfcGFnZXMsIF9tZm4ocGZuKSk7Cj4gLSAgICAgICAg aWYgKCByYyA9PSAwICkKPiAtICAgICAgICAgICAgYnJlYWs7Cj4gLSAgICAgICAgaWYgKCByYyA8 IDAgKQo+IC0gICAgICAgIHsKPiAtICAgICAgICAgICAgcHJpbnRrKFhFTkxPR19XQVJOSU5HCj4g LSAgICAgICAgICAgICAgICAgICAiRmFpbGVkIHRvIGlkZW50aXR5ICVzbWFwIFslI2x4LCUjbHgp IGZvciBkJWQ6ICVkXG4iLAo+IC0gICAgICAgICAgICAgICAgICAgbWFwID8gIiIgOiAidW4iLCBw Zm4sIHBmbiArIG5yX3BhZ2VzLCBkLT5kb21haW5faWQsIHJjKTsKPiAtICAgICAgICAgICAgYnJl YWs7Cj4gLSAgICAgICAgfQo+IC0gICAgICAgIG5yX3BhZ2VzIC09IHJjOwo+IC0gICAgICAgIHBm biArPSByYzsKPiAtICAgICAgICBwcm9jZXNzX3BlbmRpbmdfc29mdGlycXMoKTsKPiAtICAgIH0K PiAtCj4gLSAgICByZXR1cm4gcmM7Cj4gKyAgICByZXR1cm4gbW9kaWZ5X21taW8oZCwgcGZuLCBw Zm4sIG5yX3BhZ2VzLCBtYXApOwo+ICB9Cj4KPiAgLyogUG9wdWxhdGUgYSBIVk0gbWVtb3J5IHJh bmdlIHVzaW5nIHRoZSBiaWdnZXN0IHBvc3NpYmxlIG9yZGVyLiAqLwo+IGRpZmYgLS1naXQgYS94 ZW4vY29tbW9uL21lbW9yeS5jIGIveGVuL2NvbW1vbi9tZW1vcnkuYwo+IGluZGV4IDUyODc5ZTc0 MzguLjBkOTcwNDgyY2IgMTAwNjQ0Cj4gLS0tIGEveGVuL2NvbW1vbi9tZW1vcnkuYwo+ICsrKyBi L3hlbi9jb21tb24vbWVtb3J5LmMKPiBAQCAtMTQzOCw2ICsxNDM4LDQwIEBAIGludCBwcmVwYXJl X3JpbmdfZm9yX2hlbHBlcigKPiAgICAgIHJldHVybiAwOwo+ICB9Cj4KPiAraW50IG1vZGlmeV9t bWlvKHN0cnVjdCBkb21haW4gKmQsIHVuc2lnbmVkIGxvbmcgZ2ZuLCB1bnNpZ25lZCBsb25nIHBm biwKCldoaWxzdCB5b3UgaW50cm9kdWNlIHRoaXMgbmV3IGZ1bmN0aW9uLCBwbGVhc2UgdXNlIG1m bl90IGFuZCBnZm5fdC4KCkFsc28gcy9wZm4vbWZuLwoKPiArICAgICAgICAgICAgICAgIHVuc2ln bmVkIGxvbmcgbnJfcGFnZXMsIGNvbnN0IGJvb2wgbWFwKQo+ICt7Cj4gKyAgICBpbnQgcmM7Cj4g Kwo+ICsgICAgLyoKPiArICAgICAqIE1ha2Ugc3VyZSB0aGlzIGZ1bmN0aW9uIGlzIG9ubHkgdXNl ZCBieSB0aGUgaGFyZHdhcmUgZG9tYWluLCBiZWNhdXNlIGl0Cj4gKyAgICAgKiBjYW4gdGFrZSBh biBhcmJpdHJhcnkgbG9uZyB0aW1lLCBhbmQgY291bGQgRG9TIHRoZSB3aG9sZSBzeXN0ZW0uCj4g KyAgICAgKi8KPiArICAgIEFTU0VSVChpc19oYXJkd2FyZV9kb21haW4oZCkpOwoKV2hhdCB3b3Vs ZCBiZSB0aGUgcGxhbiBmb3IgZ3Vlc3QgaWYgd2UgZGVjaWRlIHRvIHVzZSB2cGNpPwoKPiArCj4g KyAgICBmb3IgKCA7IDsgKQo+ICsgICAgewo+ICsgICAgICAgIHJjID0gKG1hcCA/IG1hcF9tbWlv X3JlZ2lvbnMgOiB1bm1hcF9tbWlvX3JlZ2lvbnMpCgpPbiBBUk0sIG1hcF9tbWlvX3JlZ2lvbnMg YW5kIHVubWFwX21taW9fcmVnaW9ucyB3aWxsIG1hcCB0aGUgTU1JTyB3aXRoIAp2ZXJ5IHN0cmlj dCBhdHRyaWJ1dGUuIEkgdGhpbmsgd2Ugd291bGQgbmVlZCBhbiBleHRyYSBhcmd1bWVudCB0byBr bm93IAp0aGUgd2FudGVkIG1lbW9yeSBhdHRyaWJ1dGUgKG1heWJlIHAybV90eXBlX3Q/KS4KCj4g KyAgICAgICAgICAgICAoZCwgX2dmbihnZm4pLCBucl9wYWdlcywgX21mbihwZm4pKTsKPiArICAg ICAgICBpZiAoIHJjID09IDAgKQo+ICsgICAgICAgICAgICBicmVhazsKPiArICAgICAgICBpZiAo IHJjIDwgMCApCj4gKyAgICAgICAgewo+ICsgICAgICAgICAgICBwcmludGsoWEVOTE9HX1dBUk5J TkcKCkkgd291bGQgcHJvYmFibHkgdXNlIFhFTkxPR19HX1dBUk5JTkcuCgo+ICsgICAgICAgICAg ICAgICAgICAgIkZhaWxlZCB0byAlc21hcCBbJSNseCwgJSNseCkgLT4gWyUjbHgsJSNseCkgZm9y IGQlZDogJWRcbiIsCj4gKyAgICAgICAgICAgICAgICAgICBtYXAgPyAiIiA6ICJ1biIsIGdmbiwg Z2ZuICsgbnJfcGFnZXMsIHBmbiwgcGZuICsgbnJfcGFnZXMsCj4gKyAgICAgICAgICAgICAgICAg ICBkLT5kb21haW5faWQsIHJjKTsKPiArICAgICAgICAgICAgYnJlYWs7Cj4gKyAgICAgICAgfQo+ ICsgICAgICAgIG5yX3BhZ2VzIC09IHJjOwo+ICsgICAgICAgIHBmbiArPSByYzsKPiArICAgICAg ICBnZm4gKz0gcmM7Cj4gKyAgICAgICAgcHJvY2Vzc19wZW5kaW5nX3NvZnRpcnFzKCk7Cj4gKyAg ICB9Cj4gKwo+ICsgICAgcmV0dXJuIHJjOwo+ICt9Cj4gKwo+ICAvKgo+ICAgKiBMb2NhbCB2YXJp YWJsZXM6Cj4gICAqIG1vZGU6IEMKPiBkaWZmIC0tZ2l0IGEveGVuL2luY2x1ZGUveGVuL3AybS1j b21tb24uaCBiL3hlbi9pbmNsdWRlL3hlbi9wMm0tY29tbW9uLmgKPiBpbmRleCA4Y2Q1YTZiNTAz Li4xMzA4ZGE0NGU3IDEwMDY0NAo+IC0tLSBhL3hlbi9pbmNsdWRlL3hlbi9wMm0tY29tbW9uLmgK PiArKysgYi94ZW4vaW5jbHVkZS94ZW4vcDJtLWNvbW1vbi5oCj4gQEAgLTEzLDQgKzEzLDggQEAg aW50IHVubWFwX21taW9fcmVnaW9ucyhzdHJ1Y3QgZG9tYWluICpkLAo+ICAgICAgICAgICAgICAg ICAgICAgICAgIHVuc2lnbmVkIGxvbmcgbnIsCj4gICAgICAgICAgICAgICAgICAgICAgICAgbWZu X3QgbWZuKTsKPgo+ICsKClNwdXJpb3VzIG5ld2xpbmUuCgo+ICtpbnQgbW9kaWZ5X21taW8oc3Ry dWN0IGRvbWFpbiAqZCwgdW5zaWduZWQgbG9uZyBnZm4sIHVuc2lnbmVkIGxvbmcgcGZuLAo+ICsg ICAgICAgICAgICAgICAgdW5zaWduZWQgbG9uZyBucl9wYWdlcywgY29uc3QgYm9vbCBtYXApOwo+ ICsKPiAgI2VuZGlmIC8qIF9YRU5fUDJNX0NPTU1PTl9IICovCj4KCkNoZWVycywKCi0tIApKdWxp ZW4gR3JhbGwKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f Clhlbi1kZXZlbCBtYWlsaW5nIGxpc3QKWGVuLWRldmVsQGxpc3RzLnhlbi5vcmcKaHR0cHM6Ly9s aXN0cy54ZW4ub3JnL3hlbi1kZXZlbAo=