xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Ian Jackson <Ian.Jackson@eu.citrix.com>
To: Wei Liu <wei.liu2@citrix.com>
Cc: Anthony PERARD <anthony.perard@citrix.com>,
	Xen-devel <xen-devel@lists.xenproject.org>,
	George Dunlap <george.dunlap@eu.citrix.com>
Subject: Re: [RFC] libxl hotplug / unplug emulated devices
Date: Fri, 20 May 2016 17:38:44 +0100	[thread overview]
Message-ID: <22335.15764.94991.14504@mariner.uk.xensource.com> (raw)
In-Reply-To: <20160520163451.GB31272@citrix.com>

Wei Liu writes ("[RFC] libxl hotplug / unplug emulated devices"):
> Recently I got a report on xen-users@ about xl network-attach not
> working for HVM guest.
> 
> I try to use
>   xl network-attach jessie-hvm 'bridge=xenbr0'
> and vif-bridge script complains that it can't add vifXX-emu to bridge.
> 
> The underlying issue is that the vif spec provided defaults to
> emulated nic, but libxl only populates a pv nic but doesn't call out
> via QMP to QEMU to populate one. Note that this issue not only affects
> nic device but essentially all device types.

Is it really sensible to offer emulated nic hotplug ?  That'd be
presented to the guest as pci hotplug, I guess ?

> I also experimented with block device:
>   xl block-attach jessie-hvm 'phy:/dev/DATA/disk,hdb,w'
> and it succeed, only pv disk is populated though.

That's what I would have expected.

Maybe the fix should be that xl network-attach should default hotplug
nics to pv only.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

  reply	other threads:[~2016-05-20 16:38 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-20 16:34 [RFC] libxl hotplug / unplug emulated devices Wei Liu
2016-05-20 16:38 ` Ian Jackson [this message]
2016-05-20 16:42   ` Wei Liu
2016-05-20 16:45     ` Andrew Cooper
2016-05-20 16:49       ` Wei Liu
2016-05-20 17:45   ` Wei Liu
2016-05-20 17:58     ` Ian Jackson
2016-05-20 18:04       ` Wei Liu
2016-05-20 18:05         ` Ian Jackson
2016-05-20 18:05         ` Wei Liu
2016-05-23  9:32     ` George Dunlap
2016-05-23 10:28       ` Wei Liu
2016-05-23 10:45     ` Wei Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=22335.15764.94991.14504@mariner.uk.xensource.com \
    --to=ian.jackson@eu.citrix.com \
    --cc=anthony.perard@citrix.com \
    --cc=george.dunlap@eu.citrix.com \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).