From: Julien Grall <julien.grall@linaro.org>
To: mjaggi@caviumnetworks.com, xen-devel@lists.xenproject.org
Cc: Andre.Przywara@arm.com, julien.grall@arm.com,
sstabellini@kernel.org, Manish Jaggi <mjaggi@cavium.com>
Subject: Re: [PATCH v5 2/5] ARM: ITS: Populate host_its_list from ACPI MADT Table
Date: Tue, 10 Oct 2017 11:04:02 +0100 [thread overview]
Message-ID: <226d1e36-e2a3-abfc-5959-2b010119b558@linaro.org> (raw)
In-Reply-To: <1507616218-2478-3-git-send-email-mjaggi@caviumnetworks.com>
Hi Manish,
On 10/10/17 07:16, mjaggi@caviumnetworks.com wrote:
> diff --git a/xen/include/asm-arm/gic_v3_its.h b/xen/include/asm-arm/gic_v3_its.h
> index 1fac1c7..e1be33c 100644
> --- a/xen/include/asm-arm/gic_v3_its.h
> +++ b/xen/include/asm-arm/gic_v3_its.h
> @@ -20,6 +20,7 @@
> #ifndef __ASM_ARM_ITS_H__
> #define __ASM_ARM_ITS_H__
>
> +#define GICV3_ITS_SIZE SZ_128K
You still didn't address my comment here... This *must* be moved close
to ITS_DOORBELL_OFFSET as the current place is just random.
> #define GITS_CTLR 0x000
> #define GITS_IIDR 0x004
> #define GITS_TYPER 0x008
Cheers,
--
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2017-10-10 10:04 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-10 6:16 [PATCH v5 0/5] ARM: ACPI: ITS: Add ITS Support for ACPI hardware domain mjaggi
2017-10-10 6:16 ` [PATCH v5 1/5] ARM: ITS: Introduce common function add_to_host_its_list mjaggi
2017-10-10 6:16 ` [PATCH v5 2/5] ARM: ITS: Populate host_its_list from ACPI MADT Table mjaggi
2017-10-10 10:04 ` Julien Grall [this message]
2017-10-10 6:16 ` [PATCH v5 3/5] ARM: ITS: Deny hardware domain access to ITS mjaggi
2017-10-10 10:11 ` Julien Grall
2017-10-10 6:16 ` [PATCH v5 4/5] ARM: Update Formula to compute MADT size using new callbacks in gic_hw_operations mjaggi
2017-10-10 9:10 ` Andre Przywara
2017-10-10 10:14 ` Julien Grall
2017-10-10 10:33 ` Manish Jaggi
2017-10-10 10:42 ` Julien Grall
2017-10-10 6:16 ` [PATCH v5 5/5] ARM: ITS: Expose ITS in the MADT table mjaggi
2017-10-10 10:17 ` Julien Grall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=226d1e36-e2a3-abfc-5959-2b010119b558@linaro.org \
--to=julien.grall@linaro.org \
--cc=Andre.Przywara@arm.com \
--cc=julien.grall@arm.com \
--cc=mjaggi@cavium.com \
--cc=mjaggi@caviumnetworks.com \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).