From: Ian Jackson <ian.jackson@eu.citrix.com>
To: Olaf Hering <olaf@aepfle.de>
Cc: Wei Liu <wei.liu2@citrix.com>, xen-devel@lists.xen.org
Subject: [PATCH] tools/firmware: pass EXTRAVERSION to seabios build
Date: Fri, 26 May 2017 15:04:17 +0100 [thread overview]
Message-ID: <22824.13793.439043.451505@mariner.uk.xensource.com> (raw)
In-Reply-To: <20170526124105.9567-1-olaf@aepfle.de>
Olaf Hering writes ("[PATCH] tools/firmware: pass EXTRAVERSION to seabios build"):
> Having a fixed version string in the seabios binary is cumbersome:
> - it is required to write something to '.version' in the toplevel
> directory of seabios-dir-remove.
> - it is required to pass EXTRAVERSION= to make.
I can't quite parse this, but:
> The latter is impossible without this change. For some reason an 'export
> EXTRAVERSION=something' prior to 'make tools' is not sufficient. It has
> to be passed in as cmdline option to make.
This seems like a real problem which should be improved. But maybe we
should use Xen's EXTRAVERSION by default ?
> +SEABIOS_EXTRAVERSION ?= "-prebuilt.xen.org"
I think this is a rather odd default value. This image is precisely
not prebuild, for example. Also I don't think a domain name is really
the right thing here.
Thanks,
Ian.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2017-05-26 14:04 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-26 12:41 [PATCH] tools/firmware: pass EXTRAVERSION to seabios build Olaf Hering
2017-05-26 14:04 ` Ian Jackson [this message]
2017-05-29 7:57 ` Olaf Hering
2017-05-30 11:33 ` Wei Liu
2017-05-30 11:40 ` Wei Liu
2017-05-30 12:25 ` Olaf Hering
2017-05-30 12:46 ` Wei Liu
2017-05-30 14:24 ` Olaf Hering
2017-05-30 14:35 ` Wei Liu
2017-05-30 14:46 ` Olaf Hering
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=22824.13793.439043.451505@mariner.uk.xensource.com \
--to=ian.jackson@eu.citrix.com \
--cc=olaf@aepfle.de \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).