Re: [PATCH v6 18/20] osstest: hook FreeBSD flight into cr-daily-branch

[Ian Jackson <ian.jackson@eu.citrix.com>]

Roger Pau Monne writes ("Re: [PATCH v6 18/20] osstest: hook FreeBSD flight into cr-daily-branch"):
> On Mon, Jul 24, 2017 at 04:44:09PM +0100, Ian Jackson wrote:
> > Roger Pau Monne writes ("[PATCH v6 18/20] osstest: hook FreeBSD flight into cr-daily-branch"):
> > > Add the missing pieces so that cr-daily-branch knows how to create a
> > > FreeBSD flight. This has been tested by calling `./cr-daily-branch
> > > freebsd-master`.
> > ...
> > > +TREE_FREEBSD=$PUSH_TREE_FREEBSD
> > 
> > PUSH_TREE_FREEBSD seems not to be defined.  Have I missed something ?
> > Likewise BASE_TREE_FREEBSD.
> 
> That's added in patch 17/20: "osstest: introduce a script to create a
> FreeBSD flight". I guess I should move it here for coherency.

Ah.  Sorry.  Yes, please.

> > > +	cd $repos/freebsd
> > > +	git push $TREE_FREEBSD $revision:refs/heads/$branchcore
> > 
> > We don't normally call the osstest output branch for trees which are
> > managed by someone else, "master".  Maybe we want another name ?
> 
> osstest-master, likewise we are going to have osstest-stable/11 if
> that looks fine.

In other trees directly in the xenbits toplevel we call them:
   tested/SOMETHING              (linux-pvops.git)
   xen-tested-master             (libvirt.git)
   osstest/frozen/XENBRANCH      (libvirt.git)

I suggest tested/$branchcore ?

Are you implying that $branchcore might be `stable/11' ?  I don't
think we can have osstest branches with / in...

> Thanks. Would you like me to merge the next patch (the mg-anoint
> integration) with this one?

No, it's easier this way I think.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel