Re: [PATCH OSSTEST 04/11] TestSupport: introduce set_host_prop

[Ian Jackson <ian.jackson@eu.citrix.com>]

Roger Pau Monne writes ("[PATCH OSSTEST 04/11] TestSupport: introduce set_host_prop"):
> This is from the code in mg-hosts. Switch cmd_setprops to use the
> newly introduced function.

I think this needs to be abstracted through jobdb.  Certainly these
SQL statements operating on the host_properties table are valid in
Executive mode only and shouldn't appear in TestSupport.pm.

If you are lucky then mg-hosts runs with $mjobdb set.  In which case
you make it call $mjobdb->set_host_prop.

I considered asking you to make a wrapper in TestSupport or
Osstest.pm.  But: actually, I think the wrapper in TestSupport ought
to take a $ho, not a hostname.  That would guarantee that a ts-*
script which used it had called selecthost and had the host allocated.

Whereas mg-hosts setprops is exceptional: it wants to be able to set
the property on a host without the user having allocated it.  I think
that justifies the "back door" entry via $mjobdb.

What do you think ?

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel