From: Ian Jackson <ian.jackson@eu.citrix.com>
To: Roger Pau Monne <roger.pau@citrix.com>
Cc: xen-devel@lists.xenproject.org
Subject: Re: [PATCH OSSTEST 07/11] ts-freebsd-host-install: add option to test memdisk options
Date: Fri, 28 Jul 2017 16:46:27 +0100 [thread overview]
Message-ID: <22907.23635.512041.178016@mariner.uk.xensource.com> (raw)
In-Reply-To: <20170728152637.20301-8-roger.pau@citrix.com>
Roger Pau Monne writes ("[PATCH OSSTEST 07/11] ts-freebsd-host-install: add option to test memdisk options"):
...
> +if ($bootonly) {
> + hostprop_putative_record($ho, "MemdiskAppend", $memdisk_append)
> + if $memdisk_append;
> + exit 0;
I think this should be a separate option --record-memdisk or
something. Since you might want to do a boot test for other reasons
and having it mess with the host properties would be very unexpected.
Ian.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2017-07-28 15:46 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-28 15:26 [PATCH OSSTEST 00/11] osstest: add support to examine the needed memdisk flags for each host Roger Pau Monne
2017-07-28 15:26 ` [PATCH OSSTEST 01/11] netboot_memdisk: allow each host to have different append values Roger Pau Monne
2017-07-28 15:26 ` [PATCH OSSTEST 02/11] ts-freebsd-host-install: fix image permissions Roger Pau Monne
2017-07-28 15:28 ` Ian Jackson
2017-07-28 15:26 ` [PATCH OSSTEST 03/11] sg-run-job: fix typo in the examine jobs Roger Pau Monne
2017-07-28 15:29 ` Ian Jackson
2017-07-28 15:26 ` [PATCH OSSTEST 04/11] TestSupport: introduce set_host_prop Roger Pau Monne
2017-07-28 15:39 ` Ian Jackson
2017-08-01 8:15 ` Roger Pau Monne
2017-08-01 13:01 ` Ian Jackson
2017-08-01 13:18 ` Roger Pau Monne
2017-08-01 14:13 ` Ian Jackson
2017-08-01 14:44 ` Roger Pau Monne
2017-08-01 15:07 ` Ian Jackson
2017-08-01 16:13 ` Roger Pau Monne
2017-07-28 15:26 ` [PATCH OSSTEST 05/11] mfi-common: move set_freebsd_runvars to mfi-common Roger Pau Monne
2017-07-28 15:41 ` Ian Jackson
2017-07-28 15:26 ` [PATCH OSSTEST 06/11] TestSupport: introduce hostprop_putative_record Roger Pau Monne
2017-07-28 15:42 ` Ian Jackson
2017-07-28 15:26 ` [PATCH OSSTEST 07/11] ts-freebsd-host-install: add option to test memdisk options Roger Pau Monne
2017-07-28 15:45 ` Ian Jackson
2017-08-01 8:58 ` Roger Pau Monne
2017-07-28 15:46 ` Ian Jackson [this message]
2017-07-28 15:26 ` [PATCH OSSTEST 08/11] ts-memdisk-try-append: introduce a script " Roger Pau Monne
2017-07-28 15:47 ` Ian Jackson
2017-07-28 15:26 ` [PATCH OSSTEST 09/11] ts-examine-hostprops-save: introduce a script to save properties Roger Pau Monne
2017-07-28 15:50 ` Ian Jackson
2017-07-28 15:26 ` [PATCH OSSTEST 10/11] make-hosts-flight: set runvars for FreeBSD test Roger Pau Monne
2017-07-28 15:52 ` Ian Jackson
2017-07-28 15:26 ` [PATCH OSSTEST 11/11] sg-run-job: hook the memdisk test into examine Roger Pau Monne
2017-07-28 15:52 ` Ian Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=22907.23635.512041.178016@mariner.uk.xensource.com \
--to=ian.jackson@eu.citrix.com \
--cc=roger.pau@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).