xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Juergen Gross <jgross@suse.com>
To: "Roger Pau Monné" <roger.pau@citrix.com>
Cc: Wei Liu <wei.liu2@citrix.com>,
	"George.Dunlap@eu.citrix.com" <George.Dunlap@eu.citrix.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	Ian Jackson <ian.jackson@eu.citrix.com>,
	Jan Beulich <JBeulich@suse.com>,
	xen-devel <xen-devel@lists.xenproject.org>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>
Subject: Re: Xen ballooning interface
Date: Mon, 13 Aug 2018 16:27:06 +0200	[thread overview]
Message-ID: <2475845c-70ec-d8c5-bf21-847de7aa32dc@suse.com> (raw)
In-Reply-To: <20180813141236.ks2x2kuuu7giqm6g@mac>

On 13/08/18 16:12, Roger Pau Monné wrote:
> On Mon, Aug 13, 2018 at 03:06:10PM +0200, Juergen Gross wrote:
>> Today's interface of Xen for memory ballooning is quite a mess. There
>> are some shortcomings which should be addressed somehow. After a
>> discussion on IRC there was consensus we should try to design a new
>> interface addressing the current and probably future needs.
> 
> Thanks for doing this! Memory accounting is quite messy at the moment
> :(.
> 
> [...]
>> Open questions
>> --------------
>> Should we add memory size information to the memory/vnode<n> nodes?
>>
>> Should the guest add information about its current balloon sizes to the
>> memory/vnode<n> nodes (i.e. after ballooning, or every x seconds while
>> ballooning)?
>>
>> Should we specify whether the guest is free to balloon another vnode
>> than specified?
> 
> What if the guest simply doesn't support NUMA and doesn't know
> anything about nodes?

Okay, that's a rather good answer to this question. :-)

>> Should memory hotplug (at least for PV domains) use the vnode specific
>> Xenstore paths, too, if supported by the guest?
> 
> Is extra memory hotplug going to set:
> 
> memory/vnode<n>/target-balloon-size = -1000
> 
> In order to tell the guest it can hotplug past the boot time amount of
> memory?

Interesting idea.

> 
>> Any further thoughts on this?
> 
> Isn't this just moving the memory accounting problem to another piece
> of software?
> 
> Currently as you say there's a difference between the xenstore target
> and the guest memory map, because some memory is used by the firmware.
> In order to solve this the toolstack won't provide an absolute memory
> target but instead a relative one to the guest that contains the
> balloon size.
> 
> But the toolstack interface (xl) still uses mem-set which is an
> absolute value. How is the toolstack going to accurately calculate the
> balloon size without knowing the extra memory used by the firmware?

mem-set will make use of the current allocation the tools know about and
add/subtract the difference to the new value to/from the target balloon
size. I don't think firmware will eat away memory when the guest OS is
already running. :-)

The main difference to today's situation is that the same component
which did the initial calculation how much memory should be allocated is
doing the math in case of ballooning now. So no guesswork any longer.


Juergen


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

  reply	other threads:[~2018-08-13 14:27 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-13 13:06 Xen ballooning interface Juergen Gross
2018-08-13 13:54 ` Jan Beulich
2018-08-13 14:12 ` Roger Pau Monné
2018-08-13 14:27   ` Juergen Gross [this message]
2018-08-13 14:59     ` Roger Pau Monné
     [not found] ` <5B718DB202000078001DD8A9@suse.com>
2018-08-13 14:20   ` Juergen Gross
2018-08-13 15:29     ` Jan Beulich
2018-08-13 15:44       ` Juergen Gross
2018-08-14  7:02         ` Jan Beulich
2018-08-14  7:19           ` Juergen Gross
2018-08-14  7:34             ` Jan Beulich
     [not found]   ` <9509907f?= =?UTF-8?B?77+9M2YzZe+/vTVkMWbvv70yZmI077+9OTkxZjBiNGFhODM0QHN1c2UuY29tPiA8?= =?UTF-8?Q?5B71A3EA02000078001DD953@prv1=ef=bf=bdmh.provo.novell.com>
     [not found]     ` <f4e4b?= =?UTF-8?B?Nzdj77+9MGU5Zu+/vTM2ZDHvv705Mzk077+9NzIwZmJiOWQyNDM1QHN1c2UuY29t?= =?UTF-8?Q?>
     [not found]       ` <5B727E7302000078001DDACB@prv1=ef=bf=bdmh.provo.novell.com>
     [not found]         ` <60?= =?UTF-8?Q?ff0fc0-04db-b9e8-077c-2037114f4b77@suse.com>
     [not found]           ` <5B72860202000078001?= =?UTF-8?Q?DDAFF@suse.com>
2018-08-14  7:47             ` Juergen Gross
2018-08-21  9:58 ` Wei Liu
2018-08-21 10:07   ` Roger Pau Monné

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2475845c-70ec-d8c5-bf21-847de7aa32dc@suse.com \
    --to=jgross@suse.com \
    --cc=George.Dunlap@eu.citrix.com \
    --cc=JBeulich@suse.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=boris.ostrovsky@oracle.com \
    --cc=ian.jackson@eu.citrix.com \
    --cc=roger.pau@citrix.com \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).