From: Julien Grall <julien.grall@arm.com>
To: Amit Singh Tomar <amittomer25@gmail.com>, xen-devel@lists.xenproject.org
Cc: andre.przywara@arm.com, sstabellini@kernel.org
Subject: Re: [PATCH v2 1/3] xen/arm: Add Amlogic Meson SoCs earlyprintk support
Date: Tue, 2 Apr 2019 11:05:15 +0100 [thread overview]
Message-ID: <24e1ca9f-dcba-36c7-9e7b-893fdda5b86f@arm.com> (raw)
In-Reply-To: <1553163935-12862-1-git-send-email-amittomer25@gmail.com>
Hi,
You don't have a cover letter, so I will comment here. I will leave Andre
reviewing the patch series.
In the future, please include a cover letter if you send more than one patch
together.
On 21/03/2019 10:25, Amit Singh Tomar wrote:
As I pointed out on v2, you are missing the commit message. Please read what I
wrote in v2 to know what you need to write here.
> Signed-off-by: Amit Singh Tomar <amittomer25@gmail.com>
Cheers,
--
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2019-04-02 10:05 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-21 10:25 [PATCH v2 1/3] xen/arm: Add Amlogic Meson SoCs earlyprintk support Amit Singh Tomar
2019-03-21 10:25 ` [PATCH v2 2/3] xen/arm: Add MESON UART driver for Amlogic Meson SoCs Amit Singh Tomar
2019-04-02 20:01 ` André Przywara
2019-04-09 9:39 ` Julien Grall
2019-04-09 9:39 ` [Xen-devel] " Julien Grall
2019-04-09 10:09 ` Amit Tomer
2019-04-09 10:09 ` [Xen-devel] " Amit Tomer
2019-04-09 10:14 ` Julien Grall
2019-04-09 10:14 ` [Xen-devel] " Julien Grall
2019-03-21 10:25 ` [PATCH v2 3/3] MAINTAINERS: add ARM meson serial driver Amit Singh Tomar
2019-04-02 20:01 ` André Przywara
2019-04-02 10:05 ` Julien Grall [this message]
2019-04-02 20:00 ` [PATCH v2 1/3] xen/arm: Add Amlogic Meson SoCs earlyprintk support André Przywara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=24e1ca9f-dcba-36c7-9e7b-893fdda5b86f@arm.com \
--to=julien.grall@arm.com \
--cc=amittomer25@gmail.com \
--cc=andre.przywara@arm.com \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).