From: Oleksandr Andrushchenko <andr2000@gmail.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: lars.kurth@citrix.com, iurii.konovalenko@globallogic.com,
vlad.babchuk@gmail.com, tim@xen.org, dario.faggioli@citrix.com,
ian.jackson@eu.citrix.com, al1img@gmail.com,
andrii.anisov@gmail.com, olekstysh@gmail.com,
embedded-pv-devel@lists.xenproject.org, julien.grall@arm.com,
david.vrabel@citrix.com, xen-devel@lists.xenproject.org,
oleksandr.dmytryshyn@globallogic.com, joculator@gmail.com
Subject: Re: [PATCH v14] This is the ABI for the two halves of a para-virtualized sound driver to communicate with each to other.
Date: Tue, 29 Nov 2016 18:55:32 +0200 [thread overview]
Message-ID: <284d0731-6540-f4c8-3ce3-5cc44e30a411@gmail.com> (raw)
In-Reply-To: <583DB63E02000078001235D3@prv-mh.provo.novell.com>
On 11/29/2016 06:09 PM, Jan Beulich wrote:
>>>> On 29.11.16 at 16:24, <andr2000@gmail.com> wrote:
>> +struct xensnd_req {
>> + uint16_t id;
>> + uint8_t operation;
>> + uint8_t stream_idx;
>> + uint32_t reserved;
>> + union {
>> + struct xensnd_open_req open;
>> + struct xensnd_rw_req rw;
>> + uint8_t padding[24];
>> + } op;
>> +};
>> +
>> +struct xensnd_resp {
>> + uint16_t id;
>> + uint8_t operation;
>> + uint8_t stream_idx;
>> + int8_t status;
>> + uint8_t padding[27];
> Other than in _req, this ought to be "reserved" imo.
IMO, this is a classic padding, why reserved?
> Jan
>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-11-29 16:55 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-29 15:24 [PATCH v14] sndif: add ABI for para-virtual sound Oleksandr Andrushchenko
2016-11-29 15:24 ` [PATCH v14] This is the ABI for the two halves of a para-virtualized sound driver to communicate with each to other Oleksandr Andrushchenko
2016-11-29 16:09 ` Jan Beulich
2016-11-29 16:55 ` Oleksandr Andrushchenko [this message]
2016-11-29 17:05 ` Jan Beulich
2016-11-29 17:27 ` Oleksandr Andrushchenko
2016-11-29 18:30 ` Dario Faggioli
2016-11-29 18:44 ` Oleksandr Andrushchenko
2016-11-30 8:45 ` Jan Beulich
2016-11-30 9:07 ` Oleksandr Andrushchenko
2016-11-29 16:06 ` [PATCH v14] sndif: add ABI for para-virtual sound Jan Beulich
2016-11-29 16:58 ` Oleksandr Andrushchenko
2016-11-29 17:10 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=284d0731-6540-f4c8-3ce3-5cc44e30a411@gmail.com \
--to=andr2000@gmail.com \
--cc=JBeulich@suse.com \
--cc=al1img@gmail.com \
--cc=andrii.anisov@gmail.com \
--cc=dario.faggioli@citrix.com \
--cc=david.vrabel@citrix.com \
--cc=embedded-pv-devel@lists.xenproject.org \
--cc=ian.jackson@eu.citrix.com \
--cc=iurii.konovalenko@globallogic.com \
--cc=joculator@gmail.com \
--cc=julien.grall@arm.com \
--cc=lars.kurth@citrix.com \
--cc=oleksandr.dmytryshyn@globallogic.com \
--cc=olekstysh@gmail.com \
--cc=tim@xen.org \
--cc=vlad.babchuk@gmail.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).