From: Zhenzhong Duan <zhenzhong.duan@oracle.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>,
Jan Beulich <JBeulich@suse.com>
Cc: Kevin Tian <kevin.tian@intel.com>,
Shane Wang <shane.wang@intel.com>,
Srinivas REDDY Eeda <srinivas.eeda@oracle.com>,
Boris Ostrovsky <boris.ostrovsky@oracle.com>,
Xen-Devel <xen-devel@lists.xen.org>,
Gang Wei <gang.wei@intel.com>
Subject: Re: [PATCH 2/2] x86/dmar: zap DMAR signature for dom0 once in TBOOT case
Date: Mon, 20 Aug 2018 16:58:24 +0800 [thread overview]
Message-ID: <29789eea-c894-2f3b-aaa2-70a24247cb15@oracle.com> (raw)
In-Reply-To: <91fba9e6-3639-f114-42a6-1057ce461c75@citrix.com>
On 2018/8/20 16:44, Andrew Cooper wrote:
> On 20/08/2018 09:30, Jan Beulich wrote:
>>>>> On 20.08.18 at 05:32, <zhenzhong.duan@oracle.com> wrote:
>>> When TBOOT enabled, acpi_parse_dmar() zap a copy of DMAR table rather
>>> than the real table, so make it controled by config option based on the
>>> fact that we already have done the real zapping in tboot_parse_dmar_table().
>> Is this just a cosmetic change, or is there any harm done by the extra
>> zapping?
>
> Before 123c7793797502b222300eb710cd3873dcca41ee, calling it multiple
> times would require an equivalent number of reinstate calls for it to work.
>
> That change went into Xen 4.6, whereas I guess this is a patch being
> upstreamed from Oracles 4.4 patchqueue?
Not for that reason. Patch is for upstream.
tboot_parse_dmar_table() called acpi_dmar_zap() the first time,
acpi_parse_dmar called it the second time, I thought it's a dup.
Thanks
Zhenzhong
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
prev parent reply other threads:[~2018-08-20 8:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-20 3:32 [PATCH 2/2] x86/dmar: zap DMAR signature for dom0 once in TBOOT case Zhenzhong Duan
2018-08-20 8:30 ` Jan Beulich
2018-08-20 8:40 ` Zhenzhong Duan
2018-08-20 8:44 ` Jan Beulich
2018-08-20 8:44 ` Andrew Cooper
2018-08-20 8:58 ` Zhenzhong Duan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=29789eea-c894-2f3b-aaa2-70a24247cb15@oracle.com \
--to=zhenzhong.duan@oracle.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=boris.ostrovsky@oracle.com \
--cc=gang.wei@intel.com \
--cc=kevin.tian@intel.com \
--cc=shane.wang@intel.com \
--cc=srinivas.eeda@oracle.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).