xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Juergen Gross <jgross@suse.com>
To: Ian Jackson <ian.jackson@eu.citrix.com>
Cc: xen-devel@lists.xenproject.org, wei.liu2@citrix.com
Subject: Re: [PATCH 2/4] tools: add pkg-config file for libxc
Date: Tue, 28 Feb 2017 13:32:06 +0100	[thread overview]
Message-ID: <2abb72a9-21d4-a4a2-e0f7-91c62e8970c5@suse.com> (raw)
In-Reply-To: <22709.23359.277320.354835@mariner.uk.xensource.com>

On 28/02/17 12:13, Ian Jackson wrote:
> Juergen Gross writes ("[PATCH 2/4] tools: add pkg-config file for libxc"):
>> When configuring the build of qemu the configure script is building
>> various test programs to determine the exact version of libxencontrol.
>>
>> Instead of a try and error approach needing updates for nearly each
>> new version of Xen just provide xencontrol.pc to be used via
>> pkg-config.
>>
>> In the end we need two different variants of that file: one for the
>> target system where eventually someone wants to build qemu, and one
>> for the local system to be used for building qemu as part of the Xen
>> build process.
> 
> I've not seen this done elsewhere, but I can see why it's attractive.

Thanks.

> I worry though that we're breaking new ground.  Did you come up with
> this idea yourself ?

Yes.

> Are you aware of other projects that do something similar ?

No.

TBH: did you have a look at qemu's configure script and how Xen support
is handled there? I'm really astonished they accept such a hackery.

And I don't see why it would be wrong to use the same basic mechanism
for our internal build as for any "normal" build outside of the Xen
build environment.

The next step would be to add the other Xen libraries and their
dependencies in order to get rid of all the additional include and
library directories when calling configure for qemu.


Juergen


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

  reply	other threads:[~2017-02-28 12:32 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-28 10:34 [PATCH 0/4] build enhancements related to qemu Juergen Gross
2017-02-28 10:34 ` [PATCH 1/4] interface: avoid redefinition of __XEN_INTERFACE_VERSION__ Juergen Gross
2017-02-28 10:57   ` Andrew Cooper
2017-02-28 11:10   ` Ian Jackson
2017-02-28 12:40     ` Juergen Gross
2017-02-28 11:11   ` Jan Beulich
     [not found]   ` <58B568FD020000780013E159@suse.com>
2017-02-28 12:24     ` Juergen Gross
2017-02-28 12:46       ` Jan Beulich
     [not found]       ` <58B57F3A020000780013E285@suse.com>
2017-02-28 13:10         ` Juergen Gross
2017-02-28 13:13           ` Ian Jackson
2017-02-28 13:52             ` Juergen Gross
2017-02-28 13:33           ` Jan Beulich
2017-02-28 10:34 ` [PATCH 2/4] tools: add pkg-config file for libxc Juergen Gross
2017-02-28 11:13   ` Ian Jackson
2017-02-28 12:32     ` Juergen Gross [this message]
2017-02-28 12:52       ` Wei Liu
2017-02-28 13:01       ` Ian Jackson
2017-02-28 10:34 ` [PATCH 3/4] tools: use a dedicated build directory for qemu Juergen Gross
2017-02-28 11:13   ` Ian Jackson
2017-02-28 12:33     ` Juergen Gross
2017-02-28 13:14       ` Ian Jackson
2017-02-28 13:18         ` Juergen Gross
2017-02-28 10:35 ` [PATCH 4/4] tools: set pkg-config path when configuring qemu Juergen Gross
2017-02-28 11:08   ` Ian Jackson
2017-02-28 11:11     ` Juergen Gross
2017-02-28 11:14       ` Ian Jackson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2abb72a9-21d4-a4a2-e0f7-91c62e8970c5@suse.com \
    --to=jgross@suse.com \
    --cc=ian.jackson@eu.citrix.com \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).