From: Ian Campbell <ian.campbell@citrix.com>
To: xen-devel@lists.xensource.com
Cc: Ian Campbell <ian.campbell@citrix.com>
Subject: [PATCH 22 of 32] tools: ocaml: rename the physinfo types and functions
Date: Wed, 20 Apr 2011 17:15:41 +0100 [thread overview]
Message-ID: <2b51da680128e2da4527.1303316141@cosworth.uk.xensource.com> (raw)
In-Reply-To: <patchbomb.1303316119@cosworth.uk.xensource.com>
# HG changeset patch
# User David Scott <dave.scott@eu.citrix.com>
# Date 1301507668 -3600
# Node ID 2b51da680128e2da4527278e6e119434fc37e50c
# Parent 4d51775a57f71338e86f2752ad44462ba69d6ba6
tools: ocaml: rename the physinfo types and functions
The aims are:
1. make the records instantiable if they have field names in common; and
2. to make it easier to derive the names programatically from the IDL
Signed-off-by: David Scott <dave.scott@eu.citrix.com>
Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
diff -r 4d51775a57f7 -r 2b51da680128 tools/ocaml/libs/xl/xl.ml
--- a/tools/ocaml/libs/xl/xl.ml Wed Mar 30 18:54:28 2011 +0100
+++ b/tools/ocaml/libs/xl/xl.ml Wed Mar 30 18:54:28 2011 +0100
@@ -192,20 +192,24 @@ module Device_pci = struct
external shutdown : domid -> unit = "stub_xl_device_pci_shutdown"
end
-type physinfo =
-{
- threads_per_core: int;
- cores_per_socket: int;
- max_cpu_id: int;
- nr_cpus: int;
- cpu_khz: int;
- total_pages: int64;
- free_pages: int64;
- scrub_pages: int64;
- nr_nodes: int;
- hwcap: int32 array;
- physcap: int32;
-}
+module Physinfo = struct
+ type t =
+ {
+ threads_per_core: int;
+ cores_per_socket: int;
+ max_cpu_id: int;
+ nr_cpus: int;
+ cpu_khz: int;
+ total_pages: int64;
+ free_pages: int64;
+ scrub_pages: int64;
+ nr_nodes: int;
+ hwcap: int32 array;
+ physcap: int32;
+ }
+ external get : unit -> t = "stub_xl_physinfo"
+
+end
type topology =
{
@@ -227,7 +231,6 @@ type button =
| Button_Sleep
external button_press : domid -> button -> unit = "stub_xl_button_press"
-external physinfo : unit -> physinfo = "stub_xl_physinfo"
external topologyinfo: unit -> topologyinfo = "stub_xl_topologyinfo"
diff -r 4d51775a57f7 -r 2b51da680128 tools/ocaml/libs/xl/xl.mli
--- a/tools/ocaml/libs/xl/xl.mli Wed Mar 30 18:54:28 2011 +0100
+++ b/tools/ocaml/libs/xl/xl.mli Wed Mar 30 18:54:28 2011 +0100
@@ -192,20 +192,24 @@ module Device_pci : sig
external shutdown : domid -> unit = "stub_xl_device_pci_shutdown"
end
-type physinfo =
-{
- threads_per_core: int;
- cores_per_socket: int;
- max_cpu_id: int;
- nr_cpus: int;
- cpu_khz: int;
- total_pages: int64;
- free_pages: int64;
- scrub_pages: int64;
- nr_nodes: int;
- hwcap: int32 array;
- physcap: int32;
-}
+module Physinfo : sig
+ type t =
+ {
+ threads_per_core: int;
+ cores_per_socket: int;
+ max_cpu_id: int;
+ nr_cpus: int;
+ cpu_khz: int;
+ total_pages: int64;
+ free_pages: int64;
+ scrub_pages: int64;
+ nr_nodes: int;
+ hwcap: int32 array;
+ physcap: int32;
+ }
+ external get : unit -> t = "stub_xl_physinfo"
+
+end
type topology =
{
@@ -227,7 +231,6 @@ type button =
| Button_Sleep
external button_press : domid -> button -> unit = "stub_xl_button_press"
-external physinfo : unit -> physinfo = "stub_xl_physinfo"
external topologyinfo: unit -> topologyinfo = "stub_xl_topologyinfo"
next prev parent reply other threads:[~2011-04-20 16:15 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-20 16:15 [PATCH 00 of 32] [V2] tools: libxl IDL, SeaBIOS, ocaml binding autogeneration, misc Ian Campbell
2011-04-20 16:15 ` [PATCH 01 of 32] tools: libxl: hide selection of hvmloader by default Ian Campbell
2011-04-20 16:15 ` [PATCH 02 of 32] tools: libxl: hide selection of device-model " Ian Campbell
2011-04-20 16:15 ` [PATCH 03 of 32] tools: libxl: write selected BIOS to xenstore Ian Campbell
2011-04-20 16:15 ` [PATCH 04 of 32] tools: support SeaBIOS. Use by default when upstream qemu is configured Ian Campbell
2011-04-20 16:15 ` [PATCH 05 of 32] tools: libxl: move all enum values into the libxl namespace Ian Campbell
2011-04-20 16:15 ` [PATCH 06 of 32] tools: libxl: generalize libxl_qemu_machine_type into libxl_domain_type Ian Campbell
2011-04-20 16:15 ` [PATCH 07 of 32] tools: libxl: namespace enum values within their type Ian Campbell
2011-04-20 16:15 ` [PATCH 08 of 32] tools: libxl: add an Enumeration type to the IDL Ian Campbell
2011-04-20 16:15 ` [PATCH 09 of 32] tools: libxl: add libxl_domid to IDL Ian Campbell
2011-04-20 16:15 ` [PATCH 10 of 32] tools: libxl: remove BitField type class from IDL Ian Campbell
2011-04-20 16:15 ` [PATCH 11 of 32] tools: libxl: add concept of in- and out-put only data types to IDL Ian Campbell
2011-04-20 16:15 ` [PATCH 12 of 32] tools: libxl: do not specify protocol node for disk or net Ian Campbell
2011-04-20 16:15 ` [PATCH 13 of 32] tools: ocaml: rename the device_nic types and functions Ian Campbell
2011-04-20 16:15 ` [PATCH 14 of 32] tools: ocaml: rename the disk_info " Ian Campbell
2011-04-20 16:15 ` [PATCH 15 of 32] tools: ocaml: rename the console " Ian Campbell
2011-04-20 16:15 ` [PATCH 16 of 32] tools: ocaml: rename the vkb " Ian Campbell
2011-04-20 16:15 ` [PATCH 17 of 32] tools: ocaml: rename the pci " Ian Campbell
2011-04-20 16:15 ` [PATCH 18 of 32] tools: ocaml: remove the domain_make and domain_build functions since they don't work Ian Campbell
2011-04-20 16:15 ` [PATCH 19 of 32] tools: ocaml: rename the create_info types and functions Ian Campbell
2011-04-20 16:15 ` [PATCH 20 of 32] tools: ocaml: rename the build_info " Ian Campbell
2011-04-20 16:15 ` [PATCH 21 of 32] tools: ocaml: rename the domain_build_state " Ian Campbell
2011-04-20 16:15 ` Ian Campbell [this message]
2011-04-20 16:15 ` [PATCH 23 of 32] tools: ocaml: rename the sched_credit " Ian Campbell
2011-04-20 16:15 ` [PATCH 24 of 32] tools: ocaml: rename the topology " Ian Campbell
2011-04-20 16:15 ` [PATCH 25 of 32] tools: libxl: remove libxl_domain_build_state from the IDL Ian Campbell
2011-04-20 16:15 ` [PATCH 26 of 32] tools: libxl: remove Reference meta-type from IDL Ian Campbell
2011-04-20 16:15 ` [PATCH 27 of 32] tools: libxl: reduce number of integer types in the IDL Ian Campbell
2011-04-20 16:15 ` [PATCH 28 of 32] tools: ocaml: reorder xl bindings type and function definitions to match IDL Ian Campbell
2011-04-20 16:15 ` [PATCH 29 of 32] tools: ocaml: remove create_info and build_info data types from xl bindings Ian Campbell
2011-04-20 16:15 ` [PATCH 30 of 32] tools: ocaml: tweak whitespace in preparation for autogenerating " Ian Campbell
2011-04-20 16:15 ` [PATCH 31 of 32] tools: ocaml: lay ground work for auto generating xl datatypes Ian Campbell
2011-04-20 16:15 ` [PATCH 32 of 32] tools: ocaml: autogenerate xl datatype definitions and ocaml<->C conversion Ian Campbell
-- strict thread matches above, loose matches on Subject: below --
2011-04-18 13:53 [PATCH 00 of 32] tools: libxl IDL, SeaBIOS, ocaml binding autogeneration, misc Ian Campbell
2011-04-18 13:53 ` [PATCH 22 of 32] tools: ocaml: rename the physinfo types and functions Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2b51da680128e2da4527.1303316141@cosworth.uk.xensource.com \
--to=ian.campbell@citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).