xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Julien Grall <julien.grall@arm.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>,
	Xen-devel <xen-devel@lists.xen.org>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
	Wei Liu <wei.liu2@citrix.com>,
	George Dunlap <George.Dunlap@eu.citrix.com>,
	Ian Jackson <ian.jackson@eu.citrix.com>, Tim Deegan <tim@xen.org>,
	Jan Beulich <JBeulich@suse.com>
Subject: Re: [PATCH] xen: Drop repeated semicolons
Date: Tue, 25 Jul 2017 11:55:05 +0100	[thread overview]
Message-ID: <2c0b5600-57eb-4e5e-d733-d72822da4e77@arm.com> (raw)
In-Reply-To: <1500980060-22687-1-git-send-email-andrew.cooper3@citrix.com>

Hi Andrew,

On 25/07/17 11:54, Andrew Cooper wrote:
> No functional change.
>
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>

Acked-by: Julien Grall <julien.grall@arm.com>

Cheers,

> ---
> CC: George Dunlap <George.Dunlap@eu.citrix.com>
> CC: Ian Jackson <ian.jackson@eu.citrix.com>
> CC: Jan Beulich <JBeulich@suse.com>
> CC: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> CC: Stefano Stabellini <sstabellini@kernel.org>
> CC: Julien Grall <julien.grall@arm.com>
> CC: Tim Deegan <tim@xen.org>
> CC: Wei Liu <wei.liu2@citrix.com>
> ---
>  xen/arch/arm/mm.c      | 2 +-
>  xen/arch/x86/hvm/rtc.c | 6 +++---
>  xen/common/domctl.c    | 2 +-
>  xen/common/schedule.c  | 2 +-
>  4 files changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c
> index 98260f6..a810a05 100644
> --- a/xen/arch/arm/mm.c
> +++ b/xen/arch/arm/mm.c
> @@ -278,7 +278,7 @@ static inline lpae_t mfn_to_xen_entry(mfn_t mfn, unsigned attr)
>              .contig = 0,          /* Assume non-contiguous */
>              .xn = 1,              /* No need to execute outside .text */
>              .avail = 0,           /* Reference count for domheap mapping */
> -        }};;
> +        }};
>      /*
>       * Setting the User bit is strange, but the ATS1H[RW] instructions
>       * don't seem to work otherwise, and since we never run on Xen
> diff --git a/xen/arch/x86/hvm/rtc.c b/xen/arch/x86/hvm/rtc.c
> index 4d792a4..bcfa169 100644
> --- a/xen/arch/x86/hvm/rtc.c
> +++ b/xen/arch/x86/hvm/rtc.c
> @@ -730,9 +730,9 @@ void rtc_migrate_timers(struct vcpu *v)
>
>      if ( v->vcpu_id == 0 )
>      {
> -        migrate_timer(&s->update_timer, v->processor);;
> -        migrate_timer(&s->update_timer2, v->processor);;
> -        migrate_timer(&s->alarm_timer, v->processor);;
> +        migrate_timer(&s->update_timer, v->processor);
> +        migrate_timer(&s->update_timer2, v->processor);
> +        migrate_timer(&s->alarm_timer, v->processor);
>      }
>  }
>
> diff --git a/xen/common/domctl.c b/xen/common/domctl.c
> index dfa3df9..d80488b 100644
> --- a/xen/common/domctl.c
> +++ b/xen/common/domctl.c
> @@ -703,7 +703,7 @@ long do_domctl(XEN_GUEST_HANDLE_PARAM(xen_domctl_t) u_domctl)
>          if ( op->cmd == XEN_DOMCTL_setvcpuaffinity )
>          {
>              cpumask_var_t new_affinity, old_affinity;
> -            cpumask_t *online = cpupool_domain_cpumask(v->domain);;
> +            cpumask_t *online = cpupool_domain_cpumask(v->domain);
>
>              /*
>               * We want to be able to restore hard affinity if we are trying
> diff --git a/xen/common/schedule.c b/xen/common/schedule.c
> index 1058e19..e83f4c7 100644
> --- a/xen/common/schedule.c
> +++ b/xen/common/schedule.c
> @@ -700,7 +700,7 @@ void restore_vcpu_affinity(struct domain *d)
>                      cpupool_domain_cpumask(v->domain));
>          v->processor = cpumask_any(cpumask_scratch_cpu(cpu));
>
> -        spin_unlock_irq(lock);;
> +        spin_unlock_irq(lock);
>
>          lock = vcpu_schedule_lock_irq(v);
>          v->processor = SCHED_OP(vcpu_scheduler(v), pick_cpu, v);
>

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

  reply	other threads:[~2017-07-25 10:55 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-25 10:54 [PATCH] xen: Drop repeated semicolons Andrew Cooper
2017-07-25 10:55 ` Julien Grall [this message]
2017-07-25 10:56 ` Wei Liu
2017-07-25 10:58 ` George Dunlap

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2c0b5600-57eb-4e5e-d733-d72822da4e77@arm.com \
    --to=julien.grall@arm.com \
    --cc=George.Dunlap@eu.citrix.com \
    --cc=JBeulich@suse.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=ian.jackson@eu.citrix.com \
    --cc=sstabellini@kernel.org \
    --cc=tim@xen.org \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).