* Bump tmem pool version to 1 to fix restore issue when tmem enabled
@ 2012-09-19 3:07 Zhenzhong Duan
2012-09-19 15:20 ` Dan Magenheimer
0 siblings, 1 reply; 2+ messages in thread
From: Zhenzhong Duan @ 2012-09-19 3:07 UTC (permalink / raw)
To: xen-devel; +Cc: dan.magenheimer, Feng Jin, JBeulich, konrad.wilk
Restore fail when tmem enabled both in hypervisor and guest.
This is due to spec version mismatch when restore a pool.
Signed-off-by: Zhenzhong Duan <zhenzhong.duan@oracle.com>
---
diff -r d1c3375c3f11 xen/common/tmem.c
--- a/xen/common/tmem.c Mon Sep 17 21:12:21 2012 +0100
+++ b/xen/common/tmem.c Wed Sep 19 10:28:05 2012 +0800
@@ -2397,7 +2397,8 @@
break;
rc = (pool->persistent ? TMEM_POOL_PERSIST : 0) |
(pool->shared ? TMEM_POOL_SHARED : 0) |
- (pool->pageshift << TMEM_POOL_PAGESIZE_SHIFT);
+ (pool->pageshift << TMEM_POOL_PAGESIZE_SHIFT) |
+ (TMEM_SPEC_VERSION << TMEM_POOL_VERSION_SHIFT);
break;
case TMEMC_SAVE_GET_POOL_NPAGES:
if ( pool == NULL )
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: Bump tmem pool version to 1 to fix restore issue when tmem enabled
2012-09-19 3:07 Bump tmem pool version to 1 to fix restore issue when tmem enabled Zhenzhong Duan
@ 2012-09-19 15:20 ` Dan Magenheimer
0 siblings, 0 replies; 2+ messages in thread
From: Dan Magenheimer @ 2012-09-19 15:20 UTC (permalink / raw)
To: Zhenzhong Duan, xen-devel; +Cc: Joe Jin, JBeulich, Konrad Wilk
> From: Zhenzhong Duan
> Sent: Tuesday, September 18, 2012 9:07 PM
> To: xen-devel@lists.xen.org
> Cc: Konrad Wilk; Dan Magenheimer; Feng Jin; JBeulich@suse.com
> Subject: Bump tmem pool version to 1 to fix restore issue when tmem enabled
>
> Restore fail when tmem enabled both in hypervisor and guest.
> This is due to spec version mismatch when restore a pool.
>
> Signed-off-by: Zhenzhong Duan <zhenzhong.duan@oracle.com>
Thanks zduan!
I think this fix makes tmem fully functional again on xen-unstable.
Acked-by: Dan Magenheimer <dan.magenheimer@oracle.com>
> ---
> diff -r d1c3375c3f11 xen/common/tmem.c
> --- a/xen/common/tmem.c Mon Sep 17 21:12:21 2012 +0100
> +++ b/xen/common/tmem.c Wed Sep 19 10:28:05 2012 +0800
> @@ -2397,7 +2397,8 @@
> break;
> rc = (pool->persistent ? TMEM_POOL_PERSIST : 0) |
> (pool->shared ? TMEM_POOL_SHARED : 0) |
> - (pool->pageshift << TMEM_POOL_PAGESIZE_SHIFT);
> + (pool->pageshift << TMEM_POOL_PAGESIZE_SHIFT) |
> + (TMEM_SPEC_VERSION << TMEM_POOL_VERSION_SHIFT);
> break;
> case TMEMC_SAVE_GET_POOL_NPAGES:
> if ( pool == NULL )
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-09-19 15:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-09-19 3:07 Bump tmem pool version to 1 to fix restore issue when tmem enabled Zhenzhong Duan
2012-09-19 15:20 ` Dan Magenheimer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).