From: Zhenzhong Duan <zhenzhong.duan@oracle.com>
To: Xen-Devel <xen-devel@lists.xen.org>
Cc: kevin.tian@intel.com, andrew.cooper3@citrix.com,
srinivas.eeda@oracle.com, JBeulich@suse.com,
shane.wang@intel.com, boris.ostrovsky@oracle.com,
gang.wei@intel.com
Subject: [PATCH v4 2/2] x86/dmar: zap DMAR signature for dom0 once in TBOOT case
Date: Tue, 21 Aug 2018 20:29:13 -0700 (PDT) [thread overview]
Message-ID: <2f9981e2-29bb-40a1-84e3-39f6e0ce12eb@default> (raw)
Commit 6c298ecc1f ("vtd: Reinstate ACPI DMAR on system shutdown or
S3/S4/S5") did everything for acpi_dmar_zap() call to be unnecessary,
except for invoking the function from acpi_parse_dmar(), which
123c779379 ("VTd/dmar: Tweak how the DMAR table is clobbered")
added several years later.
Some stale comments are also removed, No functional change.
Signed-off-by: Zhenzhong Duan <zhenzhong.duan@oracle.com>
---
v4: fixup description per Jan
xen/arch/x86/tboot.c | 6 ------
1 files changed, 0 insertions(+), 6 deletions(-)
diff --git a/xen/arch/x86/tboot.c b/xen/arch/x86/tboot.c
index d5a5292..1006f95 100644
--- a/xen/arch/x86/tboot.c
+++ b/xen/arch/x86/tboot.c
@@ -461,8 +461,6 @@ int __init tboot_parse_dmar_table(acpi_table_handler dmar_handler)
if ( txt_heap_base == 0 )
return 1;
- /* map TXT heap into Xen addr space */
-
/* walk heap to SinitMleData */
pa = txt_heap_base;
/* skip BiosData */
@@ -490,10 +488,6 @@ int __init tboot_parse_dmar_table(acpi_table_handler dmar_handler)
rc = dmar_handler(dmar_table);
xfree(dmar_table);
- /* acpi_parse_dmar() zaps APCI DMAR signature in TXT heap table */
- /* but dom0 will read real table, so must zap it there too */
- acpi_dmar_zap();
-
return rc;
}
--
1.7.3
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
reply other threads:[~2018-08-22 3:29 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2f9981e2-29bb-40a1-84e3-39f6e0ce12eb@default \
--to=zhenzhong.duan@oracle.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=boris.ostrovsky@oracle.com \
--cc=gang.wei@intel.com \
--cc=kevin.tian@intel.com \
--cc=shane.wang@intel.com \
--cc=srinivas.eeda@oracle.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).