From: Andres Lagar-Cavilla <andres@lagarcavilla.org>
To: xen-devel@lists.xensource.com
Cc: george.dunlap@eu.citrix.com, andres@gridcentric.ca,
keir.xen@gmail.com, tim@xen.org, adin@gridcentric.ca
Subject: [PATCH 5 of 7] x86/mm: Revert changeset 24582:f6c33cfe7333
Date: Thu, 09 Feb 2012 00:45:50 -0500 [thread overview]
Message-ID: <316d227dd52622b26b10.1328766350@xdev.gridcentric.ca> (raw)
In-Reply-To: <patchbomb.1328766345@xdev.gridcentric.ca>
xen/arch/x86/mm/p2m.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
With synchronized p2m lookups this is no longer needed, and we can lock the p2m
up-front.
Signed-off-by: Andres Lagar-Cavilla <andres@lagarcavilla.org>
Acked-by: Tim Deegan <tjd-xen@phlegethon.org>
diff -r f2d967332acc -r 316d227dd526 xen/arch/x86/mm/p2m.c
--- a/xen/arch/x86/mm/p2m.c
+++ b/xen/arch/x86/mm/p2m.c
@@ -361,6 +361,8 @@ void p2m_teardown(struct p2m_domain *p2m
if (p2m == NULL)
return;
+ p2m_lock(p2m);
+
#ifdef __x86_64__
for ( gfn=0; gfn < p2m->max_mapped_pfn; gfn++ )
{
@@ -374,8 +376,6 @@ void p2m_teardown(struct p2m_domain *p2m
}
#endif
- p2m_lock(p2m);
-
p2m->phys_table = pagetable_null();
while ( (pg = page_list_remove_head(&p2m->pages)) )
next prev parent reply other threads:[~2012-02-09 5:45 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-09 5:45 [PATCH 0 of 7] Synchronized p2m lookups v2 Andres Lagar-Cavilla
2012-02-09 5:45 ` [PATCH 1 of 7] Make p2m lookups fully synchronized wrt modifications Andres Lagar-Cavilla
2012-02-10 15:33 ` Tim Deegan
2012-02-09 5:45 ` [PATCH 2 of 7] Clean up locking now that p2m lockups are fully synchronized Andres Lagar-Cavilla
2012-02-09 5:45 ` [PATCH 3 of 7] Rework locking in the PoD layer Andres Lagar-Cavilla
2012-02-09 12:07 ` George Dunlap
2012-02-09 14:45 ` Andres Lagar-Cavilla
2012-02-10 15:36 ` Tim Deegan
2012-02-10 15:43 ` Tim Deegan
2012-02-10 15:47 ` Andres Lagar-Cavilla
2012-02-10 15:59 ` George Dunlap
2012-02-09 5:45 ` [PATCH 4 of 7] Re-order calls to put_gfn() around wait queue invocations Andres Lagar-Cavilla
2012-02-09 5:45 ` Andres Lagar-Cavilla [this message]
2012-02-09 5:45 ` [PATCH 6 of 7] x86/mm: Refactor possibly deadlocking get_gfn calls Andres Lagar-Cavilla
2012-02-09 5:45 ` [PATCH 7 of 7] x86/mm: When removing/adding a page from/to the physmap, keep in mind it could be shared Andres Lagar-Cavilla
2012-02-10 15:38 ` Tim Deegan
2012-02-10 16:10 ` [PATCH 0 of 7] Synchronized p2m lookups v2 Tim Deegan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=316d227dd52622b26b10.1328766350@xdev.gridcentric.ca \
--to=andres@lagarcavilla.org \
--cc=adin@gridcentric.ca \
--cc=andres@gridcentric.ca \
--cc=george.dunlap@eu.citrix.com \
--cc=keir.xen@gmail.com \
--cc=tim@xen.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).