* [PATCH] tools: libxl: link libxlu against libxl.
@ 2014-08-04 9:58 Ian Campbell
2014-09-04 13:44 ` Ian Campbell
2014-12-15 10:02 ` Ian Campbell
0 siblings, 2 replies; 7+ messages in thread
From: Ian Campbell @ 2014-08-04 9:58 UTC (permalink / raw)
To: xen-devel, ian.jackson; +Cc: Bastian Blank, Ian Campbell
It uses libxl_defbool_set and must therefore be linked against the
right library.
Spotted by dpkg-shlibdeps and pointed out by Bastian Blank:
dpkg-shlibdeps: warning: symbol libxl_defbool_set used by debian/libxen-4.4/usr/lib/libxlutil-4.4.so found in none of the libraries
This required switching the make rule from $^ to an explicit
LIBXLU_OBJS since the former now includes libxenlight.so.
Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
Cc: Bastian Blank <waldi@debian.org>
---
tools/libxl/Makefile | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/tools/libxl/Makefile b/tools/libxl/Makefile
index bd0db3b..e61048d 100644
--- a/tools/libxl/Makefile
+++ b/tools/libxl/Makefile
@@ -35,7 +35,7 @@ LDFLAGS += $(PTHREAD_LDFLAGS)
LIBXL_LIBS += $(PTHREAD_LIBS)
LIBXL_LIBS += $(LIBXL_LIBS-y)
-LIBXLU_LIBS =
+LIBXLU_LIBS = libxenlight.so
LIBXL_OBJS-y = osdeps.o libxl_paths.o libxl_bootloader.o flexarray.o
ifeq ($(LIBXL_BLKTAP),y)
@@ -213,8 +213,8 @@ libxlutil.so: libxlutil.so.$(XLUMAJOR)
libxlutil.so.$(XLUMAJOR): libxlutil.so.$(XLUMAJOR).$(XLUMINOR)
$(SYMLINK_SHLIB) $< $@
-libxlutil.so.$(XLUMAJOR).$(XLUMINOR): $(LIBXLU_OBJS)
- $(CC) $(LDFLAGS) -Wl,$(SONAME_LDFLAG) -Wl,libxlutil.so.$(XLUMAJOR) $(SHLIB_LDFLAGS) -o $@ $^ $(LIBXLU_LIBS) $(APPEND_LDFLAGS)
+libxlutil.so.$(XLUMAJOR).$(XLUMINOR): $(LIBXLU_OBJS) libxenlight.so
+ $(CC) $(LDFLAGS) -Wl,$(SONAME_LDFLAG) -Wl,libxlutil.so.$(XLUMAJOR) $(SHLIB_LDFLAGS) -o $@ $(LIBXLU_OBJS) $(LIBXLU_LIBS) $(APPEND_LDFLAGS)
libxlutil.a: $(LIBXLU_OBJS)
$(AR) rcs libxlutil.a $^
--
1.7.10.4
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] tools: libxl: link libxlu against libxl.
2014-08-04 9:58 [PATCH] tools: libxl: link libxlu against libxl Ian Campbell
@ 2014-09-04 13:44 ` Ian Campbell
2014-12-15 10:02 ` Ian Campbell
1 sibling, 0 replies; 7+ messages in thread
From: Ian Campbell @ 2014-09-04 13:44 UTC (permalink / raw)
To: xen-devel; +Cc: Bastian Blank, ian.jackson
On Mon, 2014-08-04 at 10:58 +0100, Ian Campbell wrote:
ping?
> It uses libxl_defbool_set and must therefore be linked against the
> right library.
>
> Spotted by dpkg-shlibdeps and pointed out by Bastian Blank:
>
> dpkg-shlibdeps: warning: symbol libxl_defbool_set used by debian/libxen-4.4/usr/lib/libxlutil-4.4.so found in none of the libraries
>
> This required switching the make rule from $^ to an explicit
> LIBXLU_OBJS since the former now includes libxenlight.so.
>
> Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
> Cc: Bastian Blank <waldi@debian.org>
> ---
> tools/libxl/Makefile | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/tools/libxl/Makefile b/tools/libxl/Makefile
> index bd0db3b..e61048d 100644
> --- a/tools/libxl/Makefile
> +++ b/tools/libxl/Makefile
> @@ -35,7 +35,7 @@ LDFLAGS += $(PTHREAD_LDFLAGS)
> LIBXL_LIBS += $(PTHREAD_LIBS)
> LIBXL_LIBS += $(LIBXL_LIBS-y)
>
> -LIBXLU_LIBS =
> +LIBXLU_LIBS = libxenlight.so
>
> LIBXL_OBJS-y = osdeps.o libxl_paths.o libxl_bootloader.o flexarray.o
> ifeq ($(LIBXL_BLKTAP),y)
> @@ -213,8 +213,8 @@ libxlutil.so: libxlutil.so.$(XLUMAJOR)
> libxlutil.so.$(XLUMAJOR): libxlutil.so.$(XLUMAJOR).$(XLUMINOR)
> $(SYMLINK_SHLIB) $< $@
>
> -libxlutil.so.$(XLUMAJOR).$(XLUMINOR): $(LIBXLU_OBJS)
> - $(CC) $(LDFLAGS) -Wl,$(SONAME_LDFLAG) -Wl,libxlutil.so.$(XLUMAJOR) $(SHLIB_LDFLAGS) -o $@ $^ $(LIBXLU_LIBS) $(APPEND_LDFLAGS)
> +libxlutil.so.$(XLUMAJOR).$(XLUMINOR): $(LIBXLU_OBJS) libxenlight.so
> + $(CC) $(LDFLAGS) -Wl,$(SONAME_LDFLAG) -Wl,libxlutil.so.$(XLUMAJOR) $(SHLIB_LDFLAGS) -o $@ $(LIBXLU_OBJS) $(LIBXLU_LIBS) $(APPEND_LDFLAGS)
>
> libxlutil.a: $(LIBXLU_OBJS)
> $(AR) rcs libxlutil.a $^
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] tools: libxl: link libxlu against libxl.
2014-08-04 9:58 [PATCH] tools: libxl: link libxlu against libxl Ian Campbell
2014-09-04 13:44 ` Ian Campbell
@ 2014-12-15 10:02 ` Ian Campbell
2014-12-17 20:54 ` Konrad Rzeszutek Wilk
1 sibling, 1 reply; 7+ messages in thread
From: Ian Campbell @ 2014-12-15 10:02 UTC (permalink / raw)
To: xen-devel, Ian Jackson, Konrad Rzeszutek Wilk; +Cc: Bastian Blank
On Mon, 2014-08-04 at 10:58 +0100, Ian Campbell wrote:
Ping again. This issue has resurfaced in the Debian packaging of the 4.5
rcs. I think we should fix this for 4.5, the risks are minimal.
> It uses libxl_defbool_set and must therefore be linked against the
> right library.
>
> Spotted by dpkg-shlibdeps and pointed out by Bastian Blank:
>
> dpkg-shlibdeps: warning: symbol libxl_defbool_set used by debian/libxen-4.4/usr/lib/libxlutil-4.4.so found in none of the libraries
>
> This required switching the make rule from $^ to an explicit
> LIBXLU_OBJS since the former now includes libxenlight.so.
>
> Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
> Cc: Bastian Blank <waldi@debian.org>
> ---
> tools/libxl/Makefile | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/tools/libxl/Makefile b/tools/libxl/Makefile
> index bd0db3b..e61048d 100644
> --- a/tools/libxl/Makefile
> +++ b/tools/libxl/Makefile
> @@ -35,7 +35,7 @@ LDFLAGS += $(PTHREAD_LDFLAGS)
> LIBXL_LIBS += $(PTHREAD_LIBS)
> LIBXL_LIBS += $(LIBXL_LIBS-y)
>
> -LIBXLU_LIBS =
> +LIBXLU_LIBS = libxenlight.so
>
> LIBXL_OBJS-y = osdeps.o libxl_paths.o libxl_bootloader.o flexarray.o
> ifeq ($(LIBXL_BLKTAP),y)
> @@ -213,8 +213,8 @@ libxlutil.so: libxlutil.so.$(XLUMAJOR)
> libxlutil.so.$(XLUMAJOR): libxlutil.so.$(XLUMAJOR).$(XLUMINOR)
> $(SYMLINK_SHLIB) $< $@
>
> -libxlutil.so.$(XLUMAJOR).$(XLUMINOR): $(LIBXLU_OBJS)
> - $(CC) $(LDFLAGS) -Wl,$(SONAME_LDFLAG) -Wl,libxlutil.so.$(XLUMAJOR) $(SHLIB_LDFLAGS) -o $@ $^ $(LIBXLU_LIBS) $(APPEND_LDFLAGS)
> +libxlutil.so.$(XLUMAJOR).$(XLUMINOR): $(LIBXLU_OBJS) libxenlight.so
> + $(CC) $(LDFLAGS) -Wl,$(SONAME_LDFLAG) -Wl,libxlutil.so.$(XLUMAJOR) $(SHLIB_LDFLAGS) -o $@ $(LIBXLU_OBJS) $(LIBXLU_LIBS) $(APPEND_LDFLAGS)
>
> libxlutil.a: $(LIBXLU_OBJS)
> $(AR) rcs libxlutil.a $^
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] tools: libxl: link libxlu against libxl.
2014-12-15 10:02 ` Ian Campbell
@ 2014-12-17 20:54 ` Konrad Rzeszutek Wilk
2014-12-18 10:25 ` Ian Campbell
2015-01-06 11:44 ` Ian Campbell
0 siblings, 2 replies; 7+ messages in thread
From: Konrad Rzeszutek Wilk @ 2014-12-17 20:54 UTC (permalink / raw)
To: Ian Campbell; +Cc: Bastian Blank, Ian Jackson, xen-devel
On Mon, Dec 15, 2014 at 10:02:31AM +0000, Ian Campbell wrote:
> On Mon, 2014-08-04 at 10:58 +0100, Ian Campbell wrote:
>
> Ping again. This issue has resurfaced in the Debian packaging of the 4.5
> rcs. I think we should fix this for 4.5, the risks are minimal.
Ah, the patch did not have 'for-xen-4.5' in it :-P
>
> > It uses libxl_defbool_set and must therefore be linked against the
> > right library.
> >
> > Spotted by dpkg-shlibdeps and pointed out by Bastian Blank:
> >
> > dpkg-shlibdeps: warning: symbol libxl_defbool_set used by debian/libxen-4.4/usr/lib/libxlutil-4.4.so found in none of the libraries
> >
> > This required switching the make rule from $^ to an explicit
> > LIBXLU_OBJS since the former now includes libxenlight.so.
> >
> > Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
> > Cc: Bastian Blank <waldi@debian.org>
Shouldn't this be 'Reported-by: "
Anyhow,
Release-Acked-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> > ---
> > tools/libxl/Makefile | 6 +++---
> > 1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/tools/libxl/Makefile b/tools/libxl/Makefile
> > index bd0db3b..e61048d 100644
> > --- a/tools/libxl/Makefile
> > +++ b/tools/libxl/Makefile
> > @@ -35,7 +35,7 @@ LDFLAGS += $(PTHREAD_LDFLAGS)
> > LIBXL_LIBS += $(PTHREAD_LIBS)
> > LIBXL_LIBS += $(LIBXL_LIBS-y)
> >
> > -LIBXLU_LIBS =
> > +LIBXLU_LIBS = libxenlight.so
> >
> > LIBXL_OBJS-y = osdeps.o libxl_paths.o libxl_bootloader.o flexarray.o
> > ifeq ($(LIBXL_BLKTAP),y)
> > @@ -213,8 +213,8 @@ libxlutil.so: libxlutil.so.$(XLUMAJOR)
> > libxlutil.so.$(XLUMAJOR): libxlutil.so.$(XLUMAJOR).$(XLUMINOR)
> > $(SYMLINK_SHLIB) $< $@
> >
> > -libxlutil.so.$(XLUMAJOR).$(XLUMINOR): $(LIBXLU_OBJS)
> > - $(CC) $(LDFLAGS) -Wl,$(SONAME_LDFLAG) -Wl,libxlutil.so.$(XLUMAJOR) $(SHLIB_LDFLAGS) -o $@ $^ $(LIBXLU_LIBS) $(APPEND_LDFLAGS)
> > +libxlutil.so.$(XLUMAJOR).$(XLUMINOR): $(LIBXLU_OBJS) libxenlight.so
> > + $(CC) $(LDFLAGS) -Wl,$(SONAME_LDFLAG) -Wl,libxlutil.so.$(XLUMAJOR) $(SHLIB_LDFLAGS) -o $@ $(LIBXLU_OBJS) $(LIBXLU_LIBS) $(APPEND_LDFLAGS)
> >
> > libxlutil.a: $(LIBXLU_OBJS)
> > $(AR) rcs libxlutil.a $^
>
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] tools: libxl: link libxlu against libxl.
2014-12-17 20:54 ` Konrad Rzeszutek Wilk
@ 2014-12-18 10:25 ` Ian Campbell
2014-12-18 10:47 ` Wei Liu
2015-01-06 11:44 ` Ian Campbell
1 sibling, 1 reply; 7+ messages in thread
From: Ian Campbell @ 2014-12-18 10:25 UTC (permalink / raw)
To: Konrad Rzeszutek Wilk; +Cc: Bastian Blank, Wei Liu, Ian Jackson, xen-devel
On Wed, 2014-12-17 at 15:54 -0500, Konrad Rzeszutek Wilk wrote:
> On Mon, Dec 15, 2014 at 10:02:31AM +0000, Ian Campbell wrote:
> > On Mon, 2014-08-04 at 10:58 +0100, Ian Campbell wrote:
> >
> > Ping again. This issue has resurfaced in the Debian packaging of the 4.5
> > rcs. I think we should fix this for 4.5, the risks are minimal.
>
> Ah, the patch did not have 'for-xen-4.5' in it :-P
I originally posted this patch at the start of August, when it wouldn't
have needed one, I forgot to add one now.
> >
> > > It uses libxl_defbool_set and must therefore be linked against the
> > > right library.
> > >
> > > Spotted by dpkg-shlibdeps and pointed out by Bastian Blank:
> > >
> > > dpkg-shlibdeps: warning: symbol libxl_defbool_set used by debian/libxen-4.4/usr/lib/libxlutil-4.4.so found in none of the libraries
> > >
> > > This required switching the make rule from $^ to an explicit
> > > LIBXLU_OBJS since the former now includes libxenlight.so.
> > >
> > > Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
> > > Cc: Bastian Blank <waldi@debian.org>
>
> Shouldn't this be 'Reported-by: "
Yes, I think it should.
> Anyhow,
>
> Release-Acked-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Thanks. This still needs an maintainer ack from someone other than me.
Adding Wei who became a maintainer since i originally posted the patch.
> > > ---
> > > tools/libxl/Makefile | 6 +++---
> > > 1 file changed, 3 insertions(+), 3 deletions(-)
> > >
> > > diff --git a/tools/libxl/Makefile b/tools/libxl/Makefile
> > > index bd0db3b..e61048d 100644
> > > --- a/tools/libxl/Makefile
> > > +++ b/tools/libxl/Makefile
> > > @@ -35,7 +35,7 @@ LDFLAGS += $(PTHREAD_LDFLAGS)
> > > LIBXL_LIBS += $(PTHREAD_LIBS)
> > > LIBXL_LIBS += $(LIBXL_LIBS-y)
> > >
> > > -LIBXLU_LIBS =
> > > +LIBXLU_LIBS = libxenlight.so
> > >
> > > LIBXL_OBJS-y = osdeps.o libxl_paths.o libxl_bootloader.o flexarray.o
> > > ifeq ($(LIBXL_BLKTAP),y)
> > > @@ -213,8 +213,8 @@ libxlutil.so: libxlutil.so.$(XLUMAJOR)
> > > libxlutil.so.$(XLUMAJOR): libxlutil.so.$(XLUMAJOR).$(XLUMINOR)
> > > $(SYMLINK_SHLIB) $< $@
> > >
> > > -libxlutil.so.$(XLUMAJOR).$(XLUMINOR): $(LIBXLU_OBJS)
> > > - $(CC) $(LDFLAGS) -Wl,$(SONAME_LDFLAG) -Wl,libxlutil.so.$(XLUMAJOR) $(SHLIB_LDFLAGS) -o $@ $^ $(LIBXLU_LIBS) $(APPEND_LDFLAGS)
> > > +libxlutil.so.$(XLUMAJOR).$(XLUMINOR): $(LIBXLU_OBJS) libxenlight.so
> > > + $(CC) $(LDFLAGS) -Wl,$(SONAME_LDFLAG) -Wl,libxlutil.so.$(XLUMAJOR) $(SHLIB_LDFLAGS) -o $@ $(LIBXLU_OBJS) $(LIBXLU_LIBS) $(APPEND_LDFLAGS)
> > >
> > > libxlutil.a: $(LIBXLU_OBJS)
> > > $(AR) rcs libxlutil.a $^
> >
> >
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] tools: libxl: link libxlu against libxl.
2014-12-18 10:25 ` Ian Campbell
@ 2014-12-18 10:47 ` Wei Liu
0 siblings, 0 replies; 7+ messages in thread
From: Wei Liu @ 2014-12-18 10:47 UTC (permalink / raw)
To: Ian Campbell; +Cc: Bastian Blank, Wei Liu, xen-devel, Ian Jackson
Acked-by: Wei Liu <wei.liu2@citrix.com>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] tools: libxl: link libxlu against libxl.
2014-12-17 20:54 ` Konrad Rzeszutek Wilk
2014-12-18 10:25 ` Ian Campbell
@ 2015-01-06 11:44 ` Ian Campbell
1 sibling, 0 replies; 7+ messages in thread
From: Ian Campbell @ 2015-01-06 11:44 UTC (permalink / raw)
To: Konrad Rzeszutek Wilk; +Cc: Bastian Blank, Ian Jackson, xen-devel
On Wed, 2014-12-17 at 15:54 -0500, Konrad Rzeszutek Wilk wrote:
> On Mon, Dec 15, 2014 at 10:02:31AM +0000, Ian Campbell wrote:
> > On Mon, 2014-08-04 at 10:58 +0100, Ian Campbell wrote:
> >
> > Ping again. This issue has resurfaced in the Debian packaging of the 4.5
> > rcs. I think we should fix this for 4.5, the risks are minimal.
>
> Ah, the patch did not have 'for-xen-4.5' in it :-P
>
> >
> > > It uses libxl_defbool_set and must therefore be linked against the
> > > right library.
> > >
> > > Spotted by dpkg-shlibdeps and pointed out by Bastian Blank:
> > >
> > > dpkg-shlibdeps: warning: symbol libxl_defbool_set used by debian/libxen-4.4/usr/lib/libxlutil-4.4.so found in none of the libraries
> > >
> > > This required switching the make rule from $^ to an explicit
> > > LIBXLU_OBJS since the former now includes libxenlight.so.
> > >
> > > Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
> > > Cc: Bastian Blank <waldi@debian.org>
>
> Shouldn't this be 'Reported-by: "
>
> Anyhow,
>
> Release-Acked-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Applied.
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2015-01-06 11:44 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-08-04 9:58 [PATCH] tools: libxl: link libxlu against libxl Ian Campbell
2014-09-04 13:44 ` Ian Campbell
2014-12-15 10:02 ` Ian Campbell
2014-12-17 20:54 ` Konrad Rzeszutek Wilk
2014-12-18 10:25 ` Ian Campbell
2014-12-18 10:47 ` Wei Liu
2015-01-06 11:44 ` Ian Campbell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).