* [PATCH] x86/time: don't omit newline in dump_softtsc()
@ 2016-12-12 8:08 Jan Beulich
2016-12-12 10:00 ` Andrew Cooper
0 siblings, 1 reply; 2+ messages in thread
From: Jan Beulich @ 2016-12-12 8:08 UTC (permalink / raw)
To: xen-devel; +Cc: Andrew Cooper, avscomputing
[-- Attachment #1: Type: text/plain, Size: 825 bytes --]
Reported-by: Anton Samsonov <devel@zxlab.ru>
Signed-off-by: Jan Beulich <jbeulich@suse.com>
--- a/xen/arch/x86/time.c
+++ b/xen/arch/x86/time.c
@@ -2145,12 +2145,11 @@ static void dump_softtsc(unsigned char k
if ( d->arch.incarnation )
printk(",inc=%"PRIu32, d->arch.incarnation);
#if !defined(NDEBUG) || defined(CONFIG_PERF_COUNTERS)
- if ( !(d->arch.vtsc_kerncount | d->arch.vtsc_usercount) )
- printk("\n");
- else
- printk(",vtsc count: %"PRIu64" kernel, %"PRIu64" user\n",
+ if ( d->arch.vtsc_kerncount | d->arch.vtsc_usercount )
+ printk(",vtsc count: %"PRIu64" kernel,%"PRIu64" user",
d->arch.vtsc_kerncount, d->arch.vtsc_usercount);
#endif
+ printk("\n");
domcnt++;
}
[-- Attachment #2: x86-dump_softtsc-newline.patch --]
[-- Type: text/plain, Size: 869 bytes --]
x86/time: don't omit newline in dump_softtsc()
Reported-by: Anton Samsonov <devel@zxlab.ru>
Signed-off-by: Jan Beulich <jbeulich@suse.com>
--- a/xen/arch/x86/time.c
+++ b/xen/arch/x86/time.c
@@ -2145,12 +2145,11 @@ static void dump_softtsc(unsigned char k
if ( d->arch.incarnation )
printk(",inc=%"PRIu32, d->arch.incarnation);
#if !defined(NDEBUG) || defined(CONFIG_PERF_COUNTERS)
- if ( !(d->arch.vtsc_kerncount | d->arch.vtsc_usercount) )
- printk("\n");
- else
- printk(",vtsc count: %"PRIu64" kernel, %"PRIu64" user\n",
+ if ( d->arch.vtsc_kerncount | d->arch.vtsc_usercount )
+ printk(",vtsc count: %"PRIu64" kernel,%"PRIu64" user",
d->arch.vtsc_kerncount, d->arch.vtsc_usercount);
#endif
+ printk("\n");
domcnt++;
}
[-- Attachment #3: Type: text/plain, Size: 127 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] x86/time: don't omit newline in dump_softtsc()
2016-12-12 8:08 [PATCH] x86/time: don't omit newline in dump_softtsc() Jan Beulich
@ 2016-12-12 10:00 ` Andrew Cooper
0 siblings, 0 replies; 2+ messages in thread
From: Andrew Cooper @ 2016-12-12 10:00 UTC (permalink / raw)
To: Jan Beulich, xen-devel; +Cc: avscomputing
On 12/12/16 08:08, Jan Beulich wrote:
> Reported-by: Anton Samsonov <devel@zxlab.ru>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-12-12 10:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-12-12 8:08 [PATCH] x86/time: don't omit newline in dump_softtsc() Jan Beulich
2016-12-12 10:00 ` Andrew Cooper
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).