From: Ian Campbell <ian.campbell@citrix.com>
To: xen-devel@lists.xensource.com
Cc: Ian Campbell <ian.campbell@citrix.com>
Subject: [PATCH 6 of 9] xl: do not try and auto re-connect console on reboot
Date: Mon, 26 Jul 2010 11:56:50 +0100 [thread overview]
Message-ID: <333254f8e11bc7bfa690.1280141810@localhost.localdomain> (raw)
In-Reply-To: <patchbomb.1280141804@localhost.localdomain>
# HG changeset patch
# User Ian Campbell <ian.campbell@citrix.com>
# Date 1280140563 -3600
# Node ID 333254f8e11bc7bfa6901fe5e5585abb25e31398
# Parent 85b50d34d7cc8a70c083c0acdc4c2e7ead675029
xl: do not try and auto re-connect console on reboot
It is not possible to run the console client if we are rebooting a
guest via the backgrounded xl process so we may as well turn off
console autoconnect after the first boot.
Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
diff -r 85b50d34d7cc -r 333254f8e11b tools/libxl/xl_cmdimpl.c
--- a/tools/libxl/xl_cmdimpl.c Mon Jul 26 11:36:03 2010 +0100
+++ b/tools/libxl/xl_cmdimpl.c Mon Jul 26 11:36:03 2010 +0100
@@ -1188,6 +1188,12 @@ start:
*/
dom_info->console_autoconnect = 0;
+ /*
+ * Do not attempt to reconnect if we come round again due to a
+ * guest reboot -- the stdin/out will be disconnected by then.
+ */
+ dom_info->console_autoconnect = 0;
+
ret = libxl_run_bootloader(&ctx, &b_info, num_disks > 0 ? &disks[0] : NULL, domid);
if (ret) {
fprintf(stderr, "failed to run bootloader: %d\n", ret);
next prev parent reply other threads:[~2010-07-26 10:56 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-26 10:56 [PATCH 0 of 9] xl: handle domain shutdown/reboot/crash in a user configurable way Ian Campbell
2010-07-26 10:56 ` [PATCH 1 of 9] libxl: Add LIBXL_EVENT namespace to enum libxl_event_type Ian Campbell
2010-07-26 10:56 ` [PATCH 2 of 9] libxl: return libxl_dominfo from libxl_event_get_domain_death_info Ian Campbell
2010-07-26 14:32 ` Stefano Stabellini
2010-07-26 14:38 ` Ian Campbell
2010-07-26 14:59 ` Stefano Stabellini
2010-07-26 15:26 ` Ian Jackson
2010-07-26 15:31 ` Ian Campbell
2010-07-26 15:36 ` Ian Jackson
2010-07-26 15:34 ` Stefano Stabellini
2010-07-26 15:41 ` Ian Jackson
2010-07-26 16:23 ` Stefano Stabellini
2010-07-26 16:38 ` Ian Jackson
2010-07-27 9:22 ` Ian Campbell
2010-07-27 9:53 ` Stefano Stabellini
2010-07-26 10:56 ` [PATCH 3 of 9] libxl: signal caller if domain already destroyed on domain death event Ian Campbell
2010-07-26 14:32 ` Stefano Stabellini
2010-07-26 14:41 ` Ian Campbell
2010-07-26 14:58 ` Stefano Stabellini
2010-07-26 15:02 ` Ian Campbell
2010-07-26 15:08 ` Stefano Stabellini
2010-07-26 10:56 ` [PATCH 4 of 9] libxl: should consider shutdown_reason for dying as well as shutdown domains Ian Campbell
2010-07-26 10:56 ` [PATCH 5 of 9] libxl: add libxl_domain_preserve Ian Campbell
2010-07-26 15:30 ` Ian Jackson
2010-07-26 15:56 ` Ian Campbell
2010-07-26 10:56 ` Ian Campbell [this message]
2010-07-26 10:56 ` [PATCH 7 of 9] xl: Add function to generate random uuid and use it Ian Campbell
2010-07-26 10:56 ` [PATCH 8 of 9] xl: Factor out domain death handling into a separate function Ian Campbell
2010-07-26 10:56 ` [PATCH 9 of 9] xl: support on_{poweroff, reboot, crash} domain configuration options Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=333254f8e11bc7bfa690.1280141810@localhost.localdomain \
--to=ian.campbell@citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).