From: Andrew Cooper <andrew.cooper3@citrix.com>
To: "Marek Marczykowski-Górecki" <marmarek@invisiblethingslab.com>,
"Wei Liu" <wei.liu2@citrix.com>
Cc: Elena Ufimtseva <elena.ufimtseva@oracle.com>,
xen-devel@lists.xenproject.org,
Ian Jackson <ian.jackson@eu.citrix.com>,
xen-devel@lists.xen.org
Subject: Re: [PATCH] tools/gdbsx: fix 'g' packet response for 64bit guests
Date: Tue, 31 Jul 2018 17:29:26 +0100 [thread overview]
Message-ID: <3336b030-347a-89f4-a27d-c48a5f680c02@citrix.com> (raw)
In-Reply-To: <20180731161007.GR1371@mail-itl>
On 31/07/18 17:10, Marek Marczykowski-Górecki wrote:
> On Tue, Jul 31, 2018 at 10:00:24AM +0100, Wei Liu wrote:
>> On Tue, Jul 31, 2018 at 04:30:42AM +0200, Marek Marczykowski-Górecki wrote:
>>> --- a/tools/debugger/gdbsx/gx/gx_local.c
>>> +++ b/tools/debugger/gdbsx/gx/gx_local.c
>>> @@ -45,8 +45,8 @@ prnt_32regs(struct xg_gdb_regs32 *r32p)
>>> static void
>>> prnt_64regs(struct xg_gdb_regs64 *r64p)
>>> {
>>> - printf("rip:"XGF64" rsp:"XGF64" flags:"XGF64"\n", r64p->rip, r64p->rsp,
>>> - r64p->rflags);
>>> + printf("rip:"XGF64" rsp:"XGF64" flags:%08x\n", r64p->rip, r64p->rsp,
>>> + r64p->eflags);
>> I think it would be better to introduce XGF32 and XGFM32 in the header.
> I was inspired by prnt_32regs function, which use explicit %08x. Should
> it be changed there too (to PRIx32)? Otherwise that would be
> inconsistent (and maybe warrant a totally separate cleanup).
Tbh, I'd stick with %08x because that's what we'd expect in the
hypervisor. If you'd like clean things up then please do, but it would
be rude to block this bugfix on cleanup.
~Andrew
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
prev parent reply other threads:[~2018-07-31 16:29 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-31 2:30 [PATCH] tools/gdbsx: fix 'g' packet response for 64bit guests Marek Marczykowski-Górecki
2018-07-31 8:01 ` Jan Beulich
2018-07-31 8:09 ` Andrew Cooper
2018-07-31 8:35 ` Jan Beulich
2018-07-31 16:04 ` Marek Marczykowski
2018-07-31 9:00 ` Wei Liu
2018-07-31 9:08 ` Andrew Cooper
2018-07-31 9:12 ` Wei Liu
2018-07-31 16:10 ` Marek Marczykowski-Górecki
2018-07-31 16:28 ` Wei Liu
2018-07-31 16:29 ` Andrew Cooper [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3336b030-347a-89f4-a27d-c48a5f680c02@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=elena.ufimtseva@oracle.com \
--cc=ian.jackson@eu.citrix.com \
--cc=marmarek@invisiblethingslab.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).