xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Jan Beulich <JBeulich@suse.com>,
	xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v3 4/5] x86: use MOV for PFN/PDX conversion when possible
Date: Fri, 17 Aug 2018 09:41:32 +0100	[thread overview]
Message-ID: <346f7e0e-a18a-9327-bfcd-decd30a4ee2d@citrix.com> (raw)
In-Reply-To: <5B7677DC02000078001DF38A@prv1-mh.provo.novell.com>

On 17/08/2018 08:23, Jan Beulich wrote:
> ... and (of course) also maddr / direct-map-offset ones.
>
> Most x86 systems don't actually require the use of PDX compression. Now
> that we have patching for the conversion code in place anyway, extend it
> to use simple MOV when possible. Introduce a new pseudo-CPU-feature to
> key the patching off of.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> ---
> The indentation of the alternative_io_2() uses below ends up wrong, but
> re-indenting here seems undesirable. I could either add a follow-up
> re-formatting patch, or simply slightly bodge the indentation in the
> earlier patches, for it to come out right here.

I've used the "bodge the indentation in the earlier patches" trick
before, and it is probably the cleanest approach.

Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

  reply	other threads:[~2018-08-17  8:42 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <5AA7E79302000078001B0FAB@prv1-mh.provo.novell.com>
     [not found] ` <5AA7D98302000000000F73C0@prv1-mh.provo.novell.com>
     [not found]   ` <5AA7D98302000078001CDC8C@prv1-mh.provo.novell.com>
     [not found]     ` <5AA7D98302000000000F8008@prv1-mh.provo.novell.com>
     [not found]       ` <5AA7D98302000078001DD5F0@prv1-mh.provo.novell.com>
2018-08-17  7:06         ` [PATCH v3 0/5] x86: improve PDX <-> PFN and alike translations Jan Beulich
2018-08-17  7:20           ` [PATCH v3 1/5] x86: remove page.h and processor.h inclusion from asm_defns.h Jan Beulich
2018-08-17  8:39             ` Andrew Cooper
2018-08-17  7:21           ` [PATCH v3 2/5] x86: use PDEP/PEXT for maddr/direct-map-offset conversion when available Jan Beulich
2018-08-17  8:59             ` Andrew Cooper
2018-08-17  9:38               ` Jan Beulich
2018-09-07 16:17                 ` Andrew Cooper
2018-09-10 10:00                   ` Jan Beulich
2018-09-25 17:15                     ` Andrew Cooper
2018-09-26  8:48                       ` Jan Beulich
2018-09-27  6:44                       ` Jan Beulich
2018-08-17  7:22           ` [PATCH v3 3/5] x86: use PDEP/PEXT for PFN/PDX " Jan Beulich
2018-08-17  7:23           ` [PATCH v3 4/5] x86: use MOV for PFN/PDX conversion when possible Jan Beulich
2018-08-17  8:41             ` Andrew Cooper [this message]
2018-08-17  7:24           ` [PATCH v3 5/5] x86: use PDEP for PTE flags insertion when available Jan Beulich
2018-08-18  1:08             ` Rich Persaud
2018-08-20  7:25               ` Jan Beulich
2018-09-18 12:34         ` [PATCH v4 0/4] x86: improve PDX <-> PFN and alike translations Jan Beulich
2018-09-18 12:36           ` [PATCH v4 1/4] x86: use PDEP/PEXT for maddr/direct-map-offset conversion when available Jan Beulich
2018-10-31 17:03             ` Wei Liu
2018-11-02  8:49               ` Jan Beulich
2018-09-18 12:36           ` [PATCH v4 2/4] x86: use PDEP/PEXT for PFN/PDX " Jan Beulich
2018-09-18 12:37           ` [PATCH v4 3/4] x86: use MOV for PFN/PDX conversion when possible Jan Beulich
2018-09-18 12:37           ` [PATCH v4 4/4] x86: use PDEP for PTE flags insertion when available Jan Beulich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=346f7e0e-a18a-9327-bfcd-decd30a4ee2d@citrix.com \
    --to=andrew.cooper3@citrix.com \
    --cc=JBeulich@suse.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).