From: Olaf Hering <olaf@aepfle.de>
To: xen-devel@lists.xensource.com
Subject: [PATCH] tools/configure: correct enable/disable-feature option
Date: Wed, 14 Mar 2012 19:13:20 +0100 [thread overview]
Message-ID: <36690251f6bfe153f390.1331748800@probook.site> (raw)
# HG changeset patch
# User Olaf Hering <olaf@aepfle.de>
# Date 1331748796 -3600
# Node ID 36690251f6bfe153f390ef200ff286e64f2582d7
# Parent cd473b1fb313bb107cf1c32ce224f265a5de097e
tools/configure: correct enable/disable-feature option
If --disable-feature is not specified then feature should default to n.
But with the current code disable with set feature to y, and enable will
set feature to n. Reverse the logic in the two .m4 files to use correct
default values.
The failure currently is that default := is y while it should be n.
Signed-off-by: Olaf Hering <olaf@aepfle.de>
diff -r cd473b1fb313 -r 36690251f6bf tools/m4/disable_feature.m4
--- a/tools/m4/disable_feature.m4
+++ b/tools/m4/disable_feature.m4
@@ -7,7 +7,7 @@ AS_IF([test "x$enable_$1" = "xno"], [
], [test "x$enable_$1" = "xyes"], [
ax_cv_$1="y"
], [test -z $ax_cv_$1], [
- ax_cv_$1="y"
+ ax_cv_$1="n"
])
$1=$ax_cv_$1
AC_SUBST($1)])
diff -r cd473b1fb313 -r 36690251f6bf tools/m4/enable_feature.m4
--- a/tools/m4/enable_feature.m4
+++ b/tools/m4/enable_feature.m4
@@ -7,7 +7,7 @@ AS_IF([test "x$enable_$1" = "xyes"], [
], [test "x$enable_$1" = "xno"], [
ax_cv_$1="n"
], [test -z $ax_cv_$1], [
- ax_cv_$1="n"
+ ax_cv_$1="y"
])
$1=$ax_cv_$1
AC_SUBST($1)])
next reply other threads:[~2012-03-14 18:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-14 18:13 Olaf Hering [this message]
2012-03-14 19:16 ` [PATCH] tools/configure: correct enable/disable-feature option Ian Campbell
2012-03-14 19:33 ` Olaf Hering
2012-03-14 19:51 ` Ian Campbell
2012-03-14 20:01 ` Olaf Hering
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=36690251f6bfe153f390.1331748800@probook.site \
--to=olaf@aepfle.de \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).