xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: annie li <annie.li@oracle.com>
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>
Cc: wei.liu2@citrix.com, andrew.cooper3@citrix.com,
	ian.jackson@eu.citrix.com, adnan.misherfi@oracle.com,
	xen-devel@lists.xen.org, jbeulich@suse.com, roger.pau@citrix.com
Subject: Re: [PATCH 04/10] acpi: Power and Sleep ACPI buttons are not emulated
Date: Mon, 7 Nov 2016 12:24:59 -0500	[thread overview]
Message-ID: <37cffff7-fae3-dd37-2f3f-6d77bd90162c@oracle.com> (raw)
In-Reply-To: <20161107153849.GL21570@char.us.oracle.com>



On 11/7/2016 10:38 AM, Konrad Rzeszutek Wilk wrote:
> On Sun, Nov 06, 2016 at 04:42:37PM -0500, Boris Ostrovsky wrote:
>> .. for PVH guests. However, since emulating them for HVM guests
>> also doesn't seem useful we can have FADT disable those buttons
>> for both types of guests.
> Wait, we need S3 suspend for HVM guests (think Windows without PV drivers)!
> And I this is how we "inject" the event to the guest.
>
> CC-ing Annie and Adnan who I believe had to do something like this
> in old version of OVS, maybe they can recall more details.
Our winpv supports S4(hibernation) which will be tested by WHQL, and 
S3(Sleep) is optional(no real process for it yet).

Thanks
Annie
>> Signed-off-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
>> ---
>>   tools/libacpi/static_tables.c | 3 ++-
>>   1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/tools/libacpi/static_tables.c b/tools/libacpi/static_tables.c
>> index 413abcc..ebe8ffe 100644
>> --- a/tools/libacpi/static_tables.c
>> +++ b/tools/libacpi/static_tables.c
>> @@ -61,7 +61,8 @@ struct acpi_20_fadt Fadt = {
>>       .flags = (ACPI_PROC_C1 |
>>                 ACPI_WBINVD |
>>                 ACPI_FIX_RTC | ACPI_TMR_VAL_EXT |
>> -              ACPI_USE_PLATFORM_CLOCK),
>> +              ACPI_USE_PLATFORM_CLOCK |
>> +              ACPI_PWR_BUTTON | ACPI_SLP_BUTTON),
>>   
>>       .reset_reg = {
>>           .address_space_id    = ACPI_SYSTEM_IO,
>> -- 
>> 2.7.4
>>
>>
>> _______________________________________________
>> Xen-devel mailing list
>> Xen-devel@lists.xen.org
>> https://lists.xen.org/xen-devel
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> https://lists.xen.org/xen-devel


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

  parent reply	other threads:[~2016-11-07 17:24 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-06 21:42 [PATCH 00/10] PVH VCPU hotplug support Boris Ostrovsky
2016-11-06 21:42 ` [PATCH 01/10] x86/domctl: Add XEN_DOMCTL_set_avail_vcpus Boris Ostrovsky
2016-11-07 15:30   ` Konrad Rzeszutek Wilk
2016-11-07 18:24     ` Boris Ostrovsky
2016-11-08 19:07   ` Daniel De Graaf
2016-11-06 21:42 ` [PATCH 02/10] acpi: Define ACPI IO registers for PVH guests Boris Ostrovsky
2016-11-06 21:42 ` [PATCH 03/10] pvh: Set online VCPU map to avail_vcpus Boris Ostrovsky
2016-11-07 15:36   ` Konrad Rzeszutek Wilk
2016-11-07 15:52     ` Boris Ostrovsky
2016-11-06 21:42 ` [PATCH 04/10] acpi: Power and Sleep ACPI buttons are not emulated Boris Ostrovsky
2016-11-07 15:38   ` Konrad Rzeszutek Wilk
2016-11-07 15:54     ` Boris Ostrovsky
2016-11-07 17:24     ` annie li [this message]
2016-11-06 21:42 ` [PATCH 05/10] acpi: Make pmtimer optional in FADT Boris Ostrovsky
2016-11-07 15:39   ` Konrad Rzeszutek Wilk
2016-11-06 21:42 ` [PATCH 06/10] acpi: PVH guests need _E02 method Boris Ostrovsky
2016-11-07 15:45   ` Konrad Rzeszutek Wilk
2016-11-07 16:08     ` Boris Ostrovsky
2016-11-07 16:08       ` Konrad Rzeszutek Wilk
2016-11-06 21:42 ` [PATCH 07/10] pvh/ioreq: Install handlers for ACPI-related PVH IO accesses Boris Ostrovsky
2016-11-07  9:39   ` Paul Durrant
2016-11-07 14:01     ` Boris Ostrovsky
2016-11-07 14:00       ` Paul Durrant
2016-11-06 21:42 ` [PATCH 08/10] pvh/acpi: Handle ACPI accesses for PVH guests Boris Ostrovsky
2016-11-07  9:51   ` Paul Durrant
2016-11-08 16:14     ` Boris Ostrovsky
2016-11-07 15:55   ` Konrad Rzeszutek Wilk
2016-11-07 16:20     ` Boris Ostrovsky
2016-11-07 16:47     ` Jan Beulich
2016-11-06 21:42 ` [PATCH 09/10] events/x86: Define SCI virtual interrupt Boris Ostrovsky
2016-11-07 16:05   ` Konrad Rzeszutek Wilk
2016-11-07 16:29     ` Boris Ostrovsky
2016-11-06 21:42 ` [PATCH 10/10] pvh: Send an SCI on VCPU hotplug event Boris Ostrovsky
2016-11-07 11:41 ` [PATCH 00/10] PVH VCPU hotplug support Andrew Cooper
2016-11-07 14:19   ` Boris Ostrovsky
2016-11-07 14:46     ` Andrew Cooper
2016-11-07 15:30       ` Boris Ostrovsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=37cffff7-fae3-dd37-2f3f-6d77bd90162c@oracle.com \
    --to=annie.li@oracle.com \
    --cc=adnan.misherfi@oracle.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=boris.ostrovsky@oracle.com \
    --cc=ian.jackson@eu.citrix.com \
    --cc=jbeulich@suse.com \
    --cc=konrad.wilk@oracle.com \
    --cc=roger.pau@citrix.com \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).