From: George Dunlap <george.dunlap@eu.citrix.com>
To: xen-devel@lists.xensource.com
Cc: george.dunlap@eu.citrix.com
Subject: [PATCH 3 of 7] xenalyze: Don't warn about switching paging levels unless verbosity>=6
Date: Wed, 10 Oct 2012 12:17:31 +0100 [thread overview]
Message-ID: <3aad48bd6ca3213c598d.1349867851@elijah> (raw)
In-Reply-To: <patchbomb.1349867848@elijah>
# HG changeset patch
# User George Dunlap <george.dunlap@eu.citrix.com>
# Date 1349261732 -3600
# Node ID 3aad48bd6ca3213c598d16c307ba531dc45d6240
# Parent 4ea8fb7197ff3fad82b224a65cdfbe86db66d6ab
xenalyze: Don't warn about switching paging levels unless verbosity>=6
During boot, the guest paging levels changes back and forth frequently,
leading to spam when your'e doing the analysis. Don't print these messages
escept at verbosity level 6 (the default is 5).
Signed-off-by: George Dunlap <george.dunlap@eu.citrix.com>
diff --git a/xenalyze.c b/xenalyze.c
--- a/xenalyze.c
+++ b/xenalyze.c
@@ -5158,8 +5158,9 @@ void hvm_vmexit_process(struct record_in
if(ri->event == TRC_HVM_VMEXIT64) {
if(v->guest_paging_levels != 4)
{
- fprintf(warn, "%s: VMEXIT64, but guest_paging_levels %d. Switching to 4.\n",
- __func__, v->guest_paging_levels);
+ if ( verbosity >= 6 )
+ fprintf(warn, "%s: VMEXIT64, but guest_paging_levels %d. Switching to 4.\n",
+ __func__, v->guest_paging_levels);
v->guest_paging_levels = 4;
}
if(!is_valid_addr64(r->x64.rip))
@@ -5171,10 +5172,14 @@ void hvm_vmexit_process(struct record_in
if(v->guest_paging_levels == 4)
{
int new_paging_levels = opt.default_guest_paging_levels;
+
if(new_paging_levels == 4)
new_paging_levels = 2; /* Wild guess */
- fprintf(warn, "%s: VMEXIT, but guest_paging_levels %d. Switching to %d(default).\n",
- __func__, v->guest_paging_levels, new_paging_levels);
+
+ if ( verbosity >= 6 )
+ fprintf(warn, "%s: VMEXIT, but guest_paging_levels %d. Switching to %d(default).\n",
+ __func__, v->guest_paging_levels, new_paging_levels);
+
v->guest_paging_levels = new_paging_levels;
}
h->rip = r->x32.eip;
next prev parent reply other threads:[~2012-10-10 11:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-10 11:17 [PATCH 0 of 7] Miscellaneous updates George Dunlap
2012-10-10 11:17 ` [PATCH 1 of 7] xenalyze: Add HVM_EVENT_VLAPIC George Dunlap
2012-10-10 11:17 ` [PATCH 2 of 7] xenalyze: Process NPFs as generic for summary purposes George Dunlap
2012-10-10 11:17 ` George Dunlap [this message]
2012-10-10 11:17 ` [PATCH 4 of 7] xenalyze: Make the warnigns in hvm_generic_postprocess more informative George Dunlap
2012-10-10 11:17 ` [PATCH 5 of 7] xenalzye: Also strip write bit when processing a generic event George Dunlap
2012-10-10 11:17 ` [PATCH 6 of 7] xenalyze: Handle 64-bit MMIO George Dunlap
2012-10-10 11:17 ` [PATCH 7 of 7] xenalyze: Analyze populate-on-demand reclamation patterns George Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3aad48bd6ca3213c598d.1349867851@elijah \
--to=george.dunlap@eu.citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).