From: Julien Grall <julien.grall@arm.com>
To: vijay.kilari@gmail.com, xen-devel@lists.xen.org
Cc: sstabellini@kernel.org, wei.liu2@citrix.com,
George.Dunlap@eu.citrix.com, andrew.cooper3@citrix.com,
ian.jackson@eu.citrix.com, tim@xen.org, jbeulich@suse.com,
Vijaya Kumar K <Vijaya.Kumar@cavium.com>
Subject: Re: [PATCH v3] boot allocator: Use arch helper for virt_to_mfn on DIRECTMAP
Date: Mon, 27 Mar 2017 14:09:55 +0100 [thread overview]
Message-ID: <3c06ed42-281e-0e38-c1d8-66a6e65a77ed@arm.com> (raw)
In-Reply-To: <1490598622-2464-1-git-send-email-vijay.kilari@gmail.com>
Hello Vijay,
I agree with Jan's comments.
On 27/03/17 08:10, vijay.kilari@gmail.com wrote:
> diff --git a/xen/include/asm-arm/mm.h b/xen/include/asm-arm/mm.h
[...]
> diff --git a/xen/include/asm-x86/page.h b/xen/include/asm-x86/page.h
I am not sure to understand why the helper is added in mm.h for ARM but
page.h for x86.
The purpose of architecture headers is to always include the same header
name and retrieve the correct implementation without adding #ifdef in
the common code.
In this case, I think it would make sense to always use mm.h.
Regards,
--
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
prev parent reply other threads:[~2017-03-27 13:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-27 7:10 [PATCH v3] boot allocator: Use arch helper for virt_to_mfn on DIRECTMAP vijay.kilari
2017-03-27 7:20 ` Jan Beulich
2017-03-27 7:30 ` Vijay Kilari
2017-03-27 13:09 ` Julien Grall [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3c06ed42-281e-0e38-c1d8-66a6e65a77ed@arm.com \
--to=julien.grall@arm.com \
--cc=George.Dunlap@eu.citrix.com \
--cc=Vijaya.Kumar@cavium.com \
--cc=andrew.cooper3@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=jbeulich@suse.com \
--cc=sstabellini@kernel.org \
--cc=tim@xen.org \
--cc=vijay.kilari@gmail.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).