* [PATCH] xen/arm: Fix macro for ARM Jazelle CPU feature identification
@ 2016-12-06 14:16 Artem Mygaiev
2016-12-06 16:19 ` Julien Grall
0 siblings, 1 reply; 3+ messages in thread
From: Artem Mygaiev @ 2016-12-06 14:16 UTC (permalink / raw)
To: xen-devel@lists.xenproject.org; +Cc: Julien Grall, Stefano Stabellini
Fix macro for ARM Jazelle CPU feature identification: value of 0 indicates
that CPU does not support ARM Jazelle (PFR0[11:8])
Coverity-ID: 1381849
Signed-off-by: Artem Mygaiev <artem_mygaiev@epam.com>
---
xen/include/asm-arm/cpufeature.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/xen/include/asm-arm/cpufeature.h b/xen/include/asm-arm/cpufeature.h
index af60fe3..c0a25ae 100644
--- a/xen/include/asm-arm/cpufeature.h
+++ b/xen/include/asm-arm/cpufeature.h
@@ -24,7 +24,7 @@
#define cpu_has_arm (boot_cpu_feature32(arm) == 1)
#define cpu_has_thumb (boot_cpu_feature32(thumb) >= 1)
#define cpu_has_thumb2 (boot_cpu_feature32(thumb) >= 3)
-#define cpu_has_jazelle (boot_cpu_feature32(jazelle) >= 0)
+#define cpu_has_jazelle (boot_cpu_feature32(jazelle) > 0)
#define cpu_has_thumbee (boot_cpu_feature32(thumbee) == 1)
#define cpu_has_aarch32 (cpu_has_arm || cpu_has_thumb)
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] xen/arm: Fix macro for ARM Jazelle CPU feature identification
2016-12-06 14:16 [PATCH] xen/arm: Fix macro for ARM Jazelle CPU feature identification Artem Mygaiev
@ 2016-12-06 16:19 ` Julien Grall
2016-12-06 18:42 ` Stefano Stabellini
0 siblings, 1 reply; 3+ messages in thread
From: Julien Grall @ 2016-12-06 16:19 UTC (permalink / raw)
To: Artem Mygaiev, xen-devel@lists.xenproject.org; +Cc: Stefano Stabellini
Hi Artem,
On 06/12/16 14:16, Artem Mygaiev wrote:
> Fix macro for ARM Jazelle CPU feature identification: value of 0 indicates
> that CPU does not support ARM Jazelle (PFR0[11:8])
NIT: The register is called ID_PFR0 not PFR0.
>
> Coverity-ID: 1381849
>
> Signed-off-by: Artem Mygaiev <artem_mygaiev@epam.com>
With that change:
Reviewed-by: Julien Grall <julien.grall@arm.com>
>
> ---
> xen/include/asm-arm/cpufeature.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/xen/include/asm-arm/cpufeature.h b/xen/include/asm-arm/cpufeature.h
> index af60fe3..c0a25ae 100644
> --- a/xen/include/asm-arm/cpufeature.h
> +++ b/xen/include/asm-arm/cpufeature.h
> @@ -24,7 +24,7 @@
> #define cpu_has_arm (boot_cpu_feature32(arm) == 1)
> #define cpu_has_thumb (boot_cpu_feature32(thumb) >= 1)
> #define cpu_has_thumb2 (boot_cpu_feature32(thumb) >= 3)
> -#define cpu_has_jazelle (boot_cpu_feature32(jazelle) >= 0)
> +#define cpu_has_jazelle (boot_cpu_feature32(jazelle) > 0)
> #define cpu_has_thumbee (boot_cpu_feature32(thumbee) == 1)
> #define cpu_has_aarch32 (cpu_has_arm || cpu_has_thumb)
>
>
--
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] xen/arm: Fix macro for ARM Jazelle CPU feature identification
2016-12-06 16:19 ` Julien Grall
@ 2016-12-06 18:42 ` Stefano Stabellini
0 siblings, 0 replies; 3+ messages in thread
From: Stefano Stabellini @ 2016-12-06 18:42 UTC (permalink / raw)
To: Julien Grall
Cc: Artem Mygaiev, xen-devel@lists.xenproject.org, Stefano Stabellini
On Tue, 6 Dec 2016, Julien Grall wrote:
> Hi Artem,
>
> On 06/12/16 14:16, Artem Mygaiev wrote:
> > Fix macro for ARM Jazelle CPU feature identification: value of 0 indicates
> > that CPU does not support ARM Jazelle (PFR0[11:8])
>
> NIT: The register is called ID_PFR0 not PFR0.
>
> >
> > Coverity-ID: 1381849
> >
> > Signed-off-by: Artem Mygaiev <artem_mygaiev@epam.com>
>
> With that change:
>
> Reviewed-by: Julien Grall <julien.grall@arm.com>
Fixed, and applied
> >
> > ---
> > xen/include/asm-arm/cpufeature.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/xen/include/asm-arm/cpufeature.h
> > b/xen/include/asm-arm/cpufeature.h
> > index af60fe3..c0a25ae 100644
> > --- a/xen/include/asm-arm/cpufeature.h
> > +++ b/xen/include/asm-arm/cpufeature.h
> > @@ -24,7 +24,7 @@
> > #define cpu_has_arm (boot_cpu_feature32(arm) == 1)
> > #define cpu_has_thumb (boot_cpu_feature32(thumb) >= 1)
> > #define cpu_has_thumb2 (boot_cpu_feature32(thumb) >= 3)
> > -#define cpu_has_jazelle (boot_cpu_feature32(jazelle) >= 0)
> > +#define cpu_has_jazelle (boot_cpu_feature32(jazelle) > 0)
> > #define cpu_has_thumbee (boot_cpu_feature32(thumbee) == 1)
> > #define cpu_has_aarch32 (cpu_has_arm || cpu_has_thumb)
> >
> >
>
> --
> Julien Grall
>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-12-06 18:42 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-12-06 14:16 [PATCH] xen/arm: Fix macro for ARM Jazelle CPU feature identification Artem Mygaiev
2016-12-06 16:19 ` Julien Grall
2016-12-06 18:42 ` Stefano Stabellini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).