From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
To: Wei Liu <wei.liu2@citrix.com>
Cc: tim@xen.org, sstabellini@kernel.org, George.Dunlap@eu.citrix.com,
andrew.cooper3@citrix.com, ian.jackson@eu.citrix.com,
xen-devel@lists.xen.org, jbeulich@suse.com
Subject: Re: [PATCH 1/4] mm: Initialize lowmem virq when boot-time scrubbing is disabled
Date: Tue, 29 Aug 2017 09:12:43 -0400 [thread overview]
Message-ID: <3f3e5faa-1a53-5ea8-3e5e-40a0371a3776@oracle.com> (raw)
In-Reply-To: <20170829115143.nf46ueb4exixkkow@citrix.com>
On 08/29/2017 07:51 AM, Wei Liu wrote:
> On Mon, Aug 28, 2017 at 04:40:26PM -0400, Boris Ostrovsky wrote:
>> scrub_heap_pages() does early return if boot-time scrubbing is
>> disabled, neglecting to initialize lowmem VIRQ.
>>
>> Signed-off-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
> Seems more appropriate to lift the call to setup_low_mem_virq to the
> caller of scrub_heap_pages.
setup_low_mem_virq() is only useful in page_alloc.c so I'd rather keep
it static there.
What I could do is create something like
void heap_init_late(void)
{
setup_low_mem_virq();
if ( opt_bootscrub )
scrub_heap_pages();
}
-boris
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2017-08-29 13:12 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-28 20:40 [PATCH 0/4] Scrubbing updates Boris Ostrovsky
2017-08-28 20:40 ` [PATCH 1/4] mm: Initialize lowmem virq when boot-time scrubbing is disabled Boris Ostrovsky
2017-08-29 11:51 ` Wei Liu
2017-08-29 13:12 ` Boris Ostrovsky [this message]
2017-08-29 13:20 ` Jan Beulich
2017-08-29 13:19 ` Jan Beulich
2017-08-28 20:40 ` [PATCH 2/4] mm: Don't poison a page if boot-time scrubbing is off Boris Ostrovsky
2017-08-29 11:52 ` Wei Liu
2017-08-28 20:40 ` [PATCH 3/4] mm: Don't request scrubbing until dom0 is running Boris Ostrovsky
2017-08-29 11:56 ` Wei Liu
2017-08-29 13:22 ` Jan Beulich
2017-08-29 13:27 ` Boris Ostrovsky
2017-08-29 13:34 ` Jan Beulich
2017-08-29 14:20 ` Boris Ostrovsky
2017-08-29 14:25 ` Jan Beulich
2017-08-29 13:26 ` Jan Beulich
2017-08-29 13:31 ` Wei Liu
2017-08-28 20:40 ` [PATCH 4/4] mm: Don't hold heap lock in alloc_heap_pages() longer than necessary Boris Ostrovsky
2017-08-29 12:16 ` Wei Liu
2017-08-29 13:33 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3f3e5faa-1a53-5ea8-3e5e-40a0371a3776@oracle.com \
--to=boris.ostrovsky@oracle.com \
--cc=George.Dunlap@eu.citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=jbeulich@suse.com \
--cc=sstabellini@kernel.org \
--cc=tim@xen.org \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).