From: Paul Durrant <Paul.Durrant@citrix.com>
To: 'Jan Beulich' <JBeulich@suse.com>
Cc: Andrew Cooper <Andrew.Cooper3@citrix.com>,
Wei Liu <wei.liu2@citrix.com>,
xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v2 6/9] viridian: separate time related enlightenment implementations...
Date: Mon, 5 Nov 2018 13:26:36 +0000 [thread overview]
Message-ID: <3f74ff787b5443e39f1472f3a839f646@AMSPEX02CL03.citrite.net> (raw)
In-Reply-To: <5BE03E0902000078001F8001@prv1-mh.provo.novell.com>
> -----Original Message-----
> From: Jan Beulich [mailto:JBeulich@suse.com]
> Sent: 05 November 2018 12:57
> To: Paul Durrant <Paul.Durrant@citrix.com>
> Cc: Andrew Cooper <Andrew.Cooper3@citrix.com>; Wei Liu
> <wei.liu2@citrix.com>; xen-devel <xen-devel@lists.xenproject.org>
> Subject: Re: [PATCH v2 6/9] viridian: separate time related enlightenment
> implementations...
>
> >>> On 31.10.18 at 13:43, <paul.durrant@citrix.com> wrote:
> > --- /dev/null
> > +++ b/xen/arch/x86/hvm/viridian/time.c
> > @@ -0,0 +1,245 @@
> >
> +/************************************************************************
> **
> > *
> > + * time.c
> > + *
> > + * An implementation of some time related Viridian enlightenments.
> > + * See Microsoft's Hypervisor Top Level Functional Specification.
> > + * for more information.
> > + */
> > +
> > +#include <xen/domain_page.h>
> > +#include <xen/hypercall.h>
> > +#include <xen/sched.h>
> > +#include <xen/version.h>
> > +
> > +#include <asm/apic.h>
> > +#include <asm/hvm/support.h>
> > +
> > +typedef struct _HV_REFERENCE_TSC_PAGE
> > +{
> > + uint32_t TscSequence;
> > + uint32_t Reserved1;
> > + uint64_t TscScale;
> > + int64_t TscOffset;
> > + uint64_t Reserved2[509];
> > +} HV_REFERENCE_TSC_PAGE, *PHV_REFERENCE_TSC_PAGE;
>
> And you want to continue to have it all upper case, despite us normally
> using such identifiers for #define-s only?
>
It's a definition lifted from the spec. so it's usual Microsoft style... i.e. upper case types and camel-case names. I didn't define UINT32, INT64 and UINT64 types - as used by the spec - but I could do so if you'd prefer the consistency.
> Apart from that same remark regarding the placement of the function
> declarations as for the previous patch.
>
I assume you mean in the proposed new header, which is fine.
Paul
> Jan
>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2018-11-05 13:27 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-31 12:43 [PATCH v2 0/9] viridian cleanup Paul Durrant
2018-10-31 12:43 ` [PATCH v2 1/9] viridian: move the code into its own sub-directory Paul Durrant
2018-10-31 12:43 ` [PATCH v2 2/9] viridian: remove MSR perf counters Paul Durrant
2018-10-31 12:43 ` [PATCH v2 3/9] viridian: remove comments referencing section number in the spec Paul Durrant
2018-10-31 12:43 ` [PATCH v2 4/9] viridian: remove duplicate union types Paul Durrant
2018-10-31 12:43 ` [PATCH v2 5/9] viridian: separate interrupt related enlightenment implementations Paul Durrant
2018-10-31 15:40 ` Wei Liu
2018-11-05 12:51 ` Jan Beulich
2018-11-05 13:22 ` Paul Durrant
2018-10-31 12:43 ` [PATCH v2 6/9] viridian: separate time " Paul Durrant
2018-10-31 15:43 ` Wei Liu
2018-11-05 12:56 ` Jan Beulich
2018-11-05 13:26 ` Paul Durrant [this message]
2018-11-05 13:36 ` Jan Beulich
2018-11-05 13:54 ` Paul Durrant
2018-11-05 14:56 ` Jan Beulich
2018-10-31 12:43 ` [PATCH v2 7/9] viridian: define type for the 'virtual VP assist page' Paul Durrant
2018-10-31 15:45 ` Wei Liu
2018-11-05 12:59 ` Jan Beulich
2018-11-05 13:19 ` Paul Durrant
2018-10-31 12:43 ` [PATCH v2 8/9] tools/misc: fix hard tabs in xen-hvmctx.c Paul Durrant
2018-10-31 14:00 ` Wei Liu
2018-10-31 12:43 ` [PATCH v2 9/9] viridian: introduce struct viridian_page Paul Durrant
2018-10-31 15:50 ` Wei Liu
2018-11-05 13:05 ` Jan Beulich
2018-11-05 13:18 ` Paul Durrant
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3f74ff787b5443e39f1472f3a839f646@AMSPEX02CL03.citrite.net \
--to=paul.durrant@citrix.com \
--cc=Andrew.Cooper3@citrix.com \
--cc=JBeulich@suse.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).