From: Dario Faggioli <dfaggioli@suse.com>
To: Roger Pau Monne <roger.pau@citrix.com>, xen-devel@lists.xenproject.org
Cc: Kevin Tian <kevin.tian@intel.com>,
Stefano Stabellini <sstabellini@kernel.org>,
Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>,
Julien Grall <julien.grall@arm.com>,
Jan Beulich <jbeulich@suse.com>,
Brian Woods <brian.woods@amd.com>
Subject: Re: [PATCH v2] iommu: setup inclusive mappings before enabling iommu
Date: Fri, 14 Sep 2018 18:35:45 +0200 [thread overview]
Message-ID: <3f7a1365869f97de24b4f46f0eeebde5b3e4922d.camel@suse.com> (raw)
In-Reply-To: <20180914135843.24899-1-roger.pau@citrix.com>
[-- Attachment #1.1: Type: text/plain, Size: 1416 bytes --]
On Fri, 2018-09-14 at 15:58 +0200, Roger Pau Monne wrote:
> Or else it can lead to freezes when enabling the iommu on certain
> Intel hardware:
>
> [...]
> (XEN) ELF: addresses:
> (XEN) virt_base = 0xffffffff80000000
> (XEN) elf_paddr_offset = 0x0
> (XEN) virt_offset = 0xffffffff80000000
> (XEN) virt_kstart = 0xffffffff81000000
> (XEN) virt_kend = 0xffffffff82953000
> (XEN) virt_entry = 0xffffffff8274e180
> (XEN) p2m_base = 0x8000000000
> (XEN) Xen kernel: 64-bit, lsb, compat32
> (XEN) Dom0 kernel: 64-bit, PAE, lsb, paddr 0x1000000 -> 0x295300
> <freeze>
>
> This restores the behavior before commit 66a9274cc3435 that changed
> the order and enabled the iommu without having the inclusive mappings
> setup.
>
> Note that on AMD hardware the order is also changed to add inclusive
> mappings before adding any devices.
>
> Reported-by: Dario Faggioli <dfaggioli@suse.com>
> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
>
I tested this too (sorry it took a bit more) and, like v1, it works.
Tested-by: Dario Faggioli <dfaggioli@suse.com>
Thanks,
Dario
--
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Software Engineer @ SUSE https://www.suse.com/
[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 157 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2018-09-14 16:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-14 13:58 [PATCH v2] iommu: setup inclusive mappings before enabling iommu Roger Pau Monne
2018-09-14 16:35 ` Dario Faggioli [this message]
2018-09-17 12:49 ` Jan Beulich
2018-09-17 13:22 ` Roger Pau Monné
2018-09-18 13:00 ` Ping: " Jan Beulich
2018-09-19 5:32 ` Tian, Kevin
2018-09-20 16:02 ` Julien Grall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3f7a1365869f97de24b4f46f0eeebde5b3e4922d.camel@suse.com \
--to=dfaggioli@suse.com \
--cc=brian.woods@amd.com \
--cc=jbeulich@suse.com \
--cc=julien.grall@arm.com \
--cc=kevin.tian@intel.com \
--cc=roger.pau@citrix.com \
--cc=sstabellini@kernel.org \
--cc=suravee.suthikulpanit@amd.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).