From: Julien Grall <julien.grall@arm.com>
To: Manish Jaggi <mjaggi@caviumnetworks.com>,
Sameer Goel <sameer.goel@linaro.org>,
xen-devel@lists.xenproject.org
Cc: sstabellini@kernel.org, shankerd@codeaurora.org, roger.pau@citrix.com
Subject: Re: [v2 4/6] xen/iommu: smmu-v3: Add Xen specific code to enable the ported driver
Date: Fri, 25 May 2018 09:45:42 +0100 [thread overview]
Message-ID: <3ff48bc8-8d38-db9e-8833-320a6acbcb17@arm.com> (raw)
In-Reply-To: <9900a2ad-65d4-357f-b54d-01ba76476d1a@caviumnetworks.com>
Hi,
On 25/05/18 05:41, Manish Jaggi wrote:
>
>
> On 05/25/2018 01:59 AM, Sameer Goel wrote:
>>
>>
>> On 05/23/2018 10:48 PM, Manish Jaggi wrote:
>>> Hi Sameer,
>>>
>>> General Comment, please use appropriate variable names for XXX_domain
>>> structures in code which is xen specific.
>> I thought that we had discussed this before on one of the RFCs.
> Yes and no one replied to my last comment that the var names have to be
> non confusing in Xen specific code.
Rather than just saying "you haven't replied to my last comment", how
about giving a pointer to that e-mail?
AFAICT, the last answer was a reply from me to your e-mail. As I wrote
there if it is used by Xen only code, then it should be alright. But
Linux code *should not* be changed.
Cheers,
--
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2018-05-25 8:45 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-24 0:46 [v2 0/6] SMMUv3 driver Sameer Goel
2018-05-24 0:46 ` [v2 1/6] Port WARN_ON_ONCE() from Linux Sameer Goel
2018-05-24 7:53 ` Jan Beulich
2018-05-24 20:23 ` Sameer Goel
2018-05-25 7:07 ` Jan Beulich
2018-06-07 1:21 ` Sameer Goel
2018-05-24 0:46 ` [v2 2/6] passthrough/arm: Modify SMMU driver to use generic device definition Sameer Goel
2018-05-24 0:46 ` [v2 3/6] Add verbatim copy of arm-smmu-v3.c from Linux Sameer Goel
2018-05-24 0:46 ` [v2 4/6] xen/iommu: smmu-v3: Add Xen specific code to enable the ported driver Sameer Goel
2018-05-24 4:48 ` Manish Jaggi
2018-05-24 20:18 ` Sameer Goel
2018-05-24 20:29 ` Sameer Goel
2018-05-25 4:41 ` Manish Jaggi
2018-05-25 8:45 ` Julien Grall [this message]
2018-05-30 19:46 ` Sameer Goel
2018-05-31 4:10 ` Manish Jaggi
2018-05-31 16:06 ` Goel, Sameer
2018-05-30 23:01 ` Sameer Goel
2018-05-31 4:13 ` Manish Jaggi
2018-05-31 15:57 ` Sameer Goel
2018-06-01 5:16 ` Manish Jaggi
2018-06-01 18:58 ` Sameer Goel
2018-06-02 21:26 ` Manish Jaggi
2018-05-24 7:57 ` Jan Beulich
2018-05-24 20:26 ` Sameer Goel
2018-05-25 7:10 ` Jan Beulich
2018-05-30 19:30 ` Sameer Goel
2018-05-24 0:46 ` [v2 5/6] drivers/passthrough/arm: Refactor code for arm smmu drivers Sameer Goel
2018-05-24 7:58 ` Jan Beulich
2018-05-24 20:30 ` Sameer Goel
2018-05-24 0:46 ` [v2 6/6] xen/smmu: Add a new config define for legacy SMMU Sameer Goel
2018-05-24 7:59 ` Jan Beulich
2018-05-24 8:52 ` Julien Grall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3ff48bc8-8d38-db9e-8833-320a6acbcb17@arm.com \
--to=julien.grall@arm.com \
--cc=mjaggi@caviumnetworks.com \
--cc=roger.pau@citrix.com \
--cc=sameer.goel@linaro.org \
--cc=shankerd@codeaurora.org \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).