From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Juergen Gross <jgross@suse.com>, Xen-devel <xen-devel@lists.xen.org>
Cc: Wei Liu <wei.liu2@citrix.com>, Ian Jackson <Ian.Jackson@eu.citrix.com>
Subject: Re: [PATCH qemu-trad] Remove all use of xc_{get, set}_hvm_param()
Date: Wed, 31 May 2017 18:58:21 +0100 [thread overview]
Message-ID: <4078a78c-87e8-9cec-a60c-ccdede20fc55@citrix.com> (raw)
In-Reply-To: <d818c144-369e-0df1-efab-93692953a6d4@suse.com>
On 31/05/17 18:57, Juergen Gross wrote:
> On 31/05/17 19:47, Andrew Cooper wrote:
>> xc_{get,set}_hvm_param() are problematic because they truncate their values in
>> a 32bit build.
>>
>> Luckily, this isn't a problem in practice because all values in question
>> should be below 2^32.
>>
>> To expediate the removal of xc_{get,set}_hvm_param() from libxc, switch
>> qemu-trad over to using xc_hvm_param_{get,set}() which don't suffer from
>> truncation issues.
>>
>> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
> cscope tells me qemu upstream is using those, too.
Yeah - Ive just noticed that as well. I'm seeing how best to fix that.
~Andrew
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
prev parent reply other threads:[~2017-05-31 17:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-31 17:47 [PATCH qemu-trad] Remove all use of xc_{get, set}_hvm_param() Andrew Cooper
2017-05-31 17:57 ` Juergen Gross
2017-05-31 17:58 ` Andrew Cooper [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4078a78c-87e8-9cec-a60c-ccdede20fc55@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=jgross@suse.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).