From: Paul Semel <semelpaul@gmail.com>
To: George Dunlap <george.dunlap@citrix.com>, xen-devel@lists.xenproject.org
Cc: george.dunlap@eu.citrix.com, andrew.cooper3@citrix.com,
wei.liu2@citrix.com, JBeulich@suse.com
Subject: Re: [PATCH v2] fuzz/x86_emulate: fix bounds for input size
Date: Wed, 28 Feb 2018 18:30:34 +0100 [thread overview]
Message-ID: <40872474-fec8-61ea-4d08-c414bd64feac@gmail.com> (raw)
In-Reply-To: <6ce2fed1-7b1f-ef5a-5954-c14b35212b5d@citrix.com>
Hey George,
On 02/27/2018 11:39 AM, George Dunlap wrote:
> Thanks for the patch. Looking a bit more at the code over the weekend,
> I figured out what that BUILD_BUG_ON() is for -- in afl_harness.c, we
> statically allocate a buffer of size INPUT_SIZE to hold the fuzz data.
> The BUILD_BUG_ON() is to make sure that this buffer is always big enough
> to hold the minimum input size. And increasing the size accepted by
> LLVMFuzzerTestOneInput() won't have any effect for anybody using
> afl-harness, as the size passed in will never be larger than INPUT_SIZE.
>
Thanks for replying me ! Actually, I understood what this BUILD_BUG_ON() was for
and I totally agree with you 🙂
Anyway, I am pretty sure that this check is not needed anymore for the new
changes I made, as the condition is never reachable anymore.
> Are you running afl-harness, or are you using fuzz-emul directly some
> other way (e.g., through Google's fuzzing service)?
>
I am actually not using it, but I discovered this tool some time before, and I
am now trying to port the idea on an other emulator project.. 🙂
Anyway, I made much changes on my own version, and if it still does interest
you, I can share those changes with you once I'm done with my thing !
> -George
--
Paul
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
prev parent reply other threads:[~2018-02-28 17:08 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-22 12:39 [xen-devel] [fuzz] [x86 emulator] Input size Paul Semel
2018-02-22 18:00 ` Wei Liu
2018-02-22 23:57 ` [PATCH] fuzz/x86_emulate: fix bounds for input size Paul Semel
2018-02-23 8:20 ` Paul Semel
2018-02-23 10:44 ` George Dunlap
2018-02-23 12:07 ` Paul Semel
2018-02-23 16:30 ` Wei Liu
2018-02-23 16:33 ` George Dunlap
2018-02-23 16:37 ` Wei Liu
2018-02-23 22:41 ` Paul Semel
2018-02-23 22:48 ` [PATCH v2] " Paul Semel
2018-02-26 10:33 ` Wei Liu
2018-03-02 12:30 ` Wei Liu
2018-02-27 10:39 ` George Dunlap
2018-02-28 17:30 ` Paul Semel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40872474-fec8-61ea-4d08-c414bd64feac@gmail.com \
--to=semelpaul@gmail.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=george.dunlap@citrix.com \
--cc=george.dunlap@eu.citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).