From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Jan Beulich <JBeulich@suse.com>,
xen-devel <xen-devel@lists.xenproject.org>
Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>,
Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
Subject: Re: [PATCH] x86/SVM: correct boot time cpu_data[] handling
Date: Thu, 2 Mar 2017 15:06:44 +0000 [thread overview]
Message-ID: <411d4759-b41b-6eac-9953-eb65bcb7cfae@citrix.com> (raw)
In-Reply-To: <58B8274E020000780013F467@prv-mh.provo.novell.com>
On 02/03/17 13:08, Jan Beulich wrote:
> start_svm() already runs after cpu_data[] was set up, so it shouldn't
> modify it anymore (at least not directly). Constify the involved
> pointers.
>
> Furthermore LMSLE feature detection was broken by 566ddbe833 ("x86:
> Fail CPU bringup cleanly if it cannot initialise HVM"), as Andrew
> Cooper has pointed out: c couldn't possibly equal &boot_cpu_data
> anymore.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
I was hoping to avoid fixing LMSLE this until I had enough CPUID
infrastructure in place to make it migration safe.
OTOH, I can't really object to the patch either.
Would you mind if we #if 0'd the LMSLE bit for now, to avoid introducing
a window where it definitely isn't migration safe?
~Andrew
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2017-03-02 15:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-02 13:08 [PATCH] x86/SVM: correct boot time cpu_data[] handling Jan Beulich
2017-03-02 14:58 ` Boris Ostrovsky
2017-03-02 15:02 ` Jan Beulich
2017-03-02 15:19 ` Boris Ostrovsky
2017-03-02 15:31 ` Jan Beulich
2017-03-02 15:06 ` Andrew Cooper [this message]
2017-03-02 15:33 ` Jan Beulich
2017-03-02 15:35 ` Andrew Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=411d4759-b41b-6eac-9953-eb65bcb7cfae@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=JBeulich@suse.com \
--cc=boris.ostrovsky@oracle.com \
--cc=suravee.suthikulpanit@amd.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).