From: Paul Durrant <Paul.Durrant@citrix.com>
To: Roger Pau Monne <roger.pau@citrix.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
Wei Liu <wei.liu2@citrix.com>,
Ian Jackson <Ian.Jackson@citrix.com>
Subject: Re: [PATCH v3 04/12] tools/libxenforeignmemory: reduce xenforeignmemory_restrict code footprint
Date: Tue, 5 Sep 2017 08:39:17 +0000 [thread overview]
Message-ID: <44e7150dfc254205ae70e6e6b7e47795@AMSPEX02CL03.citrite.net> (raw)
In-Reply-To: <20170904104757.k3dyltrm6vluq7p6@MacBook-Pro-de-Roger.local>
> -----Original Message-----
> From: Roger Pau Monne
> Sent: 04 September 2017 11:48
> To: Paul Durrant <Paul.Durrant@citrix.com>
> Cc: xen-devel@lists.xenproject.org; Wei Liu <wei.liu2@citrix.com>; Ian
> Jackson <Ian.Jackson@citrix.com>
> Subject: Re: [Xen-devel] [PATCH v3 04/12] tools/libxenforeignmemory:
> reduce xenforeignmemory_restrict code footprint
>
> On Thu, Aug 31, 2017 at 10:35:57AM +0100, Paul Durrant wrote:
> > By using a static inline stub in private.h for OS where this functionality
> > is not implemented, the various duplicate stubs in the OS-specific source
> > modules can be avoided.
>
> Ouch, forget my comment in the previous patch, haven't seen that one.
>
> >
> > Signed-off-by: Paul Durrant <paul.durrant@citrix.com>
> > ---
> > Cc: Ian Jackson <ian.jackson@eu.citrix.com>
> > Cc: Wei Liu <wei.liu2@citrix.com>
> >
> > v3:
> > - Patch added in response to review comments.
> > ---
> > tools/libs/foreignmemory/minios.c | 7 -------
> > tools/libs/foreignmemory/netbsd.c | 7 -------
> > tools/libs/foreignmemory/private.h | 12 +++++++++---
> > tools/libs/foreignmemory/solaris.c | 7 -------
>
> You forgot the one in freebsd.c. With that added (or rather removed):
>
So I did.
> Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>
>
Thanks,
Paul
> Roger.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2017-09-05 8:39 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-31 9:35 [PATCH v3 00/12] x86: guest resource mapping Paul Durrant
2017-08-31 9:35 ` [PATCH v3 01/12] x86/mm: allow a privileged PV domain to map guest mfns Paul Durrant
2017-08-31 9:35 ` [PATCH v3 02/12] x86/mm: add HYPERVISOR_memory_op to acquire guest resources Paul Durrant
2017-08-31 9:35 ` [PATCH v3 03/12] tools/libxenforeignmemory: add support for resource mapping Paul Durrant
2017-09-04 10:43 ` Roger Pau Monné
2017-09-04 15:38 ` Paul Durrant
2017-08-31 9:35 ` [PATCH v3 04/12] tools/libxenforeignmemory: reduce xenforeignmemory_restrict code footprint Paul Durrant
2017-09-04 10:47 ` Roger Pau Monné
2017-09-05 8:39 ` Paul Durrant [this message]
2017-08-31 9:35 ` [PATCH v3 05/12] tools/libxenctrl: use new xenforeignmemory API to seed grant table Paul Durrant
2017-09-04 11:05 ` Roger Pau Monné
2017-08-31 9:35 ` [PATCH v3 06/12] x86/hvm/ioreq: rename .*pfn and .*gmfn to .*gfn Paul Durrant
2017-08-31 9:36 ` [PATCH v3 07/12] x86/hvm/ioreq: use bool rather than bool_t Paul Durrant
2017-08-31 9:36 ` [PATCH v3 08/12] x86/hvm/ioreq: maintain an array of ioreq servers rather than a list Paul Durrant
2017-09-04 13:40 ` Roger Pau Monné
2017-09-04 14:39 ` Jan Beulich
2017-09-05 9:06 ` Paul Durrant
2017-08-31 9:36 ` [PATCH v3 09/12] x86/hvm/ioreq: simplify code and use consistent naming Paul Durrant
2017-09-04 14:08 ` Roger Pau Monné
2017-08-31 9:36 ` [PATCH v3 10/12] x86/hvm/ioreq: use gfn_t in struct hvm_ioreq_page Paul Durrant
2017-08-31 9:36 ` [PATCH v3 11/12] x86/hvm/ioreq: defer mapping gfns until they are actually requsted Paul Durrant
2017-09-04 14:31 ` Roger Pau Monné
2017-08-31 9:36 ` [PATCH v3 12/12] x86/hvm/ioreq: add a new mappable resource type Paul Durrant
2017-09-04 15:02 ` Roger Pau Monné
2017-09-04 15:04 ` Paul Durrant
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44e7150dfc254205ae70e6e6b7e47795@AMSPEX02CL03.citrite.net \
--to=paul.durrant@citrix.com \
--cc=Ian.Jackson@citrix.com \
--cc=roger.pau@citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).