From mboxrd@z Thu Jan 1 00:00:00 1970 From: George Dunlap Subject: Re: [PATCH 3/7] xen: credit2: soft-affinity awareness in fallback_cpu() Date: Tue, 25 Jul 2017 11:19:59 +0100 Message-ID: <45a42cae-9683-9fd7-690f-6f5424e24ea9@citrix.com> References: <149762114626.11899.6393770850121347748.stgit@Solace.fritz.box> <149762243723.11899.13163340131516329714.stgit@Solace.fritz.box> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail6.bemta6.messagelabs.com ([193.109.254.103]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dZwwe-0002ND-5I for xen-devel@lists.xenproject.org; Tue, 25 Jul 2017 10:20:04 +0000 In-Reply-To: <149762243723.11899.13163340131516329714.stgit@Solace.fritz.box> Content-Language: en-US List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Dario Faggioli , xen-devel@lists.xenproject.org Cc: George Dunlap , Anshul Makkar , "Justin T. Weaver" List-Id: xen-devel@lists.xenproject.org T24gMDYvMTYvMjAxNyAwMzoxMyBQTSwgRGFyaW8gRmFnZ2lvbGkgd3JvdGU6Cj4gQnksIGJhc2lj YWxseSwgbW92aW5nIGFsbCB0aGUgbG9naWMgb2YgdGhlIGZ1bmN0aW9uCj4gaW5zaWRlIHRoZSB1 c3VhbCB0d28gc3RlcHMgKHNvZnQtYWZmaW5pdHkgc3RlcCBhbmQKPiBoYXJkLWFmZmluaXR5IHN0 ZXApIGxvb3AuCj4gCj4gU2lnbmVkLW9mZi1ieTogRGFyaW8gRmFnZ2lvbGkgPGRhcmlvLmZhZ2dp b2xpQGNpdHJpeC5jb20+Cj4gU2lnbmVkLW9mZi1ieTogSnVzdGluIFQuIFdlYXZlciA8anR3ZWF2 ZXJAaGF3YWlpLmVkdT4KPiAtLS0KPiBDYzogQW5zaHVsIE1ha2thciA8YW5zaHVsLm1ha2thckBj aXRyaXguY29tPgo+IENjOiBHZW9yZ2UgRHVubGFwIDxnZW9yZ2UuZHVubGFwQGV1LmNpdHJpeC5j b20+Cj4gLS0tCj4gR2VvcmdlLCB5b3UgZ2F2ZSB5b3VyIFJldmlld2VkLWJ5IHRvOgo+ICBodHRw czovL2xpc3RzLnhlbnByb2plY3Qub3JnL2FyY2hpdmVzL2h0bWwveGVuLWRldmVsLzIwMTYtMDgv bXNnMDIyMDEuaHRtbAo+IAo+IHdoaWNoIHdhcyBhZGRpbmcgc29mdC1hZmZpbml0eSBhd2FyZW5l c3MgdG8gYm90aCBmYWxsYmFja19jcHUgYW5kIGNwdV9waWNrKCkuIFNlZSBoZXJlOgo+ICBodHRw czovL2xpc3RzLnhlbnByb2plY3Qub3JnL2FyY2hpdmVzL2h0bWwveGVuLWRldmVsLzIwMTYtMDkv bXNnMDMyNTkuaHRtbAo+IAo+IEkgY2hhbmdlZCB0aGUgY3B1X3BpY2soKSBwYXJ0IGEgbG90LCBh bmQgdGhhdCdzIHdoeSBJIGRlY2lkZWQgdG8gc3BsaXQgdGhlCj4gcGF0Y2ggaW4gdHdvLiAgQXMg ZmFyIGFzIGZhbGxiYWNrX2NwdSgpLCB0aG91Z2gsIHdoYXQncyBkb25lIGluIHRoaXMgcGF0Y2gg aXMKPiBleGFjdGx5IHRoZSBzYW1lIHRoYXQgd2FzIGJlaW5nIGRvbmUgaW4gdGhlIG9yaWdpbmFs IG9uZS4KPiAKPiBTbywgb2YgY291cnNlIEknbSBkcm9wcGluZyB0aGUgUmV2LWJ5LCBidXQgSSB0 aG91Z2h0IGl0IGNvdWxkIGhhdmUgYmVlbiB1c2VmdWwKPiB0byBtZW50aW9uIHRoaXMuIDotKQo+ IC0tLQo+ICB4ZW4vY29tbW9uL3NjaGVkX2NyZWRpdDIuYyB8ICAgNzcgKysrKysrKysrKysrKysr KysrKysrKysrKysrKysrKystLS0tLS0tLS0tLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDU2IGluc2Vy dGlvbnMoKyksIDIxIGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS94ZW4vY29tbW9uL3Nj aGVkX2NyZWRpdDIuYyBiL3hlbi9jb21tb24vc2NoZWRfY3JlZGl0Mi5jCj4gaW5kZXggYzc0OWQ0 ZS4uNTRmNmUyMSAxMDA2NDQKPiAtLS0gYS94ZW4vY29tbW9uL3NjaGVkX2NyZWRpdDIuYwo+ICsr KyBiL3hlbi9jb21tb24vc2NoZWRfY3JlZGl0Mi5jCj4gQEAgLTUzNywzNiArNTM3LDcxIEBAIHZv aWQgc210X2lkbGVfbWFza19jbGVhcih1bnNpZ25lZCBpbnQgY3B1LCBjcHVtYXNrX3QgKm1hc2sp Cj4gIH0KPiAgCj4gIC8qCj4gLSAqIFdoZW4gYSBoYXJkIGFmZmluaXR5IGNoYW5nZSBvY2N1cnMs IHdlIG1heSBub3QgYmUgYWJsZSB0byBjaGVjayBzb21lCj4gLSAqIChhbnkhKSBvZiB0aGUgb3Ro ZXIgcnVucXVldWVzLCB3aGVuIGxvb2tpbmcgZm9yIHRoZSBiZXN0IG5ldyBwcm9jZXNzb3IKPiAt ICogZm9yIHN2YyAoYXMgdHJ5bG9jay1zIGluIGNzY2hlZDJfY3B1X3BpY2soKSBjYW4gZmFpbCku IElmIHRoYXQgaGFwcGVucywgd2UKPiAtICogcGljaywgaW4gb3JkZXIgb2YgZGVjcmVhc2luZyBw cmVmZXJlbmNlOgo+IC0gKiAgLSBzdmMncyBjdXJyZW50IHBjcHU7Cj4gLSAqICAtIGFub3RoZXIg cGNwdSBmcm9tIHN2YydzIGN1cnJlbnQgcnVucTsKPiAtICogIC0gYW55IGNwdS4KPiArICogSW4g Y3NjaGVkMl9jcHVfcGljaygpLCBpdCBtYXkgbm90IGJlIHBvc3NpYmxlIHRvIGFjdHVhbGx5IGxv b2sgYXQgcmVtb3RlCj4gKyAqIHJ1bnF1ZXVlcyAodGhlIHRyeWxvY2stcyBvbiB0aGVpciBzcGlu bG9ja3MgY2FuIGZhaWwhKS4gSWYgdGhhdCBoYXBwZW5zLAo+ICsgKiB3ZSBwaWNrLCBpbiBvcmRl ciBvZiBkZWNyZWFzaW5nIHByZWZlcmVuY2U6Cj4gKyAqICAxKSBzdmMncyBjdXJyZW50IHBjcHUs IGlmIGl0IGlzIHBhcnQgb2Ygc3ZjJ3Mgc29mdCBhZmZpbml0eTsKPiArICogIDIpIGEgcGNwdSBp biBzdmMncyBjdXJyZW50IHJ1bnF1ZXVlIHRoYXQgaXMgYWxzbyBpbiBzdmMncyBzb2Z0IGFmZmlu aXR5Owo+ICsgKiAgMykganVzdCBvbmUgdmFsaWQgcGNwdSBmcm9tIHN2YydzIHNvZnQgYWZmaW5p dHk7Cj4gKyAqICA0KSBzdmMncyBjdXJyZW50IHBjcHUsIGlmIGl0IGlzIHBhcnQgb2Ygc3ZjJ3Mg aGFyZCBhZmZpbml0eTsKPiArICogIDUpIGEgcGNwdSBpbiBzdmMncyBjdXJyZW50IHJ1bnF1ZXVl IHRoYXQgaXMgYWxzbyBpbiBzdmMncyBoYXJkIGFmZmluaXR5Owo+ICsgKiAgNikganVzdCBvbmUg dmFsaWQgcGNwdSBmcm9tIHN2YydzIGhhcmQgYWZmaW5pdHkKPiArICoKPiArICogT2YgY291cnNl LCAxLCAyIGFuZCAzIG1ha2VzIHNlbnNlIG9ubHkgaWYgc3ZjIGhhcyBhIHNvZnQgYWZmaW5pdHku IEFsc28KPiArICogbm90ZSB0aGF0IGF0IGxlYXN0IDYgaXMgZ3VhcmFudGVlZCB0byBfYWx3YXlz XyByZXR1cm4gYXQgbGVhc3Qgb25lIHBjcHUuCj4gICAqLwo+ICBzdGF0aWMgaW50IGdldF9mYWxs YmFja19jcHUoc3RydWN0IGNzY2hlZDJfdmNwdSAqc3ZjKQo+ICB7Cj4gICAgICBzdHJ1Y3QgdmNw dSAqdiA9IHN2Yy0+dmNwdTsKPiAtICAgIGludCBjcHUgPSB2LT5wcm9jZXNzb3I7Cj4gKyAgICB1 bnNpZ25lZCBpbnQgYnM7Cj4gIAo+IC0gICAgY3B1bWFza19hbmQoY3B1bWFza19zY3JhdGNoX2Nw dShjcHUpLCB2LT5jcHVfaGFyZF9hZmZpbml0eSwKPiAtICAgICAgICAgICAgICAgIGNwdXBvb2xf ZG9tYWluX2NwdW1hc2sodi0+ZG9tYWluKSk7Cj4gKyAgICBmb3JfZWFjaF9hZmZpbml0eV9iYWxh bmNlX3N0ZXAoIGJzICkKPiArICAgIHsKPiArICAgICAgICBpbnQgY3B1ID0gdi0+cHJvY2Vzc29y Owo+ICsKPiArICAgICAgICBpZiAoIGJzID09IEJBTEFOQ0VfU09GVF9BRkZJTklUWSAmJgo+ICsg ICAgICAgICAgICAgIWhhc19zb2Z0X2FmZmluaXR5KHYsIHYtPmNwdV9oYXJkX2FmZmluaXR5KSAp Cj4gKyAgICAgICAgICAgIGNvbnRpbnVlOwo+ICAKPiAtICAgIGlmICggbGlrZWx5KGNwdW1hc2tf dGVzdF9jcHUoY3B1LCBjcHVtYXNrX3NjcmF0Y2hfY3B1KGNwdSkpKSApCj4gLSAgICAgICAgcmV0 dXJuIGNwdTsKPiArICAgICAgICBhZmZpbml0eV9iYWxhbmNlX2NwdW1hc2sodiwgYnMsIGNwdW1h c2tfc2NyYXRjaF9jcHUoY3B1KSk7Cj4gKyAgICAgICAgY3B1bWFza19hbmQoY3B1bWFza19zY3Jh dGNoX2NwdShjcHUpLCBjcHVtYXNrX3NjcmF0Y2hfY3B1KGNwdSksCj4gKyAgICAgICAgICAgICAg ICAgICAgY3B1cG9vbF9kb21haW5fY3B1bWFzayh2LT5kb21haW4pKTsKPiAgCj4gLSAgICBpZiAo IGxpa2VseShjcHVtYXNrX2ludGVyc2VjdHMoY3B1bWFza19zY3JhdGNoX2NwdShjcHUpLAo+IC0g ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICZzdmMtPnJxZC0+YWN0aXZlKSkgKQo+ IC0gICAgewo+IC0gICAgICAgIGNwdW1hc2tfYW5kKGNwdW1hc2tfc2NyYXRjaF9jcHUoY3B1KSwg JnN2Yy0+cnFkLT5hY3RpdmUsCj4gLSAgICAgICAgICAgICAgICAgICAgY3B1bWFza19zY3JhdGNo X2NwdShjcHUpKTsKPiAtICAgICAgICByZXR1cm4gY3B1bWFza19maXJzdChjcHVtYXNrX3NjcmF0 Y2hfY3B1KGNwdSkpOwo+IC0gICAgfQo+ICsgICAgICAgIC8qCj4gKyAgICAgICAgICogVGhpcyBp cyBjYXNlcyAxIG9yIDQgKGRlcGVuZGluZyBvbiBicyk6IGlmIHYtPnByb2Nlc3NvciBpcyAoc3Rp bGwpCj4gKyAgICAgICAgICogaW4gb3VyIGFmZmluaXR5LCBnbyBmb3IgaXQsIGZvciBjYWNoZSBi ZXR0ZXJuZXNzLgo+ICsgICAgICAgICAqLwo+ICsgICAgICAgIGlmICggbGlrZWx5KGNwdW1hc2tf dGVzdF9jcHUoY3B1LCBjcHVtYXNrX3NjcmF0Y2hfY3B1KGNwdSkpKSApCj4gKyAgICAgICAgICAg IHJldHVybiBjcHU7Cj4gIAo+IC0gICAgQVNTRVJUKCFjcHVtYXNrX2VtcHR5KGNwdW1hc2tfc2Ny YXRjaF9jcHUoY3B1KSkpOwo+ICsgICAgICAgIC8qCj4gKyAgICAgICAgICogVGhpcyBpcyBjYXNl cyAyIG9yIDUgKGRlcGVuZGluZyBvbiBicyk6IHYtPnByb2Nlc3NvciBpc24ndCB0aGVyZQo+ICsg ICAgICAgICAqIGFueSBsb25nZXIsIGNoZWNrIGlmIHdlIGF0IGxlYXN0IGNhbiBzdGF5IGluIG91 ciBjdXJyZW50IHJ1bnEuCj4gKyAgICAgICAgICovCj4gKyAgICAgICAgaWYgKCBsaWtlbHkoY3B1 bWFza19pbnRlcnNlY3RzKGNwdW1hc2tfc2NyYXRjaF9jcHUoY3B1KSwKPiArICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgJnN2Yy0+cnFkLT5hY3RpdmUpKSApCj4gKyAgICAg ICAgewo+ICsgICAgICAgICAgICBjcHVtYXNrX2FuZChjcHVtYXNrX3NjcmF0Y2hfY3B1KGNwdSks IGNwdW1hc2tfc2NyYXRjaF9jcHUoY3B1KSwKPiArICAgICAgICAgICAgICAgICAgICAgICAgJnN2 Yy0+cnFkLT5hY3RpdmUpOwo+ICsgICAgICAgICAgICByZXR1cm4gY3B1bWFza19maXJzdChjcHVt YXNrX3NjcmF0Y2hfY3B1KGNwdSkpOwo+ICsgICAgICAgIH0KPiAgCj4gLSAgICByZXR1cm4gY3B1 bWFza19maXJzdChjcHVtYXNrX3NjcmF0Y2hfY3B1KGNwdSkpOwo+ICsgICAgICAgIC8qCj4gKyAg ICAgICAgICogVGhpcyBpcyBjYXNlcyAzIG9yIDYgKGRlcGVuZGluZyBvbiBicyk6IGxhc3Qgc3Rh bmQsIGp1c3Qgb25lIHZhbGlkCj4gKyAgICAgICAgICogcGNwdSBmcm9tIG91ciBzb2Z0IGFmZmlu aXR5LCBpZiB3ZSBoYXZlIG9uZSBhbmQgaWYgdGhlcmUncyBhbnkuIEluCj4gKyAgICAgICAgICog ZmFjdCwgaWYgd2UgYXJlIGRvaW5nIHNvZnQtYWZmaW5pdHksIGl0IGlzIHBvc3NpYmxlIHRoYXQg d2UgZmFpbCwKPiArICAgICAgICAgKiB3aGljaCBtZWFucyB3ZSBzdGF5IGluIHRoZSBsb29wIGFu ZCBsb29rIGZvciBoYXJkIGFmZmluaXR5LiBPVE9ILAo+ICsgICAgICAgICAqIGlmIHdlIGFyZSBh dCB0aGUgaGFyZC1hZmZpbml0eSBiYWxhbmNpbmcgc3RlcCwgaXQncyBndWFyYW50ZWVkIHRoYXQK PiArICAgICAgICAgKiB0aGVyZSBpcyBhdCBsZWFzdCBvbmUgdmFsaWQgY3B1LCBhbmQgdGhlcmVm b3JlIHdlIGFyZSBzdXJlIHRoYXQgd2UKPiArICAgICAgICAgKiByZXR1cm4gaXQsIGFuZCBuZXZl ciByZWFsbHkgZXhpdCB0aGUgbG9vcC4KPiArICAgICAgICAgKi8KPiArICAgICAgICBBU1NFUlQo IWNwdW1hc2tfZW1wdHkoY3B1bWFza19zY3JhdGNoX2NwdShjcHUpKSB8fAo+ICsgICAgICAgICAg ICAgICBicyA9PSBCQUxBTkNFX1NPRlRfQUZGSU5JVFkpOwo+ICsgICAgICAgIGNwdSA9IGNwdW1h c2tfZmlyc3QoY3B1bWFza19zY3JhdGNoX2NwdShjcHUpKTsKClNvIGp1c3QgY2hlY2tpbmcgbXkg dW5kZXJzdGFuZGluZyBoZXJlLi4uIGF0IHRoaXMgcG9pbnQgd2UncmUgbm90IHRha2luZwppbnRv IGNvbnNpZGVyYXRpb24gbG9hZCBvciBpZGxlbmVzcyBvciBhbnl0aGluZyBlbHNlIC0tIHdlJ3Jl IGp1c3QKc2F5aW5nLCAiSXMgdGhlcmUgYSBjcHUgaW4gbXkgc29mdCBhZmZpbml0eSBpdCBpcyAq cG9zc2libGUqIHRvIHJ1biBvbj8iCiBTbyBvbiBhIHByb3Blcmx5IGNvbmZpZ3VyZWQgc3lzdGVt LCB3ZSBzaG91bGQgbmV2ZXIgdGFrZSB0aGUgc2Vjb25kCml0ZXJhdGlvbiBvZiB0aGUgbG9vcD8K Cj4gKyAgICAgICAgaWYgKCBsaWtlbHkoY3B1IDwgbnJfY3B1X2lkcykgKQo+ICsgICAgICAgICAg ICByZXR1cm4gY3B1Owo+ICsgICAgfQo+ICsgICAgQlVHX09OKDEpOwoKRG8gd2Ugd2FudCB0byBC VUcoKSBoZXJlPyAgSSBkb24ndCB0aGluayB0aGlzIGNvbnN0aXR1dGVzIGFuCnVucmVjb3ZlcmFi bGUgZXJyb3I7IGFuIEFTU0VSVF9VTlJFQUNIQUJMRSgpIHBsdXMgc29tZXRoaW5nIHJhbmRvbSB3 b3VsZApiZSBiZXR0ZXIsIHdvdWxkbid0IGl0PwoKIC1HZW9yZ2UKCl9fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fClhlbi1kZXZlbCBtYWlsaW5nIGxpc3QKWGVu LWRldmVsQGxpc3RzLnhlbi5vcmcKaHR0cHM6Ly9saXN0cy54ZW4ub3JnL3hlbi1kZXZlbAo=