From: "Andres Lagar-Cavilla" <andres@lagarcavilla.org>
To: Dan Magenheimer <dan.magenheimer@oracle.com>
Cc: xen-devel@lists.xensource.com, ian.campbell@citrix.com,
andres@gridcentric.ca, tim@xen.org,
Andres Lagar-Cavilla <andres@lagarcavilla.org>,
jbeulich@suse.com, ian.jackson@citrix.com, adin@gridcentric.ca
Subject: Re: [PATCH 1 of 2] Global virq for low memory situations
Date: Thu, 1 Mar 2012 11:26:16 -0800 [thread overview]
Message-ID: <46af1dab87364f03e8d8027072ee76a5.squirrel@webmail.lagarcavilla.org> (raw)
In-Reply-To: <e897e5a7-ef7a-4115-b895-df9d2bf54a52@default>
>> From: Andres Lagar-Cavilla [mailto:andres@lagarcavilla.org]
>> Sent: Wednesday, February 29, 2012 7:26 PM
>> To: xen-devel@lists.xensource.com
>> Cc: ian.campbell@citrix.com; andres@gridcentric.ca; tim@xen.org;
>> JBeulich@suse.com;
>> ian.jackson@citrix.com; adin@gridcentric.ca
>> Subject: [Xen-devel] [PATCH 1 of 2] Global virq for low memory
>> situations
>>
>> xen/common/page_alloc.c | 112
>> +++++++++++++++++++++++++++++++++++++++++++++++
>> xen/include/public/xen.h | 1 +
>> 2 files changed, 113 insertions(+), 0 deletions(-)
>
> Just a note that I think this will trigger false positives when
> Xen tmem is working (with tmem-enabled guests). With tmem,
> Xen has two classes of free memory: free and "freeable".
> In many situations, free will approach 0 but there will still
> be lots of "freeable" memory which is available for guest
> ballooning, launching new domains, etc.
>
> It may be the case that your virq may never be used on
> a system with a tmem guest, but if it is, weird things
> (like unnecessary hypervisor swapping) may happen.
Since I know zero point zero zero zip nada about tmem, maybe the most
efficient path is that you throw on top of the patch the tmem magic. Which
would seem to be all about factoring tmem_freeable_pages() into the
calculation?
Thanks,
Andres
>
> Dan
>
next prev parent reply other threads:[~2012-03-01 19:26 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-01 2:25 [PATCH 0 of 2] Virq for low memory condition, V4 Andres Lagar-Cavilla
2012-03-01 2:25 ` [PATCH 1 of 2] Global virq for low memory situations Andres Lagar-Cavilla
2012-03-01 19:19 ` Dan Magenheimer
2012-03-01 19:26 ` Andres Lagar-Cavilla [this message]
2012-03-01 21:08 ` Dan Magenheimer
2012-03-01 2:25 ` [PATCH 2 of 2] Lowmemd: Simple demo code to show use of VIRQ_ENOMEM Andres Lagar-Cavilla
2012-03-01 15:30 ` Ian Jackson
-- strict thread matches above, loose matches on Subject: below --
2012-03-06 20:03 [PATCH 0 of 2] Virq for low memory conditions, V5 Andres Lagar-Cavilla
2012-03-06 20:03 ` [PATCH 1 of 2] Global virq for low memory situations Andres Lagar-Cavilla
2012-02-28 21:56 [PATCH 0 of 2] Virq for low memory condition, V3 Andres Lagar-Cavilla
2012-02-28 21:56 ` [PATCH 1 of 2] Global virq for low memory situations Andres Lagar-Cavilla
2012-02-28 23:50 ` Dan Magenheimer
2012-02-29 4:17 ` Andres Lagar-Cavilla
2012-02-29 8:54 ` Jan Beulich
2012-02-29 8:53 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46af1dab87364f03e8d8027072ee76a5.squirrel@webmail.lagarcavilla.org \
--to=andres@lagarcavilla.org \
--cc=adin@gridcentric.ca \
--cc=andres@gridcentric.ca \
--cc=dan.magenheimer@oracle.com \
--cc=ian.campbell@citrix.com \
--cc=ian.jackson@citrix.com \
--cc=jbeulich@suse.com \
--cc=tim@xen.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).