From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cooper Subject: Re: [PATCH 8/8] xen: Swich parameter in get_page_from_gfn to use typesafe gfn Date: Tue, 6 Nov 2018 20:11:39 +0000 Message-ID: <479bb855-0bb7-dd30-a7a4-692b189cc7c5@citrix.com> References: <20181106191454.22143-1-julien.grall@arm.com> <20181106191454.22143-9-julien.grall@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1gK7hW-0000kH-3Z for xen-devel@lists.xenproject.org; Tue, 06 Nov 2018 20:11:50 +0000 In-Reply-To: <20181106191454.22143-9-julien.grall@arm.com> Content-Language: en-GB List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" To: Julien Grall , sstabellini@kernel.org, xen-devel@lists.xenproject.org Cc: Jun Nakajima , Kevin Tian , Wei Liu , Suravee Suthikulpanit , Konrad Rzeszutek Wilk , George Dunlap , Ian Jackson , Tim Deegan , Julien Grall , Paul Durrant , Jan Beulich , Boris Ostrovsky , Brian Woods List-Id: xen-devel@lists.xenproject.org SGkgLSBqdXN0IHNvbWUgY29zbWV0aWMgc3VnZ2VzdGlvbnMuCgpTdWJqZWN0IHMvU3dpY2gvU3dp dGNoLwoKPiBkaWZmIC0tZ2l0IGEveGVuL2FyY2gveDg2L3B2L2VtdWwtcHJpdi1vcC5jIGIveGVu L2FyY2gveDg2L3B2L2VtdWwtcHJpdi1vcC5jCj4gaW5kZXggZjczZWE0YTE2My4uYTUyOWViY2Mz ZiAxMDA2NDQKPiAtLS0gYS94ZW4vYXJjaC94ODYvcHYvZW11bC1wcml2LW9wLmMKPiArKysgYi94 ZW4vYXJjaC94ODYvcHYvZW11bC1wcml2LW9wLmMKPiBAQCAtNzYwLDEyICs3NjAsMTIgQEAgc3Rh dGljIGludCB3cml0ZV9jcih1bnNpZ25lZCBpbnQgcmVnLCB1bnNpZ25lZCBsb25nIHZhbCwKPiAg ICAgIGNhc2UgMzogLyogV3JpdGUgQ1IzICovCj4gICAgICB7Cj4gICAgICAgICAgc3RydWN0IGRv bWFpbiAqY3VycmQgPSBjdXJyLT5kb21haW47Cj4gLSAgICAgICAgdW5zaWduZWQgbG9uZyBnZm47 Cj4gKyAgICAgICAgZ2ZuX3QgZ2ZuOwo+ICAgICAgICAgIHN0cnVjdCBwYWdlX2luZm8gKnBhZ2U7 Cj4gICAgICAgICAgaW50IHJjOwo+ICAKPiAtICAgICAgICBnZm4gPSAhaXNfcHZfMzJiaXRfZG9t YWluKGN1cnJkKQo+IC0gICAgICAgICAgICAgID8geGVuX2NyM190b19wZm4odmFsKSA6IGNvbXBh dF9jcjNfdG9fcGZuKHZhbCk7Cj4gKyAgICAgICAgZ2ZuID0gX2dmbighaXNfcHZfMzJiaXRfZG9t YWluKGN1cnJkKQo+ICsgICAgICAgICAgICAgID8geGVuX2NyM190b19wZm4odmFsKSA6IGNvbXBh dF9jcjNfdG9fcGZuKHZhbCkpOwoKUGxlYXNlIHJlLWluZGVudC4KCj4gICAgICAgICAgcGFnZSA9 IGdldF9wYWdlX2Zyb21fZ2ZuKGN1cnJkLCBnZm4sIE5VTEwsIFAyTV9BTExPQyk7Cj4gICAgICAg ICAgaWYgKCAhcGFnZSApCj4gICAgICAgICAgICAgIGJyZWFrOwo+IGRpZmYgLS1naXQgYS94ZW4v YXJjaC94ODYvdHJhcHMuYyBiL3hlbi9hcmNoL3g4Ni90cmFwcy5jCj4gaW5kZXggOTQ3MWQ4OTAy Mi4uZDk2N2U0OTQzMiAxMDA2NDQKPiAtLS0gYS94ZW4vYXJjaC94ODYvdHJhcHMuYwo+ICsrKyBi L3hlbi9hcmNoL3g4Ni90cmFwcy5jCj4gQEAgLTgxNywxMyArODE3LDE0IEBAIGludCBndWVzdF93 cm1zcl94ZW4oc3RydWN0IHZjcHUgKnYsIHVpbnQzMl90IGlkeCwgdWludDY0X3QgdmFsKQo+ICAK PiAgICAgICAgICAgICAgaWYgKCBwMm1faXNfcGFnaW5nKHQpICkKPiAgICAgICAgICAgICAgewo+ IC0gICAgICAgICAgICAgICAgcDJtX21lbV9wYWdpbmdfcG9wdWxhdGUoZCwgZ21mbik7Cj4gKyAg ICAgICAgICAgICAgICBwMm1fbWVtX3BhZ2luZ19wb3B1bGF0ZShkLCBnZm5feChnZm4pKTsKPiAg ICAgICAgICAgICAgICAgIHJldHVybiBYODZFTVVMX1JFVFJZOwo+ICAgICAgICAgICAgICB9Cj4g IAo+ICAgICAgICAgICAgICBnZHByaW50ayhYRU5MT0dfV0FSTklORywKPiAtICAgICAgICAgICAg ICAgICAgICAgIkJhZCBHTUZOICVseCAoTUZOICUjIlBSSV9tZm4iKSB0byBNU1IgJTA4eFxuIiwK PiAtICAgICAgICAgICAgICAgICAgICAgZ21mbiwgbWZuX3gocGFnZSA/IHBhZ2VfdG9fbWZuKHBh Z2UpIDogSU5WQUxJRF9NRk4pLCBiYXNlKTsKPiArICAgICAgICAgICAgICAgICAgICAgIkJhZCBH TUZOICUjIlBSSV9nZm4iIChNRk4gJSMiUFJJX21mbiIpIHRvIE1TUiAlMDh4XG4iLAoKR01GTiA9 PiBHRk4uCgo+ICsgICAgICAgICAgICAgICAgICAgICBnZm5feChnZm4pLCBtZm5feChwYWdlID8g cGFnZV90b19tZm4ocGFnZSkgOiBJTlZBTElEX01GTiksCj4gKyAgICAgICAgICAgICAgICAgICAg IGJhc2UpOwo+ICAgICAgICAgICAgICByZXR1cm4gWDg2RU1VTF9FWENFUFRJT047Cj4gICAgICAg ICAgfQo+ICAKPiBkaWZmIC0tZ2l0IGEveGVuL2luY2x1ZGUvYXNtLXg4Ni9wMm0uaCBiL3hlbi9p bmNsdWRlL2FzbS14ODYvcDJtLmgKPiBpbmRleCBkMDhjNTk1ODg3Li5kYjFlYzM3NjEwIDEwMDY0 NAo+IC0tLSBhL3hlbi9pbmNsdWRlL2FzbS14ODYvcDJtLmgKPiArKysgYi94ZW4vaW5jbHVkZS9h c20teDg2L3AybS5oCj4gQEAgLTQ4OSwxOCArNDg5LDIxIEBAIHN0cnVjdCBwYWdlX2luZm8gKnAy bV9nZXRfcGFnZV9mcm9tX2dmbihzdHJ1Y3QgcDJtX2RvbWFpbiAqcDJtLCBnZm5fdCBnZm4sCj4g ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBwMm1fcXVlcnlfdCBxKTsK PiAgCj4gIHN0YXRpYyBpbmxpbmUgc3RydWN0IHBhZ2VfaW5mbyAqZ2V0X3BhZ2VfZnJvbV9nZm4o Cj4gLSAgICBzdHJ1Y3QgZG9tYWluICpkLCB1bnNpZ25lZCBsb25nIGdmbiwgcDJtX3R5cGVfdCAq dCwgcDJtX3F1ZXJ5X3QgcSkKPiArICAgIHN0cnVjdCBkb21haW4gKmQsIGdmbl90IGdmbiwgcDJt X3R5cGVfdCAqdCwgcDJtX3F1ZXJ5X3QgcSkKPiAgewo+ICAgICAgc3RydWN0IHBhZ2VfaW5mbyAq cGFnZTsKPiArICAgIG1mbl90IG1mbjsKPiAgCj4gICAgICBpZiAoIHBhZ2luZ19tb2RlX3RyYW5z bGF0ZShkKSApCj4gLSAgICAgICAgcmV0dXJuIHAybV9nZXRfcGFnZV9mcm9tX2dmbihwMm1fZ2V0 X2hvc3RwMm0oZCksIF9nZm4oZ2ZuKSwgdCwgTlVMTCwgcSk7Cj4gKyAgICAgICAgcmV0dXJuIHAy bV9nZXRfcGFnZV9mcm9tX2dmbihwMm1fZ2V0X2hvc3RwMm0oZCksIGdmbiwgdCwgTlVMTCwgcSk7 Cj4gIAo+ICAgICAgLyogTm9uLXRyYW5zbGF0ZWQgZ3Vlc3RzIHNlZSAxLTEgUkFNIC8gTU1JTyBt YXBwaW5ncyBldmVyeXdoZXJlICovCj4gICAgICBpZiAoIHQgKQo+ICAgICAgICAgICp0ID0gbGlr ZWx5KGQgIT0gZG9tX2lvKSA/IHAybV9yYW1fcncgOiBwMm1fbW1pb19kaXJlY3Q7Cj4gLSAgICBw YWdlID0gbWZuX3RvX3BhZ2UoX21mbihnZm4pKTsKPiAtICAgIHJldHVybiBtZm5fdmFsaWQoX21m bihnZm4pKSAmJiBnZXRfcGFnZShwYWdlLCBkKSA/IHBhZ2UgOiBOVUxMOwo+ICsKPiArICAgIG1m biA9IF9tZm4oZ2ZuX3goZ2ZuKSk7Cj4gKyAgICBwYWdlID0gbWZuX3RvX3BhZ2UobWZuKTsKPiAr ICAgIHJldHVybiBtZm5fdmFsaWQobWZuKSAmJiBnZXRfcGFnZShwYWdlLCBkKSA/IHBhZ2UgOiBO VUxMOwoKVGhpcyBsb29rcyBsaWtlIGl0IHdvdWxkIGJlIGNsZWFuZXIgYnkgbm90IHNwbGl0dGlu ZyBtZm4gb3V0IGludG8gYQpzZXBhcmF0ZSB2YXJpYWJsZS4KCnBhZ2UgPSBtZm5fdG9fcGFnZShf bWZuKGdmbl94KGdmbikpKTsKCnJldHVybiBtZm5fdmFsaWQobWZuKSAmJiBnZXRfcGFnZShwYWdl LCBkKSA/IHBhZ2UgOiBOVUxMOwoKVGhlIG9ubHkgcmVhc29uIHRoaXMgbG9va3Mgb2RkIGlzIGJl Y2F1c2Ugb2YgdGhlIG1mbiA9PiBnZm4gZXF1YWxpdHksCmJ1dCB3ZSBhcmUganVzdCBiZXNpZGUg YSBjb21tZW50IGV4cGxhaW5pbmcgdGhhdCB3ZSBhcmUgbm9uLXRyYW5zbGF0ZWQuCgp+QW5kcmV3 CgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpYZW4tZGV2 ZWwgbWFpbGluZyBsaXN0Clhlbi1kZXZlbEBsaXN0cy54ZW5wcm9qZWN0Lm9yZwpodHRwczovL2xp c3RzLnhlbnByb2plY3Qub3JnL21haWxtYW4vbGlzdGluZm8veGVuLWRldmVs