From: Juergen Gross <jgross@suse.com>
To: Jan Beulich <JBeulich@suse.com>, xen-devel@lists.xenproject.org
Cc: sstabellini@kernel.org, wei.liu2@citrix.com,
George.Dunlap@eu.citrix.com, andrew.cooper3@citrix.com,
ian.jackson@eu.citrix.com, tim@xen.org, julien.grall@arm.com,
dgdegra@tycho.nsa.gov
Subject: Re: [PATCH v10 10/11] xen: add new Xen cpuid node for max address width info
Date: Thu, 28 Sep 2017 11:52:19 +0200 [thread overview]
Message-ID: <47ae2d9d-969a-dba0-fbc9-075fa58ed7fb@suse.com> (raw)
In-Reply-To: <59CCDFBD02000078001805E9@suse.com>
On 28/09/17 11:40, Jan Beulich wrote:
>>>> On 28.09.17 at 11:04, <jgross@suse.com> wrote:
>> On 28/09/17 10:59, Jan Beulich wrote:
>>>>>> On 25.09.17 at 12:00, <jgross@suse.com> wrote:
>>>> --- a/xen/arch/x86/traps.c
>>>> +++ b/xen/arch/x86/traps.c
>>>> @@ -930,6 +930,13 @@ void cpuid_hypervisor_leaves(const struct vcpu *v, uint32_t leaf,
>>>> res->b = v->vcpu_id;
>>>> break;
>>>>
>>>> + case 5: /* PV-specific parameters */
>>>> + if ( is_hvm_domain(d) || subleaf != 0 )
>>>> + break;
>>>> +
>>>> + res->a = generic_flsl(get_upper_mfn_bound()) + PAGE_SHIFT;
>>>
>>> While preparing to commit this I wondered why this isn't just
>>> flsl(). Can you explain this, or can I just change it?
>>
>> It is meant to be similar to CPUID leaf 0x80000008: the width of the
>> max. machine address, not that of the max. MFN.
>
> I don't see how this addresses the question: Just to repeat with
> slightly different wording - why are you using generic_flsl() instead
> of just flsl()?
Oh, sorry, just got the question wrong.
No specific reason for generic_flsl().
I'm just about to send the last 3 patches as a V11, so no need for you
to modify the patch.
Juergen
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2017-09-28 9:52 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-25 10:00 [PATCH v10 00/11] xen: better grant v2 support Juergen Gross
2017-09-25 10:00 ` [PATCH v10 01/11] xen: add function for obtaining highest possible memory address Juergen Gross
2017-09-25 10:19 ` Jan Beulich
2017-09-28 0:29 ` Julien Grall
2017-09-25 10:00 ` [PATCH v10 02/11] libxc: add libxc support for setting grant table resource limits Juergen Gross
2017-09-25 10:00 ` [PATCH v10 03/11] tools: set grant limits for xenstore stubdom Juergen Gross
2017-09-25 10:00 ` [PATCH v10 04/11] libxl: add max possible mfn to libxl_physinfo Juergen Gross
2017-09-25 10:00 ` [PATCH v10 05/11] xl: add global grant limit config items Juergen Gross
2017-09-25 10:00 ` [PATCH v10 06/11] libxl: add libxl support for setting grant table resource limits Juergen Gross
2017-09-25 10:00 ` [PATCH v10 07/11] xen: delay allocation of grant table sub structures Juergen Gross
2017-09-25 10:16 ` Jan Beulich
2017-09-28 18:56 ` Andrew Cooper
2017-09-29 4:27 ` Juergen Gross
2017-09-25 10:00 ` [PATCH v10 08/11] xen/arm: move arch specific grant table bits into grant_table.c Juergen Gross
2017-09-28 0:31 ` Julien Grall
2017-09-25 10:00 ` [PATCH v10 09/11] xen: make grant resource limits per domain Juergen Gross
2017-09-25 11:49 ` Jan Beulich
2017-09-28 0:26 ` Julien Grall
2017-09-28 7:21 ` Juergen Gross
2017-09-25 10:00 ` [PATCH v10 10/11] xen: add new Xen cpuid node for max address width info Juergen Gross
2017-09-25 11:55 ` Andrew Cooper
2017-09-25 12:00 ` Juergen Gross
2017-09-25 12:02 ` Andrew Cooper
2017-09-25 12:03 ` Jan Beulich
2017-09-25 11:59 ` Jan Beulich
2017-09-28 8:59 ` Jan Beulich
[not found] ` <59CCD61D0200007800180567@suse.com>
2017-09-28 9:04 ` Juergen Gross
2017-09-28 9:40 ` Jan Beulich
[not found] ` <59CCDFBD02000078001805E9@suse.com>
2017-09-28 9:52 ` Juergen Gross [this message]
2017-09-28 10:05 ` Jan Beulich
2017-09-25 10:00 ` [PATCH v10 11/11] xen: add some comments in include/public/arch-x86/cpuid.h Juergen Gross
2017-09-25 12:01 ` Jan Beulich
2017-09-28 11:50 ` George Dunlap
2017-09-28 11:54 ` Jan Beulich
2017-09-28 19:24 ` Julien Grall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47ae2d9d-969a-dba0-fbc9-075fa58ed7fb@suse.com \
--to=jgross@suse.com \
--cc=George.Dunlap@eu.citrix.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=dgdegra@tycho.nsa.gov \
--cc=ian.jackson@eu.citrix.com \
--cc=julien.grall@arm.com \
--cc=sstabellini@kernel.org \
--cc=tim@xen.org \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).