From: Patrick Colp <pjcolp@cs.ubc.ca>
To: Keir Fraser <keir.fraser@eu.citrix.com>
Cc: Christoph Egger <Christoph.Egger@amd.com>,
"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
Ian Jackson <Ian.Jackson@eu.citrix.com>
Subject: Re: build fixes
Date: Tue, 12 Jan 2010 09:42:50 -0800 [thread overview]
Message-ID: <4B4CB49A.90802@cs.ubc.ca> (raw)
In-Reply-To: <C772640A.6287%keir.fraser@eu.citrix.com>
Keir Fraser wrote:
> On 12/01/2010 17:22, "Ian Jackson" <Ian.Jackson@eu.citrix.com> wrote:
>
>>> - seek_ret = lseek64(fd, i << PAGE_SHIFT, SEEK_SET);
>>> + seek_ret = lseek(fd, i << PAGE_SHIFT, SEEK_SET);
>> This is just wrong. It will break on >2G files.
>
> We build everything under tools/ with LFS support enabled, so off_t is 64
> bits even in 32-bit environments. FYI The bits to enable LFS support are in
> tools/Rules.mk.
According to the lseek64 man page, for 32-bit architectures to have 64-bit
off_t, you need:
#define _FILE_OFFSET_BITS 64
Which, as far as I know, isn't set. LFS just makes lseek64 available
(without it, the function doesn't exist).
Patrick
next prev parent reply other threads:[~2010-01-12 17:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-11 11:58 build fixes Christoph Egger
2010-01-12 17:22 ` Ian Jackson
2010-01-12 17:31 ` Christoph Egger
2010-01-12 17:38 ` Keir Fraser
2010-01-12 17:42 ` Patrick Colp [this message]
2010-01-12 17:47 ` Christoph Egger
2010-01-12 18:44 ` Keir Fraser
2010-01-12 18:00 ` Ian Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B4CB49A.90802@cs.ubc.ca \
--to=pjcolp@cs.ubc.ca \
--cc=Christoph.Egger@amd.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=keir.fraser@eu.citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).