xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] Change default cpufreq governor to ondemand
@ 2010-01-15 16:25 John Haxby
  2010-01-19  9:33 ` John Haxby
  0 siblings, 1 reply; 2+ messages in thread
From: John Haxby @ 2010-01-15 16:25 UTC (permalink / raw)
  To: xen-devel

[-- Attachment #1: Type: text/plain, Size: 779 bytes --]


Back in c/s 18950 the default cpufreq governor was set to userspace (it 
had previously been performance).  However, since there is no supplied 
userspace program or script that will change the frequency this is at 
best a no-op.  Worse, on some hardware with some BIOS revisions, this 
actually sets the CPUs running at their lowest frequency rather than 
their highest and there is a corresponding (and initially puzzling) drop 
in performance.

This patch changes the default governor to "ondemand" which should make 
it the same as the Linux default and will provide power savings for the 
majority without needing to write a userspace governor.  For those that 
want to install their own governor, that is still possible.

Signed-off-by: John Haxby <john.haxby@oracle.com>

[-- Attachment #2: xen-set-default-omdemand.patch --]
[-- Type: text/x-patch, Size: 663 bytes --]

diff -r 88d2273c3942 xen/include/acpi/cpufreq/cpufreq.h
--- a/xen/include/acpi/cpufreq/cpufreq.h	Fri Jan 15 08:27:27 2010 +0000
+++ b/xen/include/acpi/cpufreq/cpufreq.h	Fri Jan 15 16:07:03 2010 +0000
@@ -100,7 +100,7 @@
 extern int cpufreq_register_governor(struct cpufreq_governor *governor);
 extern int cpufreq_unregister_governor(struct cpufreq_governor *governor);
 extern struct cpufreq_governor *__find_governor(const char *governor);
-#define CPUFREQ_DEFAULT_GOVERNOR &cpufreq_gov_userspace
+#define CPUFREQ_DEFAULT_GOVERNOR &cpufreq_gov_dbs;
 
 /* pass a target to the cpufreq driver */
 extern int __cpufreq_driver_target(struct cpufreq_policy *policy,

[-- Attachment #3: Type: text/plain, Size: 138 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] Change default cpufreq governor to ondemand
  2010-01-15 16:25 [PATCH] Change default cpufreq governor to ondemand John Haxby
@ 2010-01-19  9:33 ` John Haxby
  0 siblings, 0 replies; 2+ messages in thread
From: John Haxby @ 2010-01-19  9:33 UTC (permalink / raw)
  To: xen-devel

On 15/01/10 16:25, John Haxby wrote:
> +#define CPUFREQ_DEFAULT_GOVERNOR&cpufreq_gov_dbs;

Thanks for fixing the typo, Kier.

jch

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2010-01-19  9:33 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-01-15 16:25 [PATCH] Change default cpufreq governor to ondemand John Haxby
2010-01-19  9:33 ` John Haxby

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).