From mboxrd@z Thu Jan 1 00:00:00 1970 From: Frank Van Der Linden Subject: Re: [PATCH 0/6 ] MCE: patches clean-up and fixing bugs Date: Thu, 28 Jan 2010 08:37:30 -0700 Message-ID: <4B61AF3A.9000301@Sun.COM> References: Mime-Version: 1.0 Content-Type: text/plain; CHARSET=US-ASCII; format=flowed Content-Transfer-Encoding: 7BIT Return-path: In-reply-to: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: "Jiang, Yunhong" Cc: Christoph Egger , "xen-devel@lists.xensource.com" , Keir Fraser , Jan Beulich List-Id: xen-devel@lists.xenproject.org Jiang, Yunhong wrote: > This series patches clean-up and fixing some bugs for MCE handler. Most of them are quite minor, except the vmsr.patch. > > Patch 1: bank.patch: Handle the virtual MCE MSR bank access correctly. > > Patch 2: vmsr.patch: Not GP fault when guest write non 0s or 1s to MCA CTL MSRs. > > Patch 3: put_domain.patch: put domain in mce action. > > Patch 4: mca_add_trans.patch: Fix the vMCE address translation for HVM guest. > > Patch 5: broadcast.patch: Add MCE broadcast checkiing. > > Patch 6: mce_printk.patch: Be more careful for printk in mce context. > > Thanks for the patches! Aside from the comments Christoph already made, these look good to me. Thanks for also including the mce_is_broadcast part, that fixes injection on NHM-EX. It would be good to re-integrate the mcheck handler for AMD and Intel, but as you said, you have a patch lined up for that, and that can be done in the future. - Frank