[PATCH 0/6 ] MCE: patches clean-up and fixing bugs

[PATCH 0/6 ] MCE: patches clean-up and fixing bugs

[Jiang, Yunhong]

This series patches clean-up and fixing some bugs for MCE handler. Most of them are quite minor, except the vmsr.patch.

Patch 1: bank.patch: Handle the virtual MCE MSR bank access correctly.

Patch 2: vmsr.patch: Not GP fault when guest write non 0s or 1s to MCA CTL MSRs.

Patch 3: put_domain.patch: put domain in mce action.

Patch 4: mca_add_trans.patch: Fix the vMCE address translation for HVM guest.

Patch 5: broadcast.patch: Add MCE broadcast checkiing.

Patch 6: mce_printk.patch: Be more careful for printk in mce context.

Thanks
Yunhong Jiang

Re: [PATCH 0/6 ] MCE: patches clean-up and fixing bugs

[Frank Van Der Linden]

Jiang, Yunhong wrote:
> This series patches clean-up and fixing some bugs for MCE handler. Most of them are quite minor, except the vmsr.patch.
>
> Patch 1: bank.patch: Handle the virtual MCE MSR bank access correctly.
>
> Patch 2: vmsr.patch: Not GP fault when guest write non 0s or 1s to MCA CTL MSRs.
>
> Patch 3: put_domain.patch: put domain in mce action.
>
> Patch 4: mca_add_trans.patch: Fix the vMCE address translation for HVM guest.
>
> Patch 5: broadcast.patch: Add MCE broadcast checkiing.
>
> Patch 6: mce_printk.patch: Be more careful for printk in mce context.
>
>   
Thanks for the patches! Aside from the comments Christoph already made, 
these look good to me. Thanks for also including the mce_is_broadcast 
part, that fixes injection on NHM-EX.

It would be good to re-integrate the mcheck handler for AMD and Intel, 
but as you said, you have a patch lined up for that, and that can be 
done in the future.

- Frank

RE: [PATCH 0/6 ] MCE: patches clean-up and fixing bugs

[Jiang, Yunhong]

>-----Original Message-----
>From: Frank.Vanderlinden@Sun.COM [mailto:Frank.Vanderlinden@Sun.COM]
>Sent: Thursday, January 28, 2010 11:38 PM
>To: Jiang, Yunhong
>Cc: Keir Fraser; xen-devel@lists.xensource.com; Jan Beulich; Christoph Egger
>Subject: Re: [PATCH 0/6 ] MCE: patches clean-up and fixing bugs
>
>Jiang, Yunhong wrote:
>> This series patches clean-up and fixing some bugs for MCE handler. Most of them
>are quite minor, except the vmsr.patch.
>>
>> Patch 1: bank.patch: Handle the virtual MCE MSR bank access correctly.
>>
>> Patch 2: vmsr.patch: Not GP fault when guest write non 0s or 1s to MCA CTL
>MSRs.
>>
>> Patch 3: put_domain.patch: put domain in mce action.
>>
>> Patch 4: mca_add_trans.patch: Fix the vMCE address translation for HVM guest.
>>
>> Patch 5: broadcast.patch: Add MCE broadcast checkiing.
>>
>> Patch 6: mce_printk.patch: Be more careful for printk in mce context.
>>
>>
>Thanks for the patches! Aside from the comments Christoph already made,
>these look good to me. Thanks for also including the mce_is_broadcast
>part, that fixes injection on NHM-EX.
>
>It would be good to re-integrate the mcheck handler for AMD and Intel,
>but as you said, you have a patch lined up for that, and that can be
>done in the future.

Yes, I'd put the re-integration as part of post-4.0 effort, although I will send out the patch before. 
My patches just try to make more function be common, but I don't think I'm the right candidate for the integration itself, as I'm not so well on AMD platform :(

--jyh

>
>- Frank