From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Zhai, Edwin" Subject: issue in unplug qemu PCI devices Date: Fri, 12 Feb 2010 16:48:25 +0800 Message-ID: <4B7515D9.7060407@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Ian Jackson Cc: Xen Developers , Keir Fraser , "Zhai, Edwin" List-Id: xen-devel@lists.xenproject.org IOEMU change set e7911109 uses Magic ioport (0x10) protocol for negotating with guest PV drivers during startup, and allowing PV drivers to disable hardware emulations thus preventing guest from seeing the same device through two paths. But when I tried PV drivers in xen upstream, this unplug logic never succeed. PV driver uses following io sequence to interact with platform_pci device in qemu: 1. inw 0x10 2. inb 0x12 3. outw(0x12, 0xbeef) 4. outl(0x10,0xdead) But I only saw 1&2 happened in xen io instruction emulation(x86_emulate), while 3&4 seemed to lost so the unplug will never happen. Are you aware of this issue? Or some suggestion for debugging? BTW, the unplug logic itself has some issues also: 1. Pass-through NICs are also unplugged, although them have different path with vnif and emulated NIC. 2. Unplug happens as long as inserting the xen_platform_pci module regardless of existence of PVed device in the config file. End user likely to unplug all the PCI device by accident. 3. Inserting xen_platform_pci module would unplug all the devices, which is not reasonable. E.g. end user only has vbd driver, but all NICs are also unplugged.