xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: "Jan Beulich" <JBeulich@novell.com>
To: Keir Fraser <keir.fraser@eu.citrix.com>
Cc: xen-devel@lists.xensource.com
Subject: Re: disallowed nesting of key handlers (c/s 20929)
Date: Fri, 12 Feb 2010 08:01:14 +0000	[thread overview]
Message-ID: <4B7518DA020000780002F2EB@vpn.id2.novell.com> (raw)
In-Reply-To: <4B75182C020000780002F2E1@vpn.id2.novell.com>

Oh, and I also think the shared scratch buffer should be at least large
enough to dump NR_CPUS and MAX_VIRT_CPUS wide bitmaps.

Jan

>>> "Jan Beulich" <JBeulich@novell.com> 12.02.10 08:58 >>>
Keir,

I don't think this is a good idea. In the course of analyzing issues with
tmem we had at least one case where this restriction would have
severely hindered debugging: The '0' handler wasn't able to put a
target vCPU to sleep (due to it spinning on a lock in the hypervisor),
and only the subsequent 'd' information really indicated what was
going on.

Generally expecting 'd' to be issued first also doesn't seem adequate
since that may not produce output in the case of a pCPU spinning
with interrupts disabled (whereas '0' in that case still has a chance
to produce useful output).

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com 
http://lists.xensource.com/xen-devel

      reply	other threads:[~2010-02-12  8:01 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-12  7:58 disallowed nesting of key handlers (c/s 20929) Jan Beulich
2010-02-12  8:01 ` Jan Beulich [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B7518DA020000780002F2EB@vpn.id2.novell.com \
    --to=jbeulich@novell.com \
    --cc=keir.fraser@eu.citrix.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).