From: "Jan Beulich" <JBeulich@novell.com>
To: Yunhong Jiang <yunhong.jiang@intel.com>,
Ashwin Pankaj <ashwin.pankaj@lsi.com>
Cc: Xen-devel@lists.xensource.com
Subject: Re: Xen PANIC in MCE interrupt context : can global variable dom0 be NULL ?
Date: Tue, 16 Feb 2010 09:05:33 +0000 [thread overview]
Message-ID: <4B7A6DED020000780002F961@vpn.id2.novell.com> (raw)
In-Reply-To: <4B795809.5070304@lsi.com>
>>> Ashwin Pankaj <ashwin.pankaj@lsi.com> 15.02.10 15:19 >>>
> After some digging, probable culprit seems to be smp_cmci_interrupt
>
>> if (bs.errcnt && mctc != NULL) {
>> if (guest_enabled_event(dom0->vcpu[0],
>> <------------------------------------ here
>> VIRQ_MCA)) {
>> mctelem_commit(mctc);
>> printk(KERN_DEBUG "CMCI: send CMCI to DOM0 through virq\n");
>> send_guest_global_virq(dom0, VIRQ_MCA);
>> } else {
>> x86_mcinfo_dump(mctelem_dataptr(mctc));
>> mctelem_dismiss(mctc);
>> }
>
>
>Looks like dom0 is NULL here ( vcpu[0] offset is 0x468). Is this possible?
Yes, your call trace confirms this.
>Other functions like mce_softirq() perform a NULL check on dom0 before
>accessing it's members ....
The majority of uses doesn't seem to do that check, yet it is essential
if CMCIs occur during boot of Xen. Even more, it should not only be
dom0 that is checked against NULL, but also dom0->vcpu (or
dom0->max_vcpus) and dom0->vcpu[0].
Jan
next prev parent reply other threads:[~2010-02-16 9:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-15 14:19 Xen PANIC in MCE interrupt context : can global variable dom0 be NULL ? Ashwin Pankaj
2010-02-16 9:05 ` Jan Beulich [this message]
2010-02-16 10:37 ` Jiang, Yunhong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B7A6DED020000780002F961@vpn.id2.novell.com \
--to=jbeulich@novell.com \
--cc=Xen-devel@lists.xensource.com \
--cc=ashwin.pankaj@lsi.com \
--cc=yunhong.jiang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).