From mboxrd@z Thu Jan 1 00:00:00 1970 From: Weidong Han Subject: Re: [PATCH][RFC] gfx_passthru: warning when vgabios rom has invalid checksum Date: Mon, 22 Feb 2010 15:21:44 +0800 Message-ID: <4B823088.8090706@intel.com> References: <4B8219F1.5040301@jp.fujitsu.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-2022-JP Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <4B8219F1.5040301@jp.fujitsu.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Noboru Iwamatsu Cc: "xen-devel@lists.xensource.com" , "Ian.Jackson@eu.citrix.com" List-Id: xen-devel@lists.xenproject.org Noboru Iwamatsu wrote: > Hi, > > According to the "PCI Firmware Spec Rev 3.0", > the system firmware have to write the new checksum after resizing > the expansion ROM area. > > So, when re-using the shadowed VGABIOS, the checksum must > be valid, and if it is invalid, we should consider the BIOS has > a bug or memory area is corrupted. > > This patch just add the warning message when checksum requires > recalculation. > > I tried this following environments. > > Intel DX58SO + GeForce GTS250: checksum is OK. > Intel DX58SO + GeForce 9600GT: checksum is OK. > Fujitsu Q35 M/B + IGD: checksum is bad. > What does "checksum is bad" mean here? > What do you think, Weidong? > Is just warning enough? Or, should we stop loading the rom? > > Does it still work or not when checksum is bad? If it works, we should not stop loading the rom. Regards, Weidong > Regards, > Noboru. >