xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] Linux: Fwd: blkfront: Fix an unlikely xenbus crasher
@ 2010-03-01  9:31 Jan Beulich
  0 siblings, 0 replies; only message in thread
From: Jan Beulich @ 2010-03-01  9:31 UTC (permalink / raw)
  To: xen-devel

[-- Attachment #1: Type: text/plain, Size: 538 bytes --]

Getting partition 0 should not fail, but if it does we won't continue.

Signed-off-by: Daniel Stodden <daniel.stodden@citrix.com>
Signed-off-by: Jan Beulich <jbeulich@novell.com>

--- a/drivers/xen/blkfront/blkfront.c
+++ b/drivers/xen/blkfront/blkfront.c
@@ -285,8 +285,10 @@
 
 	case XenbusStateClosing:
 		bd = bdget(info->dev);
-		if (bd == NULL)
+		if (bd == NULL) {
 			xenbus_dev_fatal(dev, -ENODEV, "bdget failed");
+			break;
+		}
 
 #if LINUX_VERSION_CODE < KERNEL_VERSION(2,6,17)
 		down(&bd->bd_sem);




[-- Attachment #2: blkfront-xenbus-oops.patch --]
[-- Type: text/plain, Size: 586 bytes --]

Subject: blkfront: Fix an unlikely xenbus crasher.

Getting partition 0 should not fail, but if it does we won't continue.

Signed-off-by: Daniel Stodden <daniel.stodden@citrix.com>
Signed-off-by: Jan Beulich <jbeulich@novell.com>

--- a/drivers/xen/blkfront/blkfront.c
+++ b/drivers/xen/blkfront/blkfront.c
@@ -285,8 +285,10 @@
 
 	case XenbusStateClosing:
 		bd = bdget(info->dev);
-		if (bd == NULL)
+		if (bd == NULL) {
 			xenbus_dev_fatal(dev, -ENODEV, "bdget failed");
+			break;
+		}
 
 #if LINUX_VERSION_CODE < KERNEL_VERSION(2,6,17)
 		down(&bd->bd_sem);

[-- Attachment #3: Type: text/plain, Size: 138 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2010-03-01  9:31 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-03-01  9:31 [PATCH] Linux: Fwd: blkfront: Fix an unlikely xenbus crasher Jan Beulich

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).