From: "Jan Beulich" <JBeulich@novell.com>
To: Daniel Stodden <daniel.stodden@citrix.com>
Cc: JeremyFitzhardinge <jeremy@goop.org>,
"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
Subject: Re: [PATCH] linux/blkfront: fixes for 'xm block-detach ... --force'
Date: Mon, 01 Mar 2010 10:07:05 +0000 [thread overview]
Message-ID: <4B8B9FD90200007800031D04@vpn.id2.novell.com> (raw)
In-Reply-To: <1267221034.30168.71.camel@agari.van.xensource.com>
>>> Daniel Stodden <daniel.stodden@citrix.com> 26.02.10 22:50 >>>
>I think this one resulted in blkfront_remove (from xenbus) racing
>against blkif_release (run from close(bdev)).
>
>Both running for their respective kfree(info) vs. subsequent
>dereferences. Or just to leak info entirely.
>
>We only had blkfront_closing() on either thread before, which serializes
>around the bd_mutex.
>
>I'm currently thinking that info now rather wants a refcount of its own.
>Ideally replacing is_ready entirely, maybe.
>
>Any thoughts?
Could you check the fixup patch I sent just a couple of minutes
ago (paralleling c/s 993 on the 2.6.18 tree)?
Thanks, Jan
prev parent reply other threads:[~2010-03-01 10:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-18 10:19 [PATCH] linux/blkfront: fixes for 'xm block-detach ... --force' Jan Beulich
2010-02-26 21:50 ` Daniel Stodden
2010-03-01 10:07 ` Jan Beulich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B8B9FD90200007800031D04@vpn.id2.novell.com \
--to=jbeulich@novell.com \
--cc=daniel.stodden@citrix.com \
--cc=jeremy@goop.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).